Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable property#10993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mho22
Copy link
Contributor

PR Checklist

Overview

Ruleuse-unknown-in-catch-callback-variable hasfixable: 'code' andhasSuggestions: true properties inmeta.

But each fix is located in asuggest property. Makingfixable : 'code' useless.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@mho22!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 24, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita9a3bf1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67e254fd8107ce000821db81
😎 Deploy Previewhttps://deploy-preview-10993--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commita9a3bf1.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded6sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-03-25 07:15:51 UTC

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks!

mho22 reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 24, 2025
@mho22mho22 changed the titlefix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable propertyfix(eslint-plugin): [use-unknown-in-catch-callback-variable] remove fixable propertyMar 24, 2025
@mho22
Copy link
ContributorAuthor

mho22 commentedMar 24, 2025•
edited
Loading

@JoshuaKGoldberg I guess the failed check is related to issue#10992.

JoshuaKGoldberg and kirkwaiblinger reacted with thumbs up emoji

@codecovCodecov
Copy link

codecovbot commentedMar 24, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.02%. Comparing base(3241e46) to head(a9a3bf1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10993   +/-   ##=======================================  Coverage   88.02%   88.02%           =======================================  Files         470      470             Lines       16790    16790             Branches     4742     4742           =======================================  Hits        14780    14780             Misses       1664     1664             Partials      346      346
FlagCoverage Δ
unittest88.02% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...rc/rules/use-unknown-in-catch-callback-variable.ts97.53% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg merged commit58d7f40 intotypescript-eslint:mainMar 27, 2025
56 of 57 checks passed
@mho22mho22 deleted the fix-use-unknown-in-catch-callback-variable branchMarch 27, 2025 15:52
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 1, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 1, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 4, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [use-unknown-in-catch-callback-variable] shouldn't havefixable property
3 participants
@mho22@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp