Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(website): Show tsconfig parsing errors in tab#10991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
developer-bandi wants to merge6 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromdeveloper-bandi:feature/tscofing-view-error

Conversation

developer-bandi
Copy link
Contributor

@developer-bandideveloper-bandi commentedMar 23, 2025•
edited
Loading

PR Checklist

Overview

I'm trying to manage tsconfig errors with different markers and statuses.

Because I couldn't integrate tsconfig errors into markers since markers change depending on editor changes, and I thought it was wrong to apply tsconfig where markers are created.

treat in below comment, change marker type toRecord<TabType,ErrorGroup[]>

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@developer-bandideveloper-bandi marked this pull request as draftMarch 23, 2025 15:00
@netlifyNetlify
Copy link

netlifybot commentedMar 23, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit74e80cf
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67fa38103502b30007ea73fb
😎 Deploy Previewhttps://deploy-preview-10991--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 23, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit74e80cf.

CommandStatusDurationResult
nx run utils:test -- --coverage❌ Failed4sView ↗
nx run-many --target=lint --exclude eslint-plugin✅ Succeeded22sView ↗
nx test parser✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run typescript-eslint:test -- --coverage✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many --target=clean✅ Succeeded13sView ↗
nx test typescript-eslint✅ Succeeded<1sView ↗
Additional runs (17)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-04-12 09:58:53 UTC

@armano2
Copy link
Collaborator

armano2 commentedMar 23, 2025•
edited
Loading

maybe we should just extends fs to contain info about errors for specific files, with that we could change/swap what we display based on file that is selected?

tsconfig is a file (model) in monaco, similar to any other file, and its cloned as vfs file

developer-bandi reacted with thumbs up emoji

@developer-bandi
Copy link
ContributorAuthor

developer-bandi commentedMar 24, 2025•
edited
Loading

maybe we should just extends fs to contain info about errors for specific files, with that we could change/swap what we display based on file that is selected?

tsconfig is a file (model) in monaco, similar to any other file, and its cloned as vfs file

If I understand correctly, you mean changing the type of markers toRecord<TabType,ErrorGroup[]> and displaying the corresponding error depending on the selected tab?

armano2 reacted with thumbs up emoji

@developer-bandideveloper-bandi marked this pull request as ready for reviewMarch 27, 2025 14:02
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for getting this started! I think I found a bug? Also left a question and a few refactor suggestions.

Comment on lines +175 to +176
.split('\n')
.map((message: string) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you have an example of a message that needs to be split? I've only been able to make versions with a single reported error at a time.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure if this is realistic, but I used split because I was able to generate two errors with the settings below.

{  "compilerOptions": {    "moduleResolution": "classic",    "resolveJsonModule": true,    "incremental": true,    "outFile": "dist/bundle.js"  }}
스크린샷 2025-04-12 오전 11 12 03

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 31, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Display tsconfig errors in playground
3 participants
@developer-bandi@armano2@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp