Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable erasableSyntaxOnly in tools#10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kirkwaiblinger merged 2 commits intotypescript-eslint:mainfrom43081j:eso-tools
Mar 20, 2025

Conversation

43081j
Copy link
Contributor

@43081j43081j commentedMar 19, 2025•
edited by kirkwaiblinger
Loading

Is this what you meant@kirkwaiblinger?

we can't enable it at repo level since the ast-types use enums still

PR Checklist

kirkwaiblinger and Rel1cx reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 19, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8d3c204
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67dc58a506f5a20008cade05
😎 Deploy Previewhttps://deploy-preview-10969--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 19, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit8d3c204.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded5sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-03-20 18:12:23 UTC

@43081j43081j changed the titlecleanup(repo): enable erasableSyntaxOnly in toolschore(repo): enable erasableSyntaxOnly in toolsMar 19, 2025
@kirkwaiblingerkirkwaiblinger marked this pull request as draftMarch 19, 2025 09:25
@kirkwaiblinger
Copy link
Member

Is this what you meant@kirkwaiblinger?

we can't enable it at repo level since the ast-types use enums still

yep! exactly! 👍

@kirkwaiblingerkirkwaiblinger changed the titlechore(repo): enable erasableSyntaxOnly in toolschore: enable erasableSyntaxOnly in toolsMar 19, 2025
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 20, 2025
@kirkwaiblingerkirkwaiblinger marked this pull request as ready for reviewMarch 20, 2025 18:03
@kirkwaiblingerkirkwaiblinger merged commit8fd8069 intotypescript-eslint:mainMar 20, 2025
55 of 57 checks passed
@43081j43081j deleted the eso-tools branchMarch 20, 2025 18:37
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable TS 5.8 erasableSyntaxOnly for our "executable" TS files
2 participants
@43081j@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp