declareconsttest:Array<{a?:string}>;// Reported by TypeScript as the object is possibly 'undefined'test[0].a;if(test[0]?.a){// Optional chaining isn't necessary heretest[0].a;}if(test[0]?.a){// Should be reported but doesn't?test[0]?.a;}

Note that this also causes the rule to report on unnecessary optional index access that's deeper in the chain (only whennoUncheckedIndexedAccess is turned on):

declareconstarr2:Array<{x:{y:{z:object}}}>;// the following (previously wasn't reported):arr2[42]?.x?.y?.z;// is auto-fixed into:arr2[42]?.x.y.z;

I've added a couple of tests to verify the rule handles these cases correctly whennoUncheckedIndexedAccess is enabled.

initial implementation

06db97e

Copy link

Contributor

typescript-eslintbot commentedMar 16, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 16, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e3a479c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67e0613591b72a000881cbc2
😎 Deploy Preview	https://deploy-preview-10961--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedMar 16, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commite3a479c.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-03-24 11:52:57 UTC

Copy link

codecovbot commentedMar 16, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base(543d36c) to head(e3a479c).
Report is 13 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10961      +/-   ##==========================================+ Coverage   87.58%   87.97%   +0.38%==========================================  Files         470      470                Lines       16095    16710     +615       Branches     4668     4711      +43     ==========================================+ Hits        14097    14700     +603- Misses       1642     1664      +22+ Partials      356      346      -10

Flag	Coverage Δ
unittest	`87.97% <100.00%> (+0.38%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	`99.21% <100.00%> (+<0.01%)`	⬆️

... and15 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

add tests

a03ba8e

ronami marked this pull request as ready for review

March 16, 2025 18:53

ronami changed the title~~fix(eslint-plugin): don't report on unnecessary optional array index access whennoUncheckedIndexedAccess is enabled~~fix(eslint-plugin): [no-unnecessary-condition] don't report on unnecessary optional array index access whennoUncheckedIndexedAccess is enabled

Mar 16, 2025