Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): support arbitrary extensions in definition files#10957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

dbarabashh
Copy link
Contributor

PR Checklist

Overview

This PR#10911 adds support for TypeScript'sallowArbitraryExtensions feature in theisDefinitionFile utility.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@dbarabashh!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 15, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitfce0375
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67d84fd48274a00008d1aaeb
😎 Deploy Previewhttps://deploy-preview-10957--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 91 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 15, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitfce0375.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded7m 45sView ↗
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 12sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded6m 48sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded18sView ↗
nx test rule-tester✅ Succeeded<1sView ↗
nx run integration-tests:test✅ Succeeded2m 24sView ↗
nx test ast-spec✅ Succeeded<1sView ↗
Additional runs (25)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-03-17 16:54:47 UTC

@codecovCodecov
Copy link

codecovbot commentedMar 15, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base(543d36c) to head(fce0375).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10957      +/-   ##==========================================+ Coverage   87.58%   87.97%   +0.38%==========================================  Files         470      470                Lines       16095    16709     +614       Branches     4668     4710      +42     ==========================================+ Hits        14097    14699     +602- Misses       1642     1664      +22+ Partials      356      346      -10
FlagCoverage Δ
unittest87.97% <100.00%> (+0.38%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/util/misc.ts98.82% <100.00%> (ø)

... and15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems reasonable, thanks for hopping on this issue! Left a couple of comments. 🚀

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 17, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🔥

@JoshuaKGoldbergJoshuaKGoldberg merged commit9a9670d intotypescript-eslint:mainMar 31, 2025
57 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 1, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestApr 1, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.27.0 | 8.29.0 || npm        | @typescript-eslint/parser        | 8.27.0 | 8.29.0 |## [v8.29.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8290-2025-03-31)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] create `ignoreIfStatements` option ([#11000](typescript-eslint/typescript-eslint#11000))##### 🩹 Fixes-   **eslint-plugin:** \[no-array-constructor] remove optional chaining exemption ([#10963](typescript-eslint/typescript-eslint#10963))-   **eslint-plugin:** support arbitrary extensions in definition files ([#10957](typescript-eslint/typescript-eslint#10957))-   **eslint-plugin:** \[prefer-for-of] fix false positive when using erasable type syntax within update expressions ([#10981](typescript-eslint/typescript-eslint#10981))-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] remove fixable property ([#10993](typescript-eslint/typescript-eslint#10993))-   **eslint-plugin:** \[no-unnecessary-condition] don't report on unnecessary optional array index access when `noUncheckedIndexedAccess` is enabled ([#10961](typescript-eslint/typescript-eslint#10961))##### ❤️ Thank You-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   Yannick Decat [@mho22](https://github.com/mho22)-   zyoshoka [@zyoshoka](https://github.com/zyoshoka)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.28.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8280-2025-03-24)##### 🚀 Features-   **eslint-plugin:** \[prefer-nullish-coalescing] support `if` statement assignment (`??=`) and fix several minor bugs ([#10861](typescript-eslint/typescript-eslint#10861))##### 🩹 Fixes-   **eslint-plugin:** \[no-unsafe-function-type] remove fixable property ([#10986](typescript-eslint/typescript-eslint#10986))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Yannick Decat [@mho22](https://github.com/mho22)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
aryaemami59 pushed a commit to aryaemami59/typescript-eslint that referenced this pull requestApr 5, 2025
…ypescript-eslint#10957)* support arbitrary extensions in definition files* updated test case* updated test and refactoring
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug:isDefinitionFile utility doesn't consider arbitrary extensions
2 participants
@dbarabashh@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp