fix(typescript-estree): fix span start for decorated`AssignmentPattern` function parameter#10939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromronami:fix-assignment-pattern-parameter-range

Mar 17, 2025

Merged

fix(typescript-estree): fix span start for decorated`AssignmentPattern` function parameter#10939

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromronami:fix-assignment-pattern-parameter-range

Mar 17, 2025

Conversation

Copy link

Member

ronami commentedMar 11, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: wrong span start for decorated AssignmentPattern parameter #10937
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#10937 and adjusts the range for decoratedAssignmentPattern function parameter to match other binding patterns.

I've added a test for this since the change didn't cause any tests to fail (and so this was probably missing a test).

ronami added2 commits

March 11, 2025 19:15

initial implementation

8e92316

tests

ce10510

Copy link

Contributor

typescript-eslintbot commentedMar 11, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 11, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0b94d61`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67d0741dfc809200081dc582
😎 Deploy Preview	https://deploy-preview-10939--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports