Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [no-unused-private-class-members] new extension rule#10913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 15 commits intomainfromno-unused-private-class-members
Nov 11, 2025

Conversation

@bradzacher
Copy link
Member

PR Checklist

Overview

This PR implements an extension rule forno-unused-private-class-members that introduces support forprivate members.

zanminkian, ronami, LvChengbin, kddsultan, johan13, strelga, Zamiell, Julien-Marcou, and Martinspire reacted with thumbs up emojiJulien-Marcou reacted with hooray emojikirkwaiblinger, ronami, and Zamiell reacted with heart emojiJulien-Marcou and parth391 reacted with rocket emoji
@bradzacherbradzacher added the enhancement: new base rule extensionNew base rule extension required to handle a TS specific case labelMar 3, 2025
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedMar 3, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf7beddc
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/691362c4eb88bb0008373ad7
😎 Deploy Previewhttps://deploy-preview-10913--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 78 (🔴 down 18 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloud
Copy link

nx-cloudbot commentedMar 3, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf7beddc

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded4m 53sView ↗
nx run-many -t lint✅ Succeeded3m 19sView ↗
nx run-many -t typecheck✅ Succeeded2m 15sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded2sView ↗
nx run types:build✅ Succeeded5sView ↗
nx run generate-configs✅ Succeeded7sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-11-11 16:33:26 UTC

@nx-cloud
Copy link

nx-cloudbot commentedMar 3, 2025

View yourCI Pipeline Execution ↗ for commit34b77b8.

☁️Nx Cloud last updated this comment at2025-03-03 02:18:54 UTC

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMar 3, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Conan O'Brien frankly saying 'yep'

ronami reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 3, 2025
// mark the first member we encounter as used. If you were to delete the
// member, then any subsequent usage could incorrectly mark the member of
// an encapsulating parent class as used, which is incorrect.
trackedClassMembersUsed.add(memberDefinition.declaredNode);
Copy link
Member

@ronamironamiMar 6, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Bug]: I've noticed some missed reports with functions that have a differentthis than the class instance (deploy preview playground link):

classTest1{// should be reported but doesn't?privatebar:number;foo=function(){returnthis.bar;}}

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is because the base rule doesn't support that case becausethis.#bar is a syntax error inside a function expression!!

It's worth noting that TS doesn't actually catch this case either and reportsbar as unused because the type of thethis in the function expression isany!
If you turn onnoImplicitThis then TS will error on thatthis

We could support this if we wanted to. I'm leaning towards not because TS itself doesn't catch it either.

Copy link
Member

@ronamironamiMar 9, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes! I think the rule should reportbar as unused in this case. I've mentioned this since TypeScript reports it as unused but the rule doesn't report it as unused (regardless of the type error).

Copy link
MemberAuthor

@bradzacherbradzacherOct 20, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Coming back to this -- my code handles this correctly because realistically it is an actual usage of the parameter.

For examplenew Test1().foo() will return the value ofbar.
There's an implicit binding here and so I think this is fine to keepnot reporting on.

Copy link
Member

@ronamironami left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks amazing! Excited to enable this on projects I work on 🚀🚀🚀

(I accidentally posted the review earlier while still adding comments 🙈)

@bradzacher
Copy link
MemberAuthor

FYI I'm going to make@Josh-Cena very happy - I'm going to build a "class scope analyser" so we can do this right rather than just hacking it in.

This does mean that I'm going to rewrite the rule from the ground up -- but it'll be worht it

kirkwaiblinger, JoshuaKGoldberg, and Josh-Cena reacted with laugh emoji

@kirkwaiblinger
Copy link
Member

kirkwaiblinger commentedMar 19, 2025•
edited
Loading

FYI I'm going to make@Josh-Cena very happy - I'm going to build a "class scope analyser" so we can do this right rather than just hacking it in.

This does mean that I'm going to rewrite the rule from the ground up -- but it'll be worht it

Do you intend for this to proceed as-is, with this work intended to happen in the future, or should we pause/draft it pending this work?

@bradzacher
Copy link
MemberAuthor

Let's draft it.
We need to at least handle the static property case.
Might have some time soon to pick the work back up.

kirkwaiblinger and JoshuaKGoldberg reacted with thumbs up emoji

@kirkwaiblingerkirkwaiblinger added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 19, 2025
@kirkwaiblingerkirkwaiblinger marked this pull request as draftMarch 19, 2025 09:39
@JoshuaKGoldbergJoshuaKGoldberg removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 24, 2025
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelJul 13, 2025
@bradzacherbradzacher marked this pull request as ready for reviewAugust 10, 2025 05:39
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks amazing and a very beneficial rule to have; just a few small comments from me 🚀🚀🚀

meta: {
type: 'problem',
docs: {
description: 'Disallow unused private class members',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is a bug and shouldn't be reported (deploy preview playground link):

classTest1{// reported but shouldn't?privatefoo:number|null;publicbar(){this.foo??=1;}}

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a weird case that isn't currently reported byno-unused-vars but really should be.

It is reported by the baseno-unused-private-class-members rule

Copy link
Member

@kirkwaiblingerkirkwaiblingerAug 27, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There was just a recent eslint bug report about these; I guess it's intentional for no-unused-vars sincex ?? = yreadsx first (equivalent tox != null ? x : (x = y)) rather thanunconditionally assigning (x = x != null ? x : y). Seeeslint/eslint#20029. But presumably the two rules should agree?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, but do note that these are reported by no-useless-assignment so 🤷‍♂️ 🤷‍♂️

(playground)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we should probably file a bug for NUPCM then so it matches NUV?

kirkwaiblinger reacted with thumbs up emoji
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have very little to add that Kirk and Ronami didn't already. Very exciting!! ⚡

ronami reacted with rocket emoji
*/
export function extractNameForMember(node: MemberNode): [Key, string] | null {
if (node.computed) {
return extractComputedName(node.key);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just noting,#11006 has some other logic around computed keys. It might be useful to unify?

bradzacher reacted with thumbs up emoji
@bradzacher
Copy link
MemberAuthor

@ronami /@JoshuaKGoldberg /@kirkwaiblinger

Added support for:

Parameter properties

classTest1{constructor(// errorsprivateparameterPropertyUnused:number,// no errorprivateparameterPropertyUsed:number,){}method(){returnthis.parameterPropertyUsed;}}

Usage of a private class member via explicitly and simply annotated variables:

classFoo{// no longer reportedprivateprop:number;// no longer reportedprivatestaticProp:number;method1(thing:Foo){returnthing.prop;}method2(thing:typeofFoo){returnthing.staticProp;}}

Usage of a private class member via simple assignment:

classFoo{// no longer reportedprivateprop:number;method(){constself=this;returnself.prop;}}
ronami reacted with thumbs up emoji

@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 20, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 3, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lint complaints notwithstanding, this looks great to me! I'll defer to the other reviewers on the finer points they're calling out. But the overall scope analyzer looks great and I'm very happy with the clean rule implementation. Nicely done! 👏

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 3, 2025
ronami
ronami previously approved these changesNov 5, 2025
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looking great 👏👏👏

@bradzacherbradzacherforce-pushed theno-unused-private-class-members branch from408410c to2ccb638CompareNovember 11, 2025 16:21
@codecov
Copy link

codecovbot commentedNov 11, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is82.10181% with109 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.56%. Comparing base (0fac889) to head (f7beddc).
⚠️ Report is 1 commits behind head on main.

Files with missing linesPatch %Lines
...rc/util/class-scope-analyzer/classScopeAnalyzer.ts82.45%82 Missing and 1 partial⚠️
...c/util/class-scope-analyzer/extractComputedName.ts65.33%26 Missing⚠️

❌ Your patch status has failed because the patch coverage (82.10%) is below the target coverage (90.00%). You can increase the patch coverage or adjust thetarget coverage.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10913      +/-   ##==========================================- Coverage   90.66%   90.56%   -0.10%==========================================  Files         518      522       +4       Lines       52454    53063     +609       Branches     8694     8838     +144     ==========================================+ Hits        47558    48058     +500- Misses       4882     4990     +108- Partials       14       15       +1
FlagCoverage Δ
unittest90.56% <82.10%> (-0.10%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/configs/eslintrc/all.ts100.00% <100.00%> (ø)
packages/eslint-plugin/src/configs/flat/all.ts100.00% <100.00%> (ø)
...lugin/src/rules/no-unused-private-class-members.ts100.00% <100.00%> (ø)
...lint-plugin/src/util/class-scope-analyzer/types.ts100.00% <100.00%> (ø)
...c/util/class-scope-analyzer/extractComputedName.ts65.33% <65.33%> (ø)
...rc/util/class-scope-analyzer/classScopeAnalyzer.ts82.45% <82.45%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradzacherbradzacher merged commit6c6db24 intomainNov 11, 2025
66 of 69 checks passed
@bradzacherbradzacher deleted the no-unused-private-class-members branchNovember 11, 2025 16:34
@bradzacherbradzacher linked an issueNov 11, 2025 that may beclosed by this pull request
ch4og pushed a commit to csmplay/mapban that referenced this pull requestNov 18, 2025
This PR contains the following updates:| Package | Change | Age | Confidence ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) || [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.39.1` -> `8.47.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.39.1/8.47.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.39.1/8.47.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#&#8203;10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@&#8203;bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#&#8203;11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#&#8203;11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#&#8203;11006](typescript-eslint/typescript-eslint#11006), [#&#8203;10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- Kentaro Suzuki [@&#8203;sushichan044](https://github.com/sushichan044)- Maria Solano [@&#8203;MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#&#8203;11722](typescript-eslint/typescript-eslint#11722), [#&#8203;11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#&#8203;11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@&#8203;undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#&#8203;11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)##### 🩹 Fixes- **eslint-plugin:** \[no-misused-promises] special-case `.finally` not to report when a promise returning function is provided as an argument ([#&#8203;11667](typescript-eslint/typescript-eslint#11667))- **eslint-plugin:** \[prefer-optional-chain] include mixed "nullish comparison style" chains in checks ([#&#8203;11533](typescript-eslint/typescript-eslint#11533))##### ❤️ Thank You- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)##### 🚀 Features- **eslint-plugin:** \[no-unsafe-member-access] add allowOptionalChaining option ([#&#8203;11659](typescript-eslint/typescript-eslint#11659))- **rule-schema-to-typescript-types:** clean up and make public ([#&#8203;11633](typescript-eslint/typescript-eslint#11633))##### 🩹 Fixes- **eslint-plugin:** \[prefer-readonly-parameter-types] ignore tagged primitives ([#&#8203;11660](typescript-eslint/typescript-eslint#11660))- **typescript-estree:** forbid abstract method and accessor to have implementation ([#&#8203;11657](typescript-eslint/typescript-eslint#11657))- **eslint-plugin:** removed error type previously deprecated ([#&#8203;11674](typescript-eslint/typescript-eslint#11674))- **eslint-plugin:** \[no-deprecated] ignore deprecated `export import`s ([#&#8203;11603](typescript-eslint/typescript-eslint#11603))- **eslint-plugin:** \[unbound-method] improve wording around `this: void` and binding ([#&#8203;11634](typescript-eslint/typescript-eslint#11634))- **rule-tester:** deprecate TestCaseError#type and LintMessage#nodeType ([#&#8203;11628](typescript-eslint/typescript-eslint#11628))- **eslint-plugin:** \[no-floating-promises] remove excess parentheses in suggestions ([#&#8203;11487](typescript-eslint/typescript-eslint#11487))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)- Josh Goldberg ✨- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- Mark de Dios [@&#8203;peanutenthusiast](https://github.com/peanutenthusiast)- Richard Torres [@&#8203;richardtorres314](https://github.com/richardtorres314)- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)##### 🚀 Features- **eslint-plugin:** expose rule name via RuleModule interface ([#&#8203;11616](typescript-eslint/typescript-eslint#11616))##### 🩹 Fixes- **eslint-plugin:** \[prefer-nullish-coalescing] ignoreBooleanCoercion should not apply to top-level ternary expressions ([#&#8203;11614](typescript-eslint/typescript-eslint#11614))- **eslint-plugin:** \[no-base-to-string] check if superclass is ignored ([#&#8203;11617](typescript-eslint/typescript-eslint#11617))##### ❤️ Thank You- mdm317- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)##### 🩹 Fixes- **eslint-plugin:** \[await-thenable] should not report passing values to promise aggregators which may be a promise in an array literal ([#&#8203;11611](typescript-eslint/typescript-eslint#11611))- **eslint-plugin:** \[no-unsafe-enum-comparison] support unions of literals ([#&#8203;11599](typescript-eslint/typescript-eslint#11599))- **eslint-plugin:** \[no-base-to-string] make ignoredTypeNames match type names without generics ([#&#8203;11597](typescript-eslint/typescript-eslint#11597))##### ❤️ Thank You- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)##### 🚀 Features- **eslint-plugin:** \[await-thenable] report invalid (non-promise) values passed to promise aggregator methods ([#&#8203;11267](typescript-eslint/typescript-eslint#11267))##### 🩹 Fixes- **eslint-plugin:** \[no-unnecessary-type-conversion] ignore enum members ([#&#8203;11490](typescript-eslint/typescript-eslint#11490))##### ❤️ Thank You- Moses Odutusin [@&#8203;thebolarin](https://github.com/thebolarin)- Ronen AmielYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)##### 🚀 Features- **typescript-estree:** disallow empty type parameter/argument lists ([#&#8203;11563](typescript-eslint/typescript-eslint#11563))##### 🩹 Fixes- **eslint-plugin:** \[prefer-return-this-type] don't report an error when returning a union type that includes a classType ([#&#8203;11432](typescript-eslint/typescript-eslint#11432))- **eslint-plugin:** \[no-deprecated] should report deprecated exports and reexports ([#&#8203;11359](typescript-eslint/typescript-eslint#11359))- **eslint-plugin:** \[no-floating-promises] allowForKnownSafeCalls now supports function names ([#&#8203;11423](typescript-eslint/typescript-eslint#11423), [#&#8203;11430](typescript-eslint/typescript-eslint#11430))- **eslint-plugin:** \[consistent-type-exports] fix declaration shadowing ([#&#8203;11457](typescript-eslint/typescript-eslint#11457))- **eslint-plugin:** \[no-unnecessary-type-conversion] only report \~\~ on integer literal types ([#&#8203;11517](typescript-eslint/typescript-eslint#11517))- **scope-manager:** exclude Program from DefinitionBase node types ([#&#8203;11469](typescript-eslint/typescript-eslint#11469))- **eslint-plugin:** \[no-non-null-assertion] do not suggest optional chain on LHS of assignment ([#&#8203;11489](typescript-eslint/typescript-eslint#11489))- **type-utils:** add union type support to TypeOrValueSpecifier ([#&#8203;11526](typescript-eslint/typescript-eslint#11526))##### ❤️ Thank You- Dima [@&#8203;dbarabashh](https://github.com/dbarabashh)- Kirk Waiblinger [@&#8203;kirkwaiblinger](https://github.com/kirkwaiblinger)- mdm317- tao- Victor Genaev [@&#8203;mainframev](https://github.com/mainframev)- Yukihiro Hasegawa [@&#8203;y-hsgw](https://github.com/y-hsgw)- 민감자(Minji Kim) [@&#8203;mouse0429](https://github.com/mouse0429)- 송재욱You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)##### 🩹 Fixes- **deps:** update eslint monorepo to v9.33.0 ([#&#8203;11482](typescript-eslint/typescript-eslint#11482))You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)##### 🩹 Fixes- **deps:** update dependency prettier to v3.6.2 ([#&#8203;11496](typescript-eslint/typescript-eslint#11496))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)##### 🚀 Features- **typescript-estree:** forbid invalid keys in `EnumMember` ([#&#8203;11232](typescript-eslint/typescript-eslint#11232))##### ❤️ Thank You- fisker Cheung [@&#8203;fisker](https://github.com/fisker)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details><details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>### [`v8.47.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8470-2025-11-17)[Compare Source](typescript-eslint/typescript-eslint@v8.46.4...v8.47.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.4`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8464-2025-11-10)[Compare Source](typescript-eslint/typescript-eslint@v8.46.3...v8.46.4)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.3`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8463-2025-11-03)[Compare Source](typescript-eslint/typescript-eslint@v8.46.2...v8.46.3)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8462-2025-10-20)[Compare Source](typescript-eslint/typescript-eslint@v8.46.1...v8.46.2)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8461-2025-10-13)[Compare Source](typescript-eslint/typescript-eslint@v8.46.0...v8.46.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.46.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8460-2025-10-06)[Compare Source](typescript-eslint/typescript-eslint@v8.45.0...v8.46.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.45.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8450-2025-09-29)[Compare Source](typescript-eslint/typescript-eslint@v8.44.1...v8.45.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8441-2025-09-22)[Compare Source](typescript-eslint/typescript-eslint@v8.44.0...v8.44.1)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.44.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8440-2025-09-15)[Compare Source](typescript-eslint/typescript-eslint@v8.43.0...v8.44.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8430-2025-09-08)[Compare Source](typescript-eslint/typescript-eslint@v8.42.0...v8.43.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.42.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8420-2025-09-02)[Compare Source](typescript-eslint/typescript-eslint@v8.41.0...v8.42.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.### [`v8.41.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8410-2025-08-25)[Compare Source](typescript-eslint/typescript-eslint@v8.40.0...v8.41.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v8.40.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#8400-2025-08-18)[Compare Source](typescript-eslint/typescript-eslint@v8.39.1...v8.40.0)This was a version bump only for parser to align it with other projects, there were no code changes.You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS44MS4wIiwidXBkYXRlZEluVmVyIjoiNDIuMTAuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->Reviewed-on:https://git.in.csmpro.ru/csmpro/csm-mapban/pulls/20Co-authored-by: Renovate Bot <renovate@csmpro.ru>Co-committed-by: Renovate Bot <renovate@csmpro.ru>
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 19, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 19, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestNov 20, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.46.1 | 8.47.0 || npm        | @typescript-eslint/parser        | 8.46.1 | 8.47.0 |## [v8.47.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8470-2025-11-17)##### 🚀 Features- **eslint-plugin:** \[no-unused-private-class-members] new extension rule ([#10913](typescript-eslint/typescript-eslint#10913))##### ❤️ Thank You- Brad Zacher [@bradzacher](https://github.com/bradzacher)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.4](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8464-2025-11-10)##### 🩹 Fixes- **parser:** error when both `projectService` and `project` are set ([#11333](typescript-eslint/typescript-eslint#11333))- **eslint-plugin:** handle override modifier in promise-function-async fixer ([#11730](typescript-eslint/typescript-eslint#11730))- **eslint-plugin:** \[no-deprecated] fix double-report on computed literal identifiers ([#11006](typescript-eslint/typescript-eslint#11006), [#10958](typescript-eslint/typescript-eslint#10958))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- Kentaro Suzuki [@sushichan044](https://github.com/sushichan044)- Maria Solano [@MariaSolOs](https://github.com/MariaSolOs)You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.3](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8463-2025-11-03)##### 🩹 Fixes- **eslint-plugin:** \[no-duplicate-enum-values] support signed numbers ([#11722](typescript-eslint/typescript-eslint#11722), [#11723](typescript-eslint/typescript-eslint#11723))- **eslint-plugin:** \[no-misused-promises] expand union type to retrieve target property ([#11706](typescript-eslint/typescript-eslint#11706))##### ❤️ Thank You- Evgeny Stepanovych [@undsoft](https://github.com/undsoft)- taoYou can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.## [v8.46.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8462-2025-10-20)##### 🩹 Fixes- **eslint-plugin:** \[prefer-optional-chain] skip optional chaining when it could change the result ([#11702](typescript-eslint/typescript-eslint#11702))##### ❤️ Thank You- mdm317You can read about our [versioning strategy](https://typescript-eslint.io/users/versioning) and [releases](https://typescript-eslint.io/users/releases) on our website.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@ronamironamironami left review comments

@kirkwaiblingerkirkwaiblingerAwaiting requested review from kirkwaiblinger

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancement: new base rule extensionNew base rule extension required to handle a TS specific case

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule proposal: no-unused-private-class-members

5 participants

@bradzacher@kirkwaiblinger@JoshuaKGoldberg@ronami
[8]ページ先頭
©2009-2025 Movatter.jp