Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary#10907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

y-hsgw
Copy link
Contributor

@y-hsgwy-hsgw commentedMar 2, 2025•
edited
Loading

PR Checklist

Overview

Fixed the bug described in the title.

Please note that in addition to the error examples in the#10894, I have also addressed several related cases.

🐛

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedMar 2, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit30b0c4f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/680fe2abddb3b6000887e598
😎 Deploy Previewhttps://deploy-preview-10907--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMar 2, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit30b0c4f.

CommandStatusDurationResult
nx test eslint-plugin-internal✅ Succeeded2sView ↗
nx test rule-tester✅ Succeeded2sView ↗
nx run types:build✅ Succeeded1sView ↗
nx typecheck ast-spec✅ Succeeded2sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded22sView ↗
nx test utils✅ Succeeded2sView ↗
nx run parser:test -- --coverage✅ Succeeded8sView ↗
nx run-many --target=clean✅ Succeeded19sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-04-28 20:37:46 UTC

@codecovCodecov
Copy link

codecovbot commentedMar 2, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base(1200571) to head(30b0c4f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10907   +/-   ##=======================================  Coverage   90.83%   90.83%           =======================================  Files         497      497             Lines       50259    50279   +20       Branches     8291     8297    +6     =======================================+ Hits        45652    45672   +20  Misses       4592     4592             Partials       15       15
FlagCoverage Δ
unittest90.83% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...plugin/src/rules/no-unnecessary-type-parameters.ts97.08% <100.00%> (+0.14%)⬆️
...ackages/eslint-plugin/src/util/getWrappingFixer.ts96.29% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMar 10, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

@JoshuaKGoldbergJoshuaKGoldberg dismissed theirstale reviewMarch 10, 2025 11:45

Wait, was too optimistic - taking a closer look..

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good stuff! I think just a bit of extra testing & code flow trimming are needed now. 🔥

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 10, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMar 10, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMar 17, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 Looks great to me, thanks!

y-hsgw reacted with thumbs up emojiy-hsgw reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 17, 2025
@kirkwaiblingerkirkwaiblinger added awaiting responseIssues waiting for a reply from the OP or another party and removed 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelsMar 19, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMar 20, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMar 31, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 will defer to@kirkwaiblinger, as they caught things I didn't last time. LGTM otherwise!

y-hsgw reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 31, 2025
@kirkwaiblinger
Copy link
Member

Sorry for the delay!

y-hsgw reacted with thumbs up emoji

@kirkwaiblingerkirkwaiblingerenabled auto-merge (squash)April 28, 2025 04:42
@kirkwaiblingerkirkwaiblinger merged commit50ef8d9 intotypescript-eslint:mainApr 28, 2025
55 checks passed
@y-hsgwy-hsgw deleted the fix/no-unnecessary-type-parameters branchApril 28, 2025 23:46
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary
3 participants
@y-hsgw@kirkwaiblinger@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp