typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore: fix integration-tests#10906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromaryaemami59:chore/fix-integration-tests

Mar 2, 2025

Merged

chore: fix integration-tests#10906

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromaryaemami59:chore/fix-integration-tests

Mar 2, 2025

Conversation

Copy link

Contributor

aryaemami59 commentedMar 2, 2025•
edited by kirkwaiblinger
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Fixes failing integration-tests.

Edit by@kirkwaiblinger:

Context - same issue as#10870, sinceDefinitelyTyped/DefinitelyTyped#72026 landed.

Copy link

Contributor

typescript-eslintbot commentedMar 2, 2025

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedMar 2, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`27e6099`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67c3fdac3517430008c45490
😎 Deploy Preview	https://deploy-preview-10906--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 100 (🟢 up 8 from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedMar 2, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3355172.

Command	Status	Duration	Result
`nx test eslint-plugin`	❌ Failed	6m 24s	View ↗
`nx test eslint-plugin --coverage=false`	❌ Failed	6m 21s	View ↗
`nx test visitor-keys`	✅ Succeeded	<1s	View ↗
`nx test type-utils`	✅ Succeeded	<1s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx test utils`	✅ Succeeded	<1s	View ↗
`nx test typescript-estree`	✅ Succeeded	<1s	View ↗
`nx test scope-manager`	✅ Succeeded	<1s	View ↗
`Additional runs (24)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-03-02 06:24:20 UTC

chore: fix integration-tests

27e6099

aryaemami59 force-pushed thechore/fix-integration-tests branch from3355172 to27e6099Compare

March 2, 2025 06:41

Copy link

codecovbot commentedMar 2, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base(4dd447c) to head(27e6099).
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10906   +/-   ##=======================================  Coverage   87.43%   87.43%           =======================================  Files         468      468             Lines       16027    16040   +13       Branches     4640     4649    +9     =======================================+ Hits        14013    14025   +12  Misses       1658     1658- Partials      356      357    +1