Mar 3, 2025 · Feb 28, 2025 · Feb 28, 2025 · Mar 2, 2025 · Mar 2, 2025 · Mar 2, 2025
diff --git a/package.json b/package.json
    "semver": "7.7.0",
    "tmp": "^0.2.1",
    "tsx": "*",
    "typescript": ">=4.8.4 <5.8.0",
    "typescript": ">=4.8.4 <5.9.0",
    "typescript-eslint": "workspace:^",
    "yargs": "17.7.2"
  },
    "react-split-pane@^0.1.92": "patch:react-split-pane@npm%3A0.1.92#./.yarn/patches/react-split-pane-npm-0.1.92-93dbf51dff.patch",
    "tmp": "0.2.1",
    "tsx": "^4.7.2",
    "typescript": "5.7.2"
    "typescript": "5.8.2"
  },
  "packageManager": "yarn@3.8.2",
  "nx": {
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
  "peerDependencies": {
    "@typescript-eslint/parser": "^8.0.0 || ^8.0.0-alpha.0",
    "eslint": "^8.57.0 || ^9.0.0",
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "funding": {
    "type": "opencollective",
diff --git a/packages/parser/package.json b/packages/parser/package.json
  },
  "peerDependencies": {
    "eslint": "^8.57.0 || ^9.0.0",
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "dependencies": {
    "@typescript-eslint/scope-manager": "8.25.0",
diff --git a/packages/scope-manager/src/lib/dom.iterable.ts b/packages/scope-manager/src/lib/dom.iterable.ts
diff --git a/packages/scope-manager/src/lib/dom.ts b/packages/scope-manager/src/lib/dom.ts
diff --git a/packages/scope-manager/src/lib/esnext.float16.ts b/packages/scope-manager/src/lib/esnext.float16.ts
diff --git a/packages/scope-manager/src/lib/esnext.promise.ts b/packages/scope-manager/src/lib/esnext.promise.ts
diff --git a/packages/scope-manager/src/lib/esnext.ts b/packages/scope-manager/src/lib/esnext.ts
diff --git a/packages/scope-manager/src/lib/index.ts b/packages/scope-manager/src/lib/index.ts
diff --git a/packages/scope-manager/src/lib/webworker.iterable.ts b/packages/scope-manager/src/lib/webworker.iterable.ts
diff --git a/packages/scope-manager/src/lib/webworker.ts b/packages/scope-manager/src/lib/webworker.ts
diff --git a/packages/type-utils/package.json b/packages/type-utils/package.json
  },
  "peerDependencies": {
    "eslint": "^8.57.0 || ^9.0.0",
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "devDependencies": {
    "@jest/types": "29.6.3",
diff --git a/packages/types/src/lib.ts b/packages/types/src/lib.ts
  | 'esnext.collection'
  | 'esnext.decorators'
  | 'esnext.disposable'
  | 'esnext.float16'
  | 'esnext.full'
  | 'esnext.intl'
  | 'esnext.iterator'
diff --git a/packages/typescript-eslint/package.json b/packages/typescript-eslint/package.json
  },
  "peerDependencies": {
    "eslint": "^8.57.0 || ^9.0.0",
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "devDependencies": {
    "@jest/types": "29.6.3",
diff --git a/packages/typescript-estree/package.json b/packages/typescript-estree/package.json
    "typescript": "*"
  },
  "peerDependencies": {
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "funding": {
    "type": "opencollective",
diff --git a/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts b/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts
 /**
 * This needs to be kept in sync with package.json in the typescript-eslint monorepo
 */
 export const SUPPORTED_TYPESCRIPT_VERSIONS = '>=4.8.4 <5.8.0';
 export const SUPPORTED_TYPESCRIPT_VERSIONS = '>=4.8.4 <5.9.0';

 /*
 * The semver package will ignore prerelease ranges, and we don't want to explicitly document every one
diff --git a/packages/utils/package.json b/packages/utils/package.json
  },
  "peerDependencies": {
    "eslint": "^8.57.0 || ^9.0.0",
    "typescript": ">=4.8.4 <5.8.0"
    "typescript": ">=4.8.4 <5.9.0"
  },
  "devDependencies": {
    "downlevel-dts": "*",
diff --git a/tools/release/release.mts b/tools/release/release.mts
 import { execaSync } from 'execa';
 import { releaseChangelog, releasePublish, releaseVersion } from 'nx/release';
 import {
  releaseChangelog,
  releasePublish,
  releaseVersion,
 } from 'nx/release/index.js';
 import yargs from 'yargs';

 const options = await yargs(process.argv.slice(2))
Original file line number	Diff line number	Diff line change
Expand Up		@@ -122,7 +122,7 @@
		"semver": "7.7.0",
		"tmp": "^0.2.1",
		"tsx": "*",
		"typescript": ">=4.8.4 <5.8.0",
		"typescript": ">=4.8.4 <5.9.0",
		"typescript-eslint": "workspace:^",
		"yargs": "17.7.2"
		},
Expand All		@@ -145,7 +145,7 @@
		"react-split-pane@^0.1.92": "patch:react-split-pane@npm%3A0.1.92#./.yarn/patches/react-split-pane-npm-0.1.92-93dbf51dff.patch",
		"tmp": "0.2.1",
		"tsx": "^4.7.2",
		"typescript": "5.7.2"
		"typescript": "5.8.2"
		},
		"packageManager": "yarn@3.8.2",
		"nx": {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -100,7 +100,7 @@
		"peerDependencies": {
		"@typescript-eslint/parser": "^8.0.0 \|\| ^8.0.0-alpha.0",
		"eslint": "^8.57.0 \|\| ^9.0.0",
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"funding": {
		"type": "opencollective",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -51,7 +51,7 @@
		},
		"peerDependencies": {
		"eslint": "^8.57.0 \|\| ^9.0.0",
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"dependencies": {
		"@typescript-eslint/scope-manager": "8.25.0",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -54,7 +54,7 @@
		},
		"peerDependencies": {
		"eslint": "^8.57.0 \|\| ^9.0.0",
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"devDependencies": {
		"@jest/types": "29.6.3",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -94,6 +94,7 @@ export type Lib =
		\| 'esnext.collection'
		\| 'esnext.decorators'
		\| 'esnext.disposable'
		\| 'esnext.float16'
		\| 'esnext.full'
		\| 'esnext.intl'
		\| 'esnext.iterator'
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -59,7 +59,7 @@
		},
		"peerDependencies": {
		"eslint": "^8.57.0 \|\| ^9.0.0",
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"devDependencies": {
		"@jest/types": "29.6.3",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -74,7 +74,7 @@
		"typescript": "*"
		},
		"peerDependencies": {
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"funding": {
		"type": "opencollective",
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,7 +8,7 @@ import { version as TYPESCRIPT_ESTREE_VERSION } from '../version';
		/**
		* This needs to be kept in sync with package.json in the typescript-eslint monorepo
		*/
		export const SUPPORTED_TYPESCRIPT_VERSIONS = '>=4.8.4 <5.8.0';
		export const SUPPORTED_TYPESCRIPT_VERSIONS = '>=4.8.4 <5.9.0';

		/*
		* The semver package will ignore prerelease ranges, and we don't want to explicitly document every one
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -71,7 +71,7 @@
		},
		"peerDependencies": {
		"eslint": "^8.57.0 \|\| ^9.0.0",
		"typescript": ">=4.8.4 <5.8.0"
		"typescript": ">=4.8.4 <5.9.0"
		},
		"devDependencies": {
		"downlevel-dts": "*",
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,9 @@
		import { execaSync } from 'execa';
		import { releaseChangelog, releasePublish, releaseVersion } from 'nx/release';
		import {
		releaseChangelog,
		releasePublish,
		releaseVersion,
		} from 'nx/release/index.js';
Copy link Member JoshuaKGoldbergMar 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Unrelated change, is there a reason to include it here? This showed up in other places -at least#10887, cc @kirkwaiblinger- so maybe we need to do this in`main`? bradzacher reacted with thumbs up emoji Copy link ContributorAuthor dirkluijkMar 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yeah, see#10903 (comment) My theory is - but I haven't checked it yet - that TypeScript 5.8 behaves slightly different with deep imports in CommonJS modules that don't have specific secondary entry points. On TS 5.7 this is not an issue, so I think it belongs to this PR. Although we could also add this to`main` first of course. kirkwaiblinger reacted with thumbs up emoji Copy link Member kirkwaiblingerMar 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We had a poke around, and the change is due tomicrosoft/TypeScript#61057. TL;DR you can't omit the`/index.js` when`import`ing from ESM in node. Seemingly executing with tsx rather than node has been preventing this from being a runtime error for us so far, but the TS 5.8 error is correct, and, accordingly, so is this change. 👍 Also@JamesHenry is aware and might tweak things on the`nx` side (whether justthe docs or adding a subpath`exports` field) Copy link Member kirkwaiblingerMar 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. As for plan of action - both#10887 and this PR genuinely need this change for different reasons (TS type-checking error here, and runtime error when using node 23.6, which#10887 resolves), so I'd say let's just keep the change in both PRs and whichever is merged first is merged first 🤷‍♂️ dirkluijk and bradzacher reacted with thumbs up emoji
		import yargs from 'yargs';

		const options = await yargs(process.argv.slice(2))
Expand Down