Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: drop tsx for node strip-types#10888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
43081j wants to merge3 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
from43081j:nodets-types-strip

Conversation

43081j
Copy link
Contributor

This switches fromtsx to--experimental-strip-types

DRAFT UNTIL FURTHER NOTICE

It is here to make sure people don't open duplicate PRs, but we can't land it yet since it requires too late a version of node.

Our CI is still using old enough node that this flag doesn't exist (plus it is "experimental" after all).

PR Checklist

Removes a couple of unused/broken scripts from`rule-schema-to-typescript-types`.Also adds a missing nx target such that `generate-breaking-changes`works again.
This switches various repo scripts to be `*.mts` files (since that iswhat they actually are, given we don't build them into CJS output, yetour package `type` is `"commonjs"`).This will allow newer Node to execute them correctly, as they will nowinfer the correct module type.The `generate-lib` script has also been changed to use only strippabletypes (i.e. no enums).Both of these changes mean we have the option to drop `tsx` in futureand use `--experimental-strip-types` (when it is no longerexperimental).
Drops `tsx` and uses `--experimental-strip-types` to directly executethe various typescript scripts we have.We likely don't want to land this until it is no longer "experimental".
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@43081j43081j changed the titleNodets types stripchore: drop tsx for node strip-typesFeb 25, 2025
@netlifyNetlify
Copy link

netlifybot commentedFeb 25, 2025
edited
Loading

Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commitc149688
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67bdf810ade8320008fa1fa1

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 25, 2025
edited
Loading

View yourCI Pipeline Execution ↗ for commitc149688.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-02-25 17:05:34 UTC

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: execute typescript scripts/tools with node directly
1 participant
@43081j

[8]ページ先頭

©2009-2025 Movatter.jp