Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: drop tsx for node strip-types#10888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Removes a couple of unused/broken scripts from`rule-schema-to-typescript-types`.Also adds a missing nx target such that `generate-breaking-changes`works again.
This switches various repo scripts to be `*.mts` files (since that iswhat they actually are, given we don't build them into CJS output, yetour package `type` is `"commonjs"`).This will allow newer Node to execute them correctly, as they will nowinfer the correct module type.The `generate-lib` script has also been changed to use only strippabletypes (i.e. no enums).Both of these changes mean we have the option to drop `tsx` in futureand use `--experimental-strip-types` (when it is no longerexperimental).
Drops `tsx` and uses `--experimental-strip-types` to directly executethe various typescript scripts we have.We likely don't want to land this until it is no longer "experimental".
Thanks for the PR,@43081j! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedFeb 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
❌ Deploy Preview fortypescript-eslint failed.
|
nx-cloudbot commentedFeb 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commitc149688.
☁️Nx Cloud last updated this comment at |
This switches from
tsx
to--experimental-strip-types
DRAFT UNTIL FURTHER NOTICE
It is here to make sure people don't open duplicate PRs, but we can't land it yet since it requires too late a version of node.
Our CI is still using old enough node that this flag doesn't exist (plus it is "experimental" after all).
PR Checklist