typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [no-unsafe-return] handle recursive type#10883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fixes/10868

Mar 10, 2025

Merged

fix(eslint-plugin): [no-unsafe-return] handle recursive type#10883

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fixes/10868

Mar 10, 2025

Conversation

Copy link

Contributor

yeonjuan commentedFeb 25, 2025

PR Checklist

Addresses an existing open issue:fixesBug: [no-unsafe-return] Infinite recursion with thenable this return type #10868
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(eslint-plugin): [no-unsafe-return] handle recursive type

4959ad5

Copy link

Contributor

typescript-eslintbot commentedFeb 25, 2025

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 25, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f257658`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67c70bc411ca4b0008db7069
😎 Deploy Preview	https://deploy-preview-10883--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 89 (🔴 down 9 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 25, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf257658.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	4s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-03-05 12:22:15 UTC

Copy link

codecovbot commentedFeb 25, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base(fb790dc) to head(f257658).
Report is 52 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10883      +/-   ##==========================================+ Coverage   87.30%   87.58%   +0.27%==========================================  Files         450      470      +20       Lines       15768    16095     +327       Branches     4617     4667      +50     ==========================================+ Hits        13767    14097     +330+ Misses       1645     1642       -3  Partials      356      356

Flag	Coverage Δ
unittest	`87.58% <100.00%> (+0.27%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/type-utils/src/discriminateAnyType.ts	`100.00% <100.00%> (ø)`
packages/type-utils/src/predicates.ts	`30.76% <ø> (+9.55%)`	⬆️

... and41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yeonjuan marked this pull request as ready for review

March 4, 2025 14:12

yeonjuan added2 commits

March 4, 2025 23:15

add tests

24db443

Update discriminateAnyType.test.ts

f257658

JoshuaKGoldberg approved these changes

Mar 5, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome! +1 on the moving out of the 'predicates' file and further +1 on the extra unit test coverage. 🔥 Thanks!

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Mar 5, 2025

Copy link

Member

JoshuaKGoldberg commentedMar 10, 2025

Merging a couple days sooner than our normal 1 week waiting period to get it into the weekly release today. ⚡

JoshuaKGoldberg merged commitee90e45 intotypescript-eslint:main

Mar 10, 2025

90 of 93 checks passed

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Mar 11, 2025