typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

chore: fix failing integration tests on the`main` branch#10870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromronami:fix-main-branch-failing

Feb 24, 2025

Merged

chore: fix failing integration tests on the`main` branch#10870

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromronami:fix-main-branch-failing

Feb 24, 2025

Conversation

Copy link

Member

ronami commentedFeb 22, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue: fixes #000
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Themain branch's integration tests are failing consistently. I think this is related to a recent release of@types/eslint__js.

The package itself seems to be deprecated and isn't necessary anymore, see:

I'm not sure why exactly, but it seems that the version currently released for@types/eslint__js as thelatest tag has noindex.d.ts file. I think this is causing the integration tests (that check that types are valid) to fail with:Cannot find type definition file for 'eslint__js'. (even if the file checked is empty).

Installing thelatest version of@types/eslint__js and type checking an empty file seems to error on the above.

Should I open an issue about this? Having an emptyindex.d.ts can help in cases it's accidentally installed (unless this is intended since it's now deprecated).

ronami added2 commits

February 23, 2025 00:17

fix failing integration tests on main branch

fe75258

missed one

dbbe697

Copy link

netlifybot commentedFeb 22, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`9d8e69e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67ba55d73a3bea00080126e0
😎 Deploy Preview	https://deploy-preview-10870--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 79 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

ronami changed the title~~chore(tests): fix failing integration tests on themain branch~~chore(test): fix failing integration tests on themain branch

Feb 22, 2025

Copy link

nx-cloudbot commentedFeb 22, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit9d8e69e.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-02-22 23:03:14 UTC

Copy link

Contributor

typescript-eslintbot commentedFeb 22, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

ronami changed the title~~chore(test): fix failing integration tests on themain branch~~test(integration-tests): fix failing integration tests on themain branch

Feb 22, 2025

set @types/eslint__js to 8 on eslint-v8 tests

86ac7db

ronami changed the title~~test(integration-tests): fix failing integration tests on themain branch~~chore: fix failing integration tests on themain branch

Feb 22, 2025

ronami marked this pull request as ready for review

February 22, 2025 22:47