Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] support computed member access#10867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

azat-io
Copy link
Contributor

PR Checklist

Overview

The rule now correctly detects deprecated properties when they are accessed using computed member expressions (obj['prop']), variables (const x = 'prop'; obj[x]).

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@azat-io!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 22, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3507f62
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6821d8bea0011300087e47e9
😎 Deploy Previewhttps://deploy-preview-10867--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 87 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 22, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3507f62.

CommandStatusDurationResult
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 24sView ↗
nx test eslint-plugin✅ Succeeded6m 2sView ↗
nx test eslint-plugin-internal✅ Succeeded2sView ↗
nx run types:build✅ Succeeded1sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded5m 1sView ↗
nx typecheck ast-spec✅ Succeeded2sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded6sView ↗
nx test utils✅ Succeeded3sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-12 11:29:33 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 22, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(a89d5e3) to head(3507f62).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10867   +/-   ##=======================================  Coverage   90.91%   90.92%           =======================================  Files         499      499             Lines       50808    50841   +33       Branches     8369     8380   +11     =======================================+ Hits        46194    46227   +33  Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.92% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.96% <100.00%> (+0.33%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@azat-ioazat-ioforce-pushed thefix/no-deprecated-objects branch fromca1fc1f toc715c75CompareFebruary 24, 2025 20:41
@azat-io
Copy link
ContributorAuthor

Rebased.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for getting this started! Codecov is surfacing that several logical branches aren't covered by tests - could you please test them?

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 2, 2025
@azat-ioazat-ioforce-pushed thefix/no-deprecated-objects branch 2 times, most recently fromfebc81f to2bc22e8CompareMarch 2, 2025 12:27
@JoshuaKGoldberg
Copy link
Member

👋 Just checking in@azat-io, do you still have time for this?

@JoshuaKGoldbergJoshuaKGoldberg added the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelApr 7, 2025
@azat-io
Copy link
ContributorAuthor

Yes, sorry for the delay, I'll be back at the end of the week.

JoshuaKGoldberg reacted with heart emoji

@azat-ioazat-ioforce-pushed thefix/no-deprecated-objects branch 4 times, most recently from05a7916 tof19bc3fCompareApril 20, 2025 15:28
@JoshuaKGoldbergJoshuaKGoldberg removed the stalePRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period labelApr 21, 2025
@azat-io
Copy link
ContributorAuthor

Any feedback?

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commentedMay 5, 2025•
edited
Loading

Oh I didn't realize this was ready for re-review! We normally wait until the actualRe-Request Review button is pressed. But great, looking now!

@JoshuaKGoldbergJoshuaKGoldberg self-requested a reviewMay 5, 2025 15:45
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMay 5, 2025
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMay 5, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

Just a couple of small notes, nothing we can't apply before merging. Only the removal ofisStringLiteral() is something I think we really need.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMay 5, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit523b3ea intotypescript-eslint:mainMay 12, 2025
56 of 57 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestMay 17, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.31.0 | 8.32.1 || npm        | @typescript-eslint/parser        | 8.31.0 | 8.32.1 |## [v8.32.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8321-2025-05-12)##### 🩹 Fixes-   **eslint-plugin:** \[consistent-indexed-object-style] check for indirect circular types in aliased mapped types ([#11177](typescript-eslint/typescript-eslint#11177))-   **eslint-plugin:** \[consistent-indexed-object-style] adjust auto-fixer to generate valid syntax for `TSMappedType` with no type annotation ([#11180](typescript-eslint/typescript-eslint#11180))-   **eslint-plugin:** \[no-deprecated] support computed member access ([#10867](typescript-eslint/typescript-eslint#10867))-   **eslint-plugin:** \[no-unnecessary-type-conversion] shouldn't have fixable property ([#11194](typescript-eslint/typescript-eslint#11194))##### ❤️ Thank You-   Azat S. [@azat-io](https://github.com/azat-io)-   Dima Barabash [@dbarabashh](https://github.com/dbarabashh)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.32.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8320-2025-05-05)##### 🚀 Features-   **eslint-plugin:** \[only-throw-error] add option `allowRethrowing` ([#11075](typescript-eslint/typescript-eslint#11075))-   **eslint-plugin:** \[no-unnecessary-type-conversion] add rule ([#10182](typescript-eslint/typescript-eslint#10182))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] fix parenthesization bug in suggestion ([#11098](typescript-eslint/typescript-eslint#11098))-   **eslint-plugin:** \[unified-signatures] exempt `this` from optional parameter overload check ([#11005](typescript-eslint/typescript-eslint#11005))-   **eslint-plugin:** \[no-unnecessary-type-parameters] should parenthesize type in suggestion fixer if necessary ([#10907](typescript-eslint/typescript-eslint#10907))##### ❤️ Thank You-   Andy Edwards-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   Sasha Kondrashov-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.31.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8311-2025-04-28)##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] downgrade fix to suggestion ([#11081](typescript-eslint/typescript-eslint#11081))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMay 20, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] doesn't report deprecated type index access
2 participants
@azat-io@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp