Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [prefer-nullish-coalescing] supportif statement assignment (??=) and fix several minor bugs#10861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

OlivierZal
Copy link
Contributor

@OlivierZalOlivierZal commentedFeb 21, 2025•
edited
Loading

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 21, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit513b085
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67e02a4849254e0008c6f2ef
😎 Deploy Previewhttps://deploy-preview-10861--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@OlivierZalOlivierZal marked this pull request as draftFebruary 21, 2025 09:19
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 21, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit513b085.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded1sView ↗
nx run-many --target=clean✅ Succeeded11sView ↗

☁️Nx Cloud last updated this comment at2025-03-24 13:01:58 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 21, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base(8474474) to head(513b085).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10861      +/-   ##==========================================+ Coverage   87.97%   88.00%   +0.03%==========================================  Files         470      470                Lines       16709    16763      +54       Branches     4710     4735      +25     ==========================================+ Hits        14699    14753      +54  Misses       1664     1664                Partials      346      346
FlagCoverage Δ
unittest88.00% <100.00%> (+0.03%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...eslint-plugin/src/rules/consistent-type-exports.ts88.78% <100.00%> (-0.21%)⬇️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts97.18% <100.00%> (-0.04%)⬇️
...lint-plugin/src/rules/prefer-nullish-coalescing.ts96.68% <100.00%> (+1.02%)⬆️
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch 3 times, most recently from25f4ea7 to46330a5CompareFebruary 22, 2025 22:49
@OlivierZalOlivierZal marked this pull request as ready for reviewFebruary 22, 2025 22:51
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from505fd3e to1299a38CompareFebruary 23, 2025 22:13
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch 2 times, most recently from144036b to1299a38CompareFebruary 24, 2025 18:21
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from1299a38 tofcc9beaCompareFebruary 24, 2025 18:24
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from46cbf12 to849bf03CompareFebruary 25, 2025 17:53
@OlivierZalOlivierZal marked this pull request as draftFebruary 25, 2025 17:56
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from4a72913 to60091c8CompareFebruary 25, 2025 18:10
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from96c95a8 to16150a2CompareFebruary 25, 2025 22:38
@OlivierZalOlivierZal marked this pull request as ready for reviewFebruary 25, 2025 22:40
@OlivierZal
Copy link
ContributorAuthor

OlivierZal commentedFeb 25, 2025•
edited
Loading

Ready for review:new feature in the playground

While moving / refactoring thenodesInsideTestNode loop, and adding tests:

In the playground:

❌main branch playground

✅PR branch playground

Cc@kirkwaiblinger

kirkwaiblinger reacted with heart emoji

@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10829 branch from24210d9 tof69b588CompareFebruary 26, 2025 09:43
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it looks good enough for me! IMO we're just going for a best effort on comment placement.

Thanks!

OlivierZal reacted with heart emoji
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 22, 2025
@OlivierZal
Copy link
ContributorAuthor

OlivierZal commentedMar 23, 2025•
edited
Loading

@JoshuaKGoldberg, the latest commit doesn't seem related to PR's failure (which was ok one commit before).

Mergingmain didn’t help.

@JoshuaKGoldberg
Copy link
Member

Yeah 😬#10992 - we can ignore those failures.

OlivierZal and kirkwaiblinger reacted with thumbs up emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I regret not thinking more on comments earlier, thanks Kirk for the catch. After playing around with a bunch more cases there are only a couple more comment locations I could break. Getting there! 🚀

@JoshuaKGoldbergJoshuaKGoldberg added awaiting responseIssues waiting for a reply from the OP or another party and removed 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelsMar 24, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelMar 24, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Super, thanks the thorough PR & discussion! 🔥

kirkwaiblinger reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit7151489 intotypescript-eslint:mainMar 24, 2025
58 of 60 checks passed
@DarkDrek
Copy link

Hi is there an option to disable this only for assignments and keep the general lint for the other types?

@kirkwaiblinger
Copy link
Member

@DarkDrek see conversation at#10995

@typescript-eslinttypescript-eslint locked and limited conversation to collaboratorsMar 26, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [prefer-nullish-coalescing] should supportif statement assignment (??=)
4 participants
@OlivierZal@JoshuaKGoldberg@DarkDrek@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp