Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-eslint): export util types (close #10848)#10849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromMister-Hope:main
Oct 6, 2025

Conversation

Mister-Hope
Copy link
Contributor

@Mister-HopeMister-Hope commentedFeb 19, 2025•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

This adds export for a namespaceTSLint which contain types used in tslint.

The main reason is that as the documentation suggests using tslint stricter types:https://typescript-eslint.io/getting-started#step-2-configuration, people may need to implicitly mark codes to these types in their own flag config, as auto-infer may contain "loose types" (e.g.:string instead of'a' | 'b') that triggers ts errors.

For examples,see#10848

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Mister-Hope!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 19, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit232f260
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/68da94db61c7f40008b93e97
😎 Deploy Previewhttps://deploy-preview-10849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 19, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit232f260

CommandStatusDurationResult
nx run-many -t lint✅ Succeeded3m 22sView ↗
nx run-many -t typecheck✅ Succeeded1m 58sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded14sView ↗
nx run generate-configs✅ Succeeded7sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded13sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded4sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
Additional runs (27)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-09-29 14:24:08 UTC

@JoshuaKGoldberg
Copy link
Member

Switching this PR to draft pending issue triage.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as draftFebruary 19, 2025 12:18
@kirkwaiblinger
Copy link
Member

Noting that this issue is now accepting PRs, so we can unblock this PR.

(thanks to@ntdiary for bringing this to our attention in#10893 (comment))

ntdiary reacted with rocket emoji

@codecovCodecov
Copy link

codecovbot commentedSep 29, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (9530e02) to head (232f260).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10849   +/-   ##=======================================  Coverage   90.93%   90.93%           =======================================  Files         506      506             Lines       51394    51394             Branches     8482     8482           =======================================  Hits        46735    46735             Misses       4646     4646             Partials       13       13
FlagCoverage Δ
unittest90.93% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewSeptember 29, 2025 15:00
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great, thanks!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 3, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commit5c1a159 intotypescript-eslint:mainOct 6, 2025
61 of 63 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: export types in typescript-eslint package
3 participants
@Mister-Hope@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp