Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(eslint-plugin): [no-unnecessary-type-assertion] add missing tests for asserting enums#10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ronami
Copy link
Member

PR Checklist

Overview

This PR follows up on the discussion in#7652 (comment) and adds the relevant missing tests. This is a bit different than what the issue describes, as the issue seems to have been resolved in#8558.

I'll add that there are some inconsistencies with how the rule treats literals (enums included), I wrote some thoughts about this in#10631.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@ronamironami changed the titletest(eslint-plugin): [no-unnecessary-type-assertion] add missing enum test fortest(eslint-plugin): [no-unnecessary-type-assertion] add missing tests for asserting enumsFeb 6, 2025
@netlifyNetlify
Copy link

netlifybot commentedFeb 6, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6320bb3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67a4dd38d255dd0008827a08
😎 Deploy Previewhttps://deploy-preview-10807--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 6, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit6320bb3.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded2sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-02-13 20:07:44 UTC

@ronamironami marked this pull request as ready for reviewFebruary 6, 2025 16:44
@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelFeb 13, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Angry umpire yelling 'Safe!' and gesturing it

ronami reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commit28f95cd intotypescript-eslint:mainFeb 15, 2025
67 checks passed
@ronamironami deleted the no-unnecessary-type-assertion-add-enum-test branchFebruary 15, 2025 22:19
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-assertion] Does not work with enums
3 participants
@ronami@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp