Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [explicit-member-accessibility] checkaccessor class properties for missing accessibility modifier#10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,8 +196,10 @@ export default createRule<Options, MessageIds>({
*/
function findPublicKeyword(
node:
| TSESTree.AccessorProperty
| TSESTree.MethodDefinition
| TSESTree.PropertyDefinition
| TSESTree.TSAbstractAccessorProperty
| TSESTree.TSAbstractMethodDefinition
| TSESTree.TSAbstractPropertyDefinition
| TSESTree.TSParameterProperty,
Expand DownExpand Up@@ -238,8 +240,10 @@ export default createRule<Options, MessageIds>({
*/
function getMissingAccessibilitySuggestions(
node:
| TSESTree.AccessorProperty
| TSESTree.MethodDefinition
| TSESTree.PropertyDefinition
| TSESTree.TSAbstractAccessorProperty
| TSESTree.TSAbstractMethodDefinition
| TSESTree.TSAbstractPropertyDefinition
| TSESTree.TSParameterProperty,
Expand DownExpand Up@@ -284,7 +288,9 @@ export default createRule<Options, MessageIds>({
*/
function checkPropertyAccessibilityModifier(
propertyDefinition:
| TSESTree.AccessorProperty
| TSESTree.PropertyDefinition
| TSESTree.TSAbstractAccessorProperty
| TSESTree.TSAbstractPropertyDefinition,
): void {
if (propertyDefinition.key.type === AST_NODE_TYPES.PrivateIdentifier) {
Expand DownExpand Up@@ -389,7 +395,7 @@ export default createRule<Options, MessageIds>({
return {
'MethodDefinition, TSAbstractMethodDefinition':
checkMethodAccessibilityModifier,
'PropertyDefinition, TSAbstractPropertyDefinition':
'PropertyDefinition, TSAbstractPropertyDefinition, AccessorProperty, TSAbstractAccessorProperty':
checkPropertyAccessibilityModifier,
TSParameterProperty: checkParameterPropertyAccessibilityModifier,
};
Expand Down
2 changes: 2 additions & 0 deletionspackages/eslint-plugin/src/util/getMemberHeadLoc.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,8 +30,10 @@ import {
export function getMemberHeadLoc(
sourceCode: Readonly<TSESLint.SourceCode>,
node:
| TSESTree.AccessorProperty
| TSESTree.MethodDefinition
| TSESTree.PropertyDefinition
| TSESTree.TSAbstractAccessorProperty
| TSESTree.TSAbstractMethodDefinition
| TSESTree.TSAbstractPropertyDefinition,
): TSESTree.SourceLocation {
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -308,7 +308,6 @@ class Test {
`,
options: [{ accessibility: 'no-public' }],
},
// private members
{
code: `
class Test {
Expand All@@ -318,6 +317,20 @@ class Test {
`,
options: [{ accessibility: 'explicit' }],
},
{
code: `
class Test {
private accessor foo = 1;
}
`,
},
{
code: `
abstract class Test {
private abstract accessor foo: number;
}
`,
},
],
invalid: [
{
Expand DownExpand Up@@ -1919,6 +1932,98 @@ abstract class SomeClass {
},
{
code: `
class SomeClass {
accessor foo = 1;
}
`,
errors: [
{
column: 3,
endColumn: 15,
endLine: 3,
line: 3,
messageId: 'missingAccessibility',
suggestions: [
{
data: { type: 'public' },
messageId: 'addExplicitAccessibility',
output: `
class SomeClass {
public accessor foo = 1;
}
`,
},
{
data: { type: 'private' },
messageId: 'addExplicitAccessibility',
output: `
class SomeClass {
private accessor foo = 1;
}
`,
},
{
data: { type: 'protected' },
messageId: 'addExplicitAccessibility',
output: `
class SomeClass {
protected accessor foo = 1;
}
`,
},
],
},
],
options: [{ accessibility: 'explicit' }],
},
{
code: `
abstract class SomeClass {
abstract accessor foo: string;
}
`,
errors: [
{
column: 3,
endColumn: 24,
endLine: 3,
line: 3,
messageId: 'missingAccessibility',
suggestions: [
{
data: { type: 'public' },
messageId: 'addExplicitAccessibility',
output: `
abstract class SomeClass {
public abstract accessor foo: string;
}
`,
},
{
data: { type: 'private' },
messageId: 'addExplicitAccessibility',
output: `
abstract class SomeClass {
private abstract accessor foo: string;
}
`,
},
{
data: { type: 'protected' },
messageId: 'addExplicitAccessibility',
output: `
abstract class SomeClass {
protected abstract accessor foo: string;
}
`,
},
],
},
],
options: [{ accessibility: 'explicit' }],
},
{
code: `
class DecoratedClass {
constructor(@foo @bar() readonly arg: string) {}
@foo @bar() x: string;
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp