Feb 17, 2025 · Feb 4, 2025 · Feb 6, 2025 · Feb 6, 2025 · Feb 17, 2025 · Feb 17, 2025
diff --git a/packages/eslint-plugin/docs/rules/class-methods-use-this.mdx b/packages/eslint-plugin/docs/rules/class-methods-use-this.mdx
 >
 > See **https://typescript-eslint.io/rules/class-methods-use-this** for documentation.

 It adds support for ignoring `override` methods and/or methods on classes that implement an interface.
 It adds support for ignoring `override` methods and/or methods on classes that implement an interface. It also supports auto-accessor properties.

 ## Options

diff --git a/packages/eslint-plugin/src/rules/class-methods-use-this.ts b/packages/eslint-plugin/src/rules/class-methods-use-this.ts
        }
      | {
          class: TSESTree.ClassDeclaration | TSESTree.ClassExpression;
          member: TSESTree.MethodDefinition | TSESTree.PropertyDefinition;
          member:
            | TSESTree.AccessorProperty
            | TSESTree.MethodDefinition
            | TSESTree.PropertyDefinition;
          parent: Stack | undefined;
          usesThis: boolean;
        };
    let stack: Stack | undefined;

    function pushContext(
      member?: TSESTree.MethodDefinition | TSESTree.PropertyDefinition,
      member?:
        | TSESTree.AccessorProperty
        | TSESTree.MethodDefinition
        | TSESTree.PropertyDefinition,
    ): void {
      if (member?.parent.type === AST_NODE_TYPES.ClassBody) {
        stack = {
    ): void {
      if (
        node.parent.type === AST_NODE_TYPES.MethodDefinition ||
        node.parent.type === AST_NODE_TYPES.PropertyDefinition
        node.parent.type === AST_NODE_TYPES.PropertyDefinition ||
        node.parent.type === AST_NODE_TYPES.AccessorProperty
      ) {
        pushContext(node.parent);
      } else {
        node.static ||
        (node.type === AST_NODE_TYPES.MethodDefinition &&
          node.kind === 'constructor') ||
        (node.type === AST_NODE_TYPES.PropertyDefinition &&
        ((node.type === AST_NODE_TYPES.PropertyDefinition ||
          node.type === AST_NODE_TYPES.AccessorProperty) &&
          !enforceForClassFields)
      ) {
        return false;
      },
      ...(enforceForClassFields
        ? {
            'AccessorProperty > ArrowFunctionExpression.value'(
              node: TSESTree.ArrowFunctionExpression,
            ): void {
              enterFunction(node);
            },
            'AccessorProperty > ArrowFunctionExpression.value:exit'(
              node: TSESTree.ArrowFunctionExpression,
            ): void {
              exitFunction(node);
            },
            'PropertyDefinition > ArrowFunctionExpression.value'(
              node: TSESTree.ArrowFunctionExpression,
            ): void {
      /*
       * Class field value are implicit functions.
       */
      'AccessorProperty:exit'(): void {
        popContext();
      },
      'AccessorProperty > *.key:exit'(): void {
        pushContext();
      },
      'PropertyDefinition:exit'(): void {
        popContext();
      },
diff --git a/packages/eslint-plugin/tests/rules/class-methods-use-this/class-methods-use-this.test.ts b/packages/eslint-plugin/tests/rules/class-methods-use-this/class-methods-use-this.test.ts
    },
    {
      code: `
 class Foo {
  accessor method = () => {};
 }
      `,
      errors: [
        {
          messageId: 'missingThis',
        },
      ],
      options: [{}],
    },
    {
      code: `
 class Foo {
  private accessor method = () => {};
 }
      `,
      errors: [
        {
          messageId: 'missingThis',
        },
      ],
      options: [{}],
    },
    {
      code: `
 class Foo {
  protected accessor method = () => {};
 }
      `,
      errors: [
        {
          messageId: 'missingThis',
        },
      ],
      options: [{}],
    },
    {
      code: `
 class Foo {
  #method() {}
 }
    },
    {
      code: `
 class Foo implements Bar {
  accessor method = () => {};
 }
      `,
      options: [{ ignoreClassesThatImplementAnInterface: true }],
    },
    {
      code: `
 class Foo implements Bar {
  get getter() {}
 }
    },
    {
      code: `
 class Foo {
  override accessor method = () => {};
 }
      `,
      options: [{ ignoreOverrideMethods: true }],
    },
    {
      code: `
 class Foo {
  override get getter(): number {}
 }
        },
      ],
    },
    {
      code: `
 class Foo {
  accessor method = () => {
    this;
  };
 }
      `,
    },
    {
      code: `
 class Foo {
  accessor method = function () {
    this;
  };
 }
      `,
    },
  ],
 });
Original file line number	Diff line number	Diff line change
Expand Up		@@ -9,7 +9,7 @@ import TabItem from '@theme/TabItem';
		>
		> See https://typescript-eslint.io/rules/class-methods-use-this for documentation.

		It adds support for ignoring `override` methods and/or methods on classes that implement an interface.
		It adds support for ignoring `override` methods and/or methods on classes that implement an interface. It also supports auto-accessor properties.

		## Options

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -104,14 +104,20 @@ export default createRule<Options, MessageIds>({
		}
		\| {
		class: TSESTree.ClassDeclaration \| TSESTree.ClassExpression;
		member: TSESTree.MethodDefinition \| TSESTree.PropertyDefinition;
		member:
		\| TSESTree.AccessorProperty
		\| TSESTree.MethodDefinition
		\| TSESTree.PropertyDefinition;
		parent: Stack \| undefined;
		usesThis: boolean;
		};
		let stack: Stack \| undefined;

		function pushContext(
		member?: TSESTree.MethodDefinition \| TSESTree.PropertyDefinition,
		member?:
		\| TSESTree.AccessorProperty
		\| TSESTree.MethodDefinition
		\| TSESTree.PropertyDefinition,
		): void {
		if (member?.parent.type === AST_NODE_TYPES.ClassBody) {
		stack = {
Expand All		@@ -135,7 +141,8 @@ export default createRule<Options, MessageIds>({
		): void {
		if (
		node.parent.type === AST_NODE_TYPES.MethodDefinition \|\|
		node.parent.type === AST_NODE_TYPES.PropertyDefinition
		node.parent.type === AST_NODE_TYPES.PropertyDefinition \|\|
		node.parent.type === AST_NODE_TYPES.AccessorProperty
		) {
		pushContext(node.parent);
		} else {
Expand DownExpand Up		@@ -172,7 +179,8 @@ export default createRule<Options, MessageIds>({
		node.static \|\|
		(node.type === AST_NODE_TYPES.MethodDefinition &&
		node.kind === 'constructor') \|\|
		(node.type === AST_NODE_TYPES.PropertyDefinition &&
		((node.type === AST_NODE_TYPES.PropertyDefinition \|\|
		node.type === AST_NODE_TYPES.AccessorProperty) &&
		!enforceForClassFields)
		) {
		return false;
Expand DownExpand Up		@@ -242,6 +250,16 @@ export default createRule<Options, MessageIds>({
		},
		...(enforceForClassFields
		? {
		'AccessorProperty > ArrowFunctionExpression.value'(
		node: TSESTree.ArrowFunctionExpression,
		): void {
		enterFunction(node);
		},
		'AccessorProperty > ArrowFunctionExpression.value:exit'(
		node: TSESTree.ArrowFunctionExpression,
		): void {
		exitFunction(node);
		},
		'PropertyDefinition > ArrowFunctionExpression.value'(
		node: TSESTree.ArrowFunctionExpression,
		): void {
Expand All		@@ -258,6 +276,12 @@ export default createRule<Options, MessageIds>({
		/*
		* Class field value are implicit functions.
		*/
		'AccessorProperty:exit'(): void {
		popContext();
		},
		'AccessorProperty > *.key:exit'(): void {
		pushContext();
		},
		'PropertyDefinition:exit'(): void {
		popContext();
		},
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -47,6 +47,45 @@ class Foo {
		},
		{
		code: `
		class Foo {
		accessor method = () => {};
		}
		`,
		errors: [
		{
		messageId: 'missingThis',
		},
		],
		options: [{}],
		},
		{
		code: `
		class Foo {
		private accessor method = () => {};
		}
		`,
		errors: [
		{
		messageId: 'missingThis',
		},
		],
		options: [{}],
		},
		{
		code: `
		class Foo {
		protected accessor method = () => {};
		}
		`,
		errors: [
		{
		messageId: 'missingThis',
		},
		],
		options: [{}],
		},
		{
		code: `
		class Foo {
		#method() {}
		}
Expand DownExpand Up		@@ -577,6 +616,14 @@ class Foo implements Bar {
		},
		{
		code: `
		class Foo implements Bar {
		accessor method = () => {};
		}
		`,
		options: [{ ignoreClassesThatImplementAnInterface: true }],
		},
		{
		code: `
		class Foo implements Bar {
		get getter() {}
		}
Expand DownExpand Up		@@ -617,6 +664,14 @@ class Foo {
		},
		{
		code: `
		class Foo {
		override accessor method = () => {};
		}
		`,
		options: [{ ignoreOverrideMethods: true }],
		},
		{
		code: `
		class Foo {
		override get getter(): number {}
		}
Expand DownExpand Up		@@ -901,5 +956,23 @@ class Foo implements Bar {
		},
		],
		},
		{
		code: `
		class Foo {
		accessor method = () => {
		this;
		};
		}
		`,
		},
		{
		code: `
		class Foo {
		accessor method = function () {
		this;
		};
		}
		`,
		},
		],
		});