Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: migraterule-schema-to-typescript-types fromjest tovitest#10774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit49e0121
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67fe5630dd164c000816e520
😎 Deploy Previewhttps://deploy-preview-10774--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit49e0121.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded6m 12sView ↗
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 28sView ↗
nx test utils✅ Succeeded13sView ↗
nx test type-utils✅ Succeeded24sView ↗
nx run types:build✅ Succeeded1sView ↗
nx typecheck ast-spec✅ Succeeded5sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded1m 10sView ↗
nx run typescript-estree:test -- --coverage✅ Succeeded54sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-04-15 13:08:38 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.82%. Comparing base(be558e5) to head(49e0121).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10774   +/-   ##=======================================  Coverage   90.82%   90.82%           =======================================  Files         497      497             Lines       50204    50204             Branches     8274     8274           =======================================  Hits        45600    45600             Misses       4589     4589             Partials       15       15
FlagCoverage Δ
unittest90.82% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/rule-schema-to-typescript-types-vitest-migration branch 4 times, most recently from0e06367 toe1e3271CompareFebruary 5, 2025 10:45
@aryaemami59aryaemami59 changed the titlechore(rule-schema-to-typescript-types): migrate fromjest tovitestchore: migraterule-schema-to-typescript-types fromjest tovitestFeb 5, 2025
@aryaemami59aryaemami59force-pushed thechore/rule-schema-to-typescript-types-vitest-migration branch 15 times, most recently fromca08b3e to44b0ac0CompareFebruary 12, 2025 13:43
@aryaemami59aryaemami59force-pushed thechore/rule-schema-to-typescript-types-vitest-migration branch 5 times, most recently from13825b7 toa3f9d7fCompareFebruary 15, 2025 12:11
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on#10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

@aryaemami59aryaemami59force-pushed thechore/rule-schema-to-typescript-types-vitest-migration branch fromdadee50 to863b922CompareApril 5, 2025 16:50
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
…t-eslint into chore/rule-schema-to-typescript-types-vitest-migration
@JoshuaKGoldbergJoshuaKGoldberg mentioned this pull requestApr 14, 2025
14 tasks
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since the package isn't tested in CI, I ran things locally. They all passed. ACK onpassWithNoTests: true. 👍

@JoshuaKGoldbergJoshuaKGoldberg merged commit7f32763 intotypescript-eslint:mainApr 15, 2025
50 of 53 checks passed
@aryaemami59aryaemami59 deleted the chore/rule-schema-to-typescript-types-vitest-migration branchApril 23, 2025 00:16
phaux pushed a commit to phaux/typescript-eslint that referenced this pull requestApr 24, 2025
…st` (typescript-eslint#10774)* Install `vitest`* Rename `jest.config.js` to `vitest.config.mts`* chore(rule-schema-to-typescript-types): migrate to `vitest`* Fix Vitest config* Include `vitest.config.mts` in `tsconfig.spec.json`* Explicitly enable `resolveJsonModule`* Use `.replace` instead of `.split`* Type check `vitest.config.mts` files using project references.* Fix Vitest config* Update `vitest` to version 3.1.1* Update `@vitest/eslint-plugin` to version 1.1.39* Fix `knip`* Update `vite` to version 6.2.5* Update `vite` to version 6.2.6* Update `@vitest/eslint-plugin` to version 1.1.40* Update `@vitest/eslint-plugin` to version 1.1.42* Enable the new `vitest/prefer-describe-function-title` rule* Use `vitestPlugin.configs.env`* Try disabling remote cache* Try disabling remote cache* Update `typecheck` output path in `nx.json`* Fix `vitest` coverage output when run with `nx`---------Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aryaemami59@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp