Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(visitor-keys): migrate fromjest tovitest#10773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commite7ad033
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67f4280f18531200089b7b90
😎 Deploy Previewhttps://deploy-preview-10773--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commite7ad033.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-04-07 20:51:21 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base(ef7e6de) to head(e7ad033).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10773      +/-   ##==========================================+ Coverage   88.03%   88.12%   +0.09%==========================================  Files         470      470                Lines       16801    16929     +128       Branches     4745     4746       +1     ==========================================+ Hits        14790    14919     +129+ Misses       1664     1663       -1  Partials      347      347
FlagCoverage Δ
unittest88.12% <ø> (+0.09%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/visitor-keys-vitest-migration branch 18 times, most recently from81bf89a to0620b48CompareFebruary 10, 2025 17:55
@aryaemami59aryaemami59force-pushed thechore/visitor-keys-vitest-migration branch 6 times, most recently from62a825e toe14025dCompareFebruary 15, 2025 12:23
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on#10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

@JoshuaKGoldbergJoshuaKGoldberg added the blocked by another PRPRs which are ready to go but waiting on another PR labelFeb 25, 2025
@aryaemami59aryaemami59force-pushed thechore/visitor-keys-vitest-migration branch fromb18bd2f to008698eCompareMarch 16, 2025 13:10
@43081j
Copy link
Contributor

this one looks good to me 👍

aryaemami59 reacted with thumbs up emoji

Comment on lines +14 to +16

vite: false,

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It doesn't change the result but since we havevite in ourdevDependencies, the vite plugin forknip still infers that that this is avite project which is not accurate, on top of thatknip has to do a little bit less work which makes things a teeny tiny bit faster.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesApr 7, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! Just the one comment/question on thevitest property and I think we're good to merge. 🚀

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelApr 7, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitd1f57a7 intotypescript-eslint:mainApr 10, 2025
57 of 59 checks passed
@JoshuaKGoldbergJoshuaKGoldberg mentioned this pull requestJan 28, 2025
14 tasks
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

@43081j43081j43081j left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aryaemami59@JoshuaKGoldberg@43081j
[8]ページ先頭
©2009-2025 Movatter.jp