Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(typescript-eslint): migrate fromjest tovitest#10772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf1e0834
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67de0bf8d0b07800083166aa
😎 Deploy Previewhttps://deploy-preview-10772--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf1e0834.

CommandStatusDurationResult
nx run integration-tests:test❌ Failed2m 20sView ↗
nx test eslint-plugin✅ Succeeded7m 35sView ↗
nx test typescript-estree✅ Succeeded1m 13sView ↗
nx run utils:test -- --coverage✅ Succeeded5sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded52sView ↗
nx test scope-manager✅ Succeeded15sView ↗
nx test utils✅ Succeeded8sView ↗
Additional runs (25)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-03-22 01:29:05 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base(8474474) to head(f1e0834).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10772      +/-   ##==========================================+ Coverage   87.97%   87.98%   +0.01%==========================================  Files         470      470                Lines       16709    16735      +26       Branches     4710     4716       +6     ==========================================+ Hits        14699    14725      +26  Misses       1664     1664                Partials      346      346
FlagCoverage Δ
unittest87.98% <ø> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/typescript-eslint-vitest-migration branch 18 times, most recently from0cce14d toc725c24CompareFebruary 10, 2025 17:50
@aryaemami59aryaemami59force-pushed thechore/typescript-eslint-vitest-migration branch 6 times, most recently fromb8c067a to5c93e1aCompareFebruary 15, 2025 12:18
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on#10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

@JoshuaKGoldbergJoshuaKGoldberg added the blocked by another PRPRs which are ready to go but waiting on another PR labelFeb 25, 2025
@aryaemami59aryaemami59force-pushed thechore/typescript-eslint-vitest-migration branch from272bcbe toc5e83a5CompareMarch 4, 2025 06:04
@aryaemami59aryaemami59force-pushed thechore/typescript-eslint-vitest-migration branch froma593927 to554e60cCompareMarch 16, 2025 12:26
@kirkwaiblinger
Copy link
Member

seems like a straightforward corollary of#10771, with a whole bunch initial boilerplate. Sweet! 🙂

aryaemami59 reacted with thumbs up emoji

@kirkwaiblingerkirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 22, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚢

kirkwaiblinger and aryaemami59 reacted with hooray emoji
@JoshuaKGoldberg
Copy link
Member

Integration tests are failing on other PRs too. We can ignore them here.

kirkwaiblinger and aryaemami59 reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg merged commit649309f intotypescript-eslint:mainMar 24, 2025
56 of 58 checks passed
@aryaemami59aryaemami59 deleted the chore/typescript-eslint-vitest-migration branchMarch 26, 2025 19:05
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aryaemami59@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp