Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(eslint-plugin-internal): migrate fromjest tovitest#10771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 4, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc607191
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67d6b033b2fa7700083bf66b
😎 Deploy Previewhttps://deploy-preview-10771--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 4, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc607191.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded6m 13sView ↗
nx run eslint-plugin:test -- --coverage✅ Succeeded6m 10sView ↗
nx run integration-tests:test✅ Succeeded2m 22sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded6m 23sView ↗
nx test typescript-estree✅ Succeeded1m 2sView ↗
nx test type-utils✅ Succeeded20sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test typescript-eslint✅ Succeeded5sView ↗
Additional runs (25)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-03-16 11:20:52 UTC

@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.97%. Comparing base(543d36c) to head(c607191).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10771      +/-   ##==========================================+ Coverage   87.58%   87.97%   +0.38%==========================================  Files         470      470                Lines       16095    16709     +614       Branches     4668     4710      +42     ==========================================+ Hits        14097    14699     +602- Misses       1642     1664      +22+ Partials      356      346      -10
FlagCoverage Δ
unittest87.97% <ø> (+0.38%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/eslint-plugin-internal-vitest-migration branch 19 times, most recently from2bd4f9c to4516a9aCompareFebruary 10, 2025 17:38
@aryaemami59aryaemami59force-pushed thechore/eslint-plugin-internal-vitest-migration branch 6 times, most recently from355c47b tofff2a83CompareFebruary 15, 2025 12:06
@JoshuaKGoldberg
Copy link
Member

Marking as blocked on#10582. We'd like to normalize test scripts & coverage calculations before making the jump in individual packages.

kirkwaiblinger
kirkwaiblinger previously approved these changesMar 13, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is in good shape! Thanks for spending so much time and attention to detail on these! 🙏

aryaemami59 reacted with thumbs up emoji
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesMar 14, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Elderly gentleman happily saying "HELL YEAH!"

aryaemami59 reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 14, 2025
@github-actionsgithub-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 15, 2025
@aryaemami59aryaemami59force-pushed thechore/eslint-plugin-internal-vitest-migration branch from85affb3 toc7c3f40CompareMarch 16, 2025 02:25
@aryaemami59aryaemami59force-pushed thechore/eslint-plugin-internal-vitest-migration branch from7a4fc31 toc607191CompareMarch 16, 2025 11:04
@JoshuaKGoldberg
Copy link
Member

Merging now. Let's hope nothing breaks! 😄 🤞

@JoshuaKGoldbergJoshuaKGoldberg merged commit2b4f05c intotypescript-eslint:mainMar 17, 2025
59 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 25, 2025
@aryaemami59aryaemami59 deleted the chore/eslint-plugin-internal-vitest-migration branchMarch 26, 2025 18:40
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

@kirkwaiblingerkirkwaiblingerAwaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aryaemami59@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp