Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update some package scripts and dependency config#10765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59aryaemami59 commentedFeb 3, 2025•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

EDIT BY@kirkwaiblinger:

This PR enforces dependencies such thatgit clean -xfd && SKIP_POSTINSTALL_BUILD=true yarn && yarn test will succeed. Previously it did not succeed since some of the test tasks apparently had undeclared dependencies on build tasks.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 3, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit81147b6
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/6828505afcc51a000845b97c
😎 Deploy Previewhttps://deploy-preview-10765--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 3, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit81147b6.

CommandStatusDurationResult
nx typecheck ast-spec✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded2sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-05-17 09:18:36 UTC

@aryaemami59aryaemami59force-pushed thechore/fix-life-cycle-scripts branch 2 times, most recently from5663aba to79768d4CompareFebruary 3, 2025 18:08
@aryaemami59aryaemami59 marked this pull request as ready for reviewFebruary 3, 2025 18:12
@aryaemami59aryaemami59force-pushed thechore/fix-life-cycle-scripts branch 4 times, most recently from9d8fec3 to2f16d41CompareFebruary 5, 2025 13:59
@codecovCodecov
Copy link

codecovbot commentedFeb 5, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.92%. Comparing base(05014ff) to head(81147b6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10765   +/-   ##=======================================  Coverage   90.92%   90.92%           =======================================  Files         499      499             Lines       50845    50845             Branches     8384     8384           =======================================  Hits        46231    46231             Misses       4599     4599             Partials       15       15
FlagCoverage Δ
unittest90.92% <ø> (ø)

Flags with carried forward coverage won't be shown.Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/fix-life-cycle-scripts branch from2f16d41 toabd45dcCompareFebruary 7, 2025 12:09
@aryaemami59aryaemami59force-pushed thechore/fix-life-cycle-scripts branch 4 times, most recently frome2dc2a7 toa00d190CompareFebruary 7, 2025 20:39
@aryaemami59aryaemami59force-pushed thechore/fix-life-cycle-scripts branch 12 times, most recently from719098a to2d95a14CompareFebruary 10, 2025 16:32
@@ -135,9 +136,10 @@
],
"production": [
"default",
"!{projectRoot}/**/?(*.)+(test).[jt]s?(x)?(.snap)",
"!{projectRoot}/**/?(*.)+(test).?(m|c)[jt]s?(x)?(.snap|.shot)",
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this is done because of the newly addeddocs.test.mts file.

@JamesHenry
Copy link
Member

There's some good stuff in here but some nx config changes which don't really make sense. I was thinking I would push to the branch but I don't want to end up wiping your contributor data, so I'm going to merge this and then immediately work on revamping the nx setup

@JamesHenryJamesHenry changed the titlechore: fixnx usage with lifecycle scripts across all projectschore: update some package scripts and dependency configMay 17, 2025
@JamesHenryJamesHenry merged commit1c0e1ae intotypescript-eslint:mainMay 17, 2025
13 checks passed
@JamesHenry
Copy link
Member

I will post a loom covering why these nx changes were not optimal

@aryaemami59
Copy link
ContributorAuthor

@JamesHenry You can let me know what changes you don't like and I can get rid of them.

@aryaemami59aryaemami59 deleted the chore/fix-life-cycle-scripts branchMay 17, 2025 09:04
@JamesHenry
Copy link
Member

The PR to update things and an explainer loom are here, thanks!#11226

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JamesHenryJamesHenryAwaiting requested review from JamesHenry

@kirkwaiblingerkirkwaiblingerAwaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@aryaemami59@JamesHenry@kirkwaiblinger@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp