typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-misused-spread] correct and elaborate string spread report message#10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromJoshuaKGoldberg:no-misused-spread-string-report

Feb 10, 2025

Merged

fix(eslint-plugin): [no-misused-spread] correct and elaborate string spread report message#10751

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromJoshuaKGoldberg:no-misused-spread-string-report

Feb 10, 2025

Conversation

Copy link

Member

JoshuaKGoldberg commentedJan 31, 2025

PR Checklist

Addresses an existing open issue:fixesBug: [no-misused-spread] report for string spread harmfully conflates Unicode code points with UTF-16 code units #10745
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Updates the report message for a string spread to bemoanboth... and.split("").

💖

fix(eslint-plugin): [no-misused-spread] correct and elaborate string …

09e9931

…spread report message

Copy link

Contributor

typescript-eslintbot commentedJan 31, 2025

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

JoshuaKGoldberg mentioned this pull request

Jan 31, 2025

Bug: [no-misused-spread] report for string spread harmfully conflates Unicode code points with UTF-16 code units#10745

Closed

4 tasks

Copy link

netlifybot commentedJan 31, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`1af6d6f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67a3f59ff07f3d00088de281
😎 Deploy Preview	https://deploy-preview-10751--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 31, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit1af6d6f.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	4s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️Nx Cloud last updated this comment at2025-02-05 23:50:13 UTC

JoshuaKGoldberg commented

Jan 31, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-misused-spread.ts

		'- .split("") produces UTF-16 code units, which breaks rich characters in many languages',
		"If this string does not need to preserve emojis or other non-English characters, disable this lint rule on this line or configure the 'allow' rule option.",
		'Otherwise, consider using `Intl.Segmenter`.',
		].join('\n'),

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To anybody with opinions on string splitting: please bikeshed theheck out of this message!

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice!
I would prefer having the disable comment sentence as the otherwise with something like

If you want to split on graphemes, consider usingIntl.Segmenter
Otherwise, if this string does not need to preserve emojis ...

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

+1. I think it makes sense to say "consider using Intl.Segmenter for robust, locale-aware string decomposition." first, and then "Otherwise, if you don't need to preserve emojis or other non-Ascii characters, disable, etc..."

Copy link

MemberAuthor

JoshuaKGoldbergFeb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

the people have spoken

ST-DDT mentioned this pull request

Feb 3, 2025

Bug:prefer-spread shouldn't encourage iterating over stringssindresorhus/eslint-plugin-unicorn#2521

Open

kirkwaiblinger reviewed

Feb 5, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-misused-spread.ts OutdatedShow resolvedHide resolved

Update packages/eslint-plugin/src/rules/no-misused-spread.ts

bb6061d

Co-authored-by: Kirk Waiblinger <53019676+kirkwaiblinger@users.noreply.github.com>

JoshuaKGoldberg requested review fromArnaudBarre andkirkwaiblinger

February 5, 2025 13:17

kirkwaiblinger requested changes

Feb 5, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR has not been updated with the people's demands 😜https://github.com/typescript-eslint/typescript-eslint/pull/10751/files#r1942930884

Wondering if you forgot to push?

the people demand it

a11ffc6

Copy link

MemberAuthor

JoshuaKGoldberg commentedFeb 5, 2025

🤦

JoshuaKGoldberg requested a review fromkirkwaiblinger

February 5, 2025 19:50

kirkwaiblinger previously approved these changes

Feb 5, 2025

View reviewed changes

update snapshots

1af6d6f

kirkwaiblinger dismissed theirstale review via1af6d6f

February 5, 2025 23:34

kirkwaiblinger approved these changes

Feb 5, 2025

View reviewed changes

Copy link

codecovbot commentedFeb 5, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base(3372a4a) to head(1af6d6f).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10751      +/-   ##==========================================+ Coverage   87.26%   87.28%   +0.01%==========================================  Files         450      450                Lines       15715    15739      +24       Branches     4601     4609       +8     ==========================================+ Hits        13714    13737      +23  Misses       1645     1645- Partials      356      357       +1

Flag	Coverage Δ
unittest	`87.28% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-misused-spread.ts	`100.00% <ø> (ø)`

... and9 files with indirect coverage changes

ArnaudBarre reviewed

Feb 6, 2025

View reviewed changes

Copy link

Contributor

ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Feb 10, 2025

Copy link

MemberAuthor

JoshuaKGoldberg commentedFeb 10, 2025

I'd normally prefer to leave this open for a couple more days to get a full week (https://typescript-eslint.io/maintenance/pull-requests#approvals). But this is kind of a hot topic. Merging a couple days early.

JoshuaKGoldberg merged commit7acfb5f intotypescript-eslint:main

Feb 10, 2025

62 of 63 checks passed

JoshuaKGoldberg deleted the no-misused-spread-string-report branch

February 10, 2025 16:40

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 11, 2025

Update typescript-eslint monorepo to v8.24.0

a8432b3

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.23.0 | 8.24.0 || npm        | @typescript-eslint/parser        | 8.23.0 | 8.24.0 |## [v8.24.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8240-2025-02-10)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-condition] make `allowConstantLoopConditions` more granular ([#10639](typescript-eslint/typescript-eslint#10639))##### 🩹 Fixes-   **eslint-plugin:** \[no-misused-spread] correct and elaborate string spread report message ([#10751](typescript-eslint/typescript-eslint#10751))-   **eslint-plugin:** \[restrict-plus-operands] report adding bigints to strings when `allowNumberAndString` is `false` ([#10737](typescript-eslint/typescript-eslint#10737))##### ❤️ Thank You-   Josh Goldberg ✨-   noah-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 11, 2025

Update typescript-eslint monorepo to v8.24.0

33a3049

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.23.0 | 8.24.0 || npm        | @typescript-eslint/parser        | 8.23.0 | 8.24.0 |## [v8.24.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8240-2025-02-10)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-condition] make `allowConstantLoopConditions` more granular ([#10639](typescript-eslint/typescript-eslint#10639))##### 🩹 Fixes-   **eslint-plugin:** \[no-misused-spread] correct and elaborate string spread report message ([#10751](typescript-eslint/typescript-eslint#10751))-   **eslint-plugin:** \[restrict-plus-operands] report adding bigints to strings when `allowNumberAndString` is `false` ([#10737](typescript-eslint/typescript-eslint#10737))##### ❤️ Thank You-   Josh Goldberg ✨-   noah-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Feb 18, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-misused-spread] correct and elaborate string spread report message#10751

fix(eslint-plugin): [no-misused-spread] correct and elaborate string spread report message#10751

Uh oh!

Conversation

JoshuaKGoldberg commentedJan 31, 2025

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 31, 2025

Uh oh!

netlifybot commentedJan 31, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 31, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldbergJan 31, 2025

Choose a reason for hiding this comment

Uh oh!

ArnaudBarreFeb 3, 2025

Choose a reason for hiding this comment

Uh oh!

kirkwaiblingerFeb 5, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldbergFeb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commentedFeb 5, 2025

Uh oh!

codecovbot commentedFeb 5, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ArnaudBarre left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg commentedFeb 10, 2025

Uh oh!

Uh oh!

Uh oh!

netlifybot commentedJan 31, 2025•
edited
Loading

nx-cloudbot commentedJan 31, 2025•
edited
Loading

codecovbot commentedFeb 5, 2025•
edited
Loading