typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

kirkwaiblinger merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/10738

Feb 3, 2025

Merged

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

kirkwaiblinger merged 3 commits intotypescript-eslint:mainfromyeonjuan:fix/10738

Feb 3, 2025

Conversation

Copy link

Contributor

yeonjuan commentedJan 29, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [no-unnecessary-template-expression] False positive suggesting${T} ->T #10738
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

It addresses#10738.
Just as we allowed interpolation to convert an enum to a union, make it allow for the type parameter also.

fix(eslint-plugin): [no-unnecessary-template-expression] allow type p…

485010d

…arameter

Copy link

Contributor

typescript-eslintbot commentedJan 29, 2025

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

yeonjuan mentioned this pull request

Jan 29, 2025

Bug: [no-unnecessary-template-expression] False positive suggesting${T} ->T#10738

Closed

4 tasks

Copy link

netlifybot commentedJan 29, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4b58926`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/679f719fb22311000886b227
😎 Deploy Preview	https://deploy-preview-10739--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 93 (🔴 down 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 29, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit4b58926.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-02-02 21:13:52 UTC

update

d42f799

yeonjuan marked this pull request as ready for review

January 29, 2025 07:41

Copy link

codecovbot commentedJan 29, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.26%. Comparing base(8376abe) to head(4b58926).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10739   +/-   ##=======================================  Coverage   87.26%   87.26%           =======================================  Files         450      450             Lines       15716    15716             Branches     4601     4601           =======================================  Hits        13715    13715             Misses       1645     1645             Partials      356      356

Flag	Coverage Δ
unittest	`87.26% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...in/src/rules/no-unnecessary-template-expression.ts	`100.00% <100.00%> (ø)`

Merge branch 'main' into fix/10738

4b58926

kirkwaiblinger approved these changes

Feb 2, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ezpz. Nicely done! 🙂

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Feb 2, 2025

ronami approved these changes

Feb 2, 2025

View reviewed changes

kirkwaiblinger changed the title~~fix(eslint-plugin): [no-unnecessary-template-expression] allow type parameter~~fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context

Feb 3, 2025

kirkwaiblinger merged commit77df70d intotypescript-eslint:main

Feb 3, 2025

67 checks passed

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 5, 2025

Update typescript-eslint monorepo to v8.23.0

4b0a3a7

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 || npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))##### 🩹 Fixes-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))##### ❤️ Thank You-   Josh Goldberg ✨-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ryan Poon [@sopa301](https://github.com/sopa301)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 5, 2025

Update typescript-eslint monorepo to v8.23.0

2affa96

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 || npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))##### 🩹 Fixes-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))##### ❤️ Thank You-   Josh Goldberg ✨-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ryan Poon [@sopa301](https://github.com/sopa301)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Feb 11, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

Uh oh!

Conversation

yeonjuan commentedJan 29, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 29, 2025

Uh oh!

netlifybot commentedJan 29, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 29, 2025•
edited
Loading

Uh oh!

Uh oh!

codecovbot commentedJan 29, 2025•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

fix(eslint-plugin): [no-unnecessary-template-expression] allow interpolating type parameter in type context#10739

Uh oh!

Conversation

yeonjuan commentedJan 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 29, 2025

Uh oh!

netlifybot commentedJan 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedJan 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedJan 29, 2025•
edited
Loading

netlifybot commentedJan 29, 2025•
edited
Loading

nx-cloudbot commentedJan 29, 2025•
edited
Loading

codecovbot commentedJan 29, 2025•
edited
Loading