Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(eslint-plugin): [prefer-nullish-coalescing] streamline code examples#10735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@OlivierZal
Copy link
Contributor

@OlivierZalOlivierZal commentedJan 28, 2025•
edited by kirkwaiblinger
Loading

PR Checklist

Overview

ronami reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJan 28, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitbee3fdb
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67a0f3d8b6e66500089fca20
😎 Deploy Previewhttps://deploy-preview-10735--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedJan 28, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitbee3fdb.

CommandStatusDurationResult
nx test eslint-plugin✅ Succeeded5m 57sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded7m 52sView ↗
nx test utils✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test visitor-keys✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded28sView ↗
nx test typescript-eslint✅ Succeeded5sView ↗
nx test scope-manager✅ Succeeded<1sView ↗
Additional runs (24)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-02-03 17:11:16 UTC

@OlivierZalOlivierZal marked this pull request as draftJanuary 28, 2025 20:55
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10566 branch 3 times, most recently from2911abe toe7bd52dCompareJanuary 28, 2025 22:27
@OlivierZalOlivierZalforce-pushed theprefer-nullish-coalescing-10566 branch frome7bd52d to3d9cb2eCompareJanuary 28, 2025 22:37
@OlivierZalOlivierZal marked this pull request as ready for reviewJanuary 28, 2025 22:38
@codecov
Copy link

codecovbot commentedJan 28, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.28%. Comparing base(06925f8) to head(bee3fdb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10735      +/-   ##==========================================- Coverage   87.28%   87.28%   -0.01%==========================================  Files         450      450                Lines       15739    15739                Branches     4609     4609              ==========================================- Hits        13738    13737       -1  Misses       1645     1645- Partials      356      357       +1
FlagCoverage Δ
unittest87.28% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 1 file with indirect coverage changes

@OlivierZalOlivierZal marked this pull request as draftFebruary 1, 2025 09:18
@OlivierZalOlivierZal marked this pull request as ready for reviewFebruary 1, 2025 10:36
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesFeb 1, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! Will defer to@kirkwaiblinger ~

OlivierZal reacted with heart emoji
@OlivierZal
Copy link
ContributorAuthor

Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks great, thanks for pushing this, just requesting changes around the code examples 👍👍

OlivierZal reacted with heart emoji
@ronamironami added the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 2, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 2, 2025
@OlivierZal
Copy link
ContributorAuthor

Hi@ronami, thanks for your review! Examples fixed.

ronami reacted with heart emoji

ronami
ronami previously approved these changesFeb 2, 2025
Copy link
Member

@ronamironami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

@OlivierZal
Copy link
ContributorAuthor

OlivierZal commentedFeb 2, 2025•
edited
Loading

2 remaining checks seem to be stuck but it looks good:https://deploy-preview-10735--typescript-eslint.netlify.app/rules/prefer-nullish-coalescing

@kirkwaiblingerkirkwaiblinger changed the titledocs(eslint-plugin): [prefer-nullish-coalescing] streamline code exam…docs(eslint-plugin): [prefer-nullish-coalescing] streamline code examplesFeb 3, 2025
kirkwaiblinger
kirkwaiblinger previously approved these changesFeb 3, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cleaner and better. Thanks!

OlivierZal reacted with heart emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitbcdf560 intotypescript-eslint:mainFeb 3, 2025
62 checks passed
@OlivierZalOlivierZal deleted the prefer-nullish-coalescing-10566 branchFebruary 3, 2025 19:12
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ronamironamironami left review comments

@kirkwaiblingerkirkwaiblingerkirkwaiblinger left review comments

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: [prefer-nullish-coalescing] streamline code examples

4 participants

@OlivierZal@JoshuaKGoldberg@ronami@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp