typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(eslint-plugin): [no-unnecessary-condition] enable checkTypePredicates by default#10721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

mdm317 wants to merge2 commits intotypescript-eslint:main

base:main

Choose a base branch

frommdm317:10720-checkTypePredicates-by-default

Draft

feat(eslint-plugin): [no-unnecessary-condition] enable checkTypePredicates by default#10721

mdm317 wants to merge2 commits intotypescript-eslint:mainfrommdm317:10720-checkTypePredicates-by-default

Conversation

Copy link

Contributor

mdm317 commentedJan 28, 2025

PR Checklist

Addresses an existing open issue:fixesConfigs: [no-unnecessary-condition] EnablecheckTypePredicates by default #10720
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat: enable checkTypePredicates by default

cb280d0

Copy link

Contributor

typescript-eslintbot commentedJan 28, 2025

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 28, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`107a4c2`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67984c2037a57600081448cc
😎 Deploy Preview	https://deploy-preview-10721--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 28, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit107a4c2.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	4s	View ↗
`nx run-many --target=clean`	✅ Succeeded	12s	View ↗

☁️Nx Cloud last updated this comment at2025-01-28 12:17:28 UTC

remove useless option code

107a4c2

Copy link

codecovbot commentedJan 28, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base(94e8098) to head(107a4c2).

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10721      +/-   ##==========================================+ Coverage   87.26%   87.27%   +0.01%==========================================  Files         450      450                Lines       15712    15712                Branches     4600     4600              ==========================================+ Hits        13711    13713       +2+ Misses       1645     1643       -2  Partials      356      356