typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary#10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 30 commits intotypescript-eslint:mainfromOlivierZal:prefer-nullish-coalescing-10531

Feb 24, 2025

Merged

fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary#10708

JoshuaKGoldberg merged 30 commits intotypescript-eslint:mainfromOlivierZal:prefer-nullish-coalescing-10531

Feb 24, 2025

Conversation

Copy link

Contributor

OlivierZal commentedJan 24, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [prefer-nullish-coalescing] doesn't report on chain expressions in a ternary #10531
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Copy link

Contributor

typescript-eslintbot commentedJan 24, 2025

Thanks for the PR,@OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 24, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`e800c2a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67bc88d6a5dfdf0008d19711
😎 Deploy Preview	https://deploy-preview-10708--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🟢 up 22 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 24, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit2c2f3ec.

Command	Status	Duration	Result
`nx run integration-tests:test`	❌ Failed	2m 21s	View ↗
`nx test eslint-plugin --coverage=false`	✅ Succeeded	6m 28s	View ↗
`nx test visitor-keys --coverage=false`	✅ Succeeded	<1s	View ↗
`nx run types:build`	✅ Succeeded	<1s	View ↗
`nx test utils --coverage=false`	✅ Succeeded	<1s	View ↗
`nx run-many --target=build --exclude website --...`	✅ Succeeded	19s	View ↗
`nx test typescript-eslint --coverage=false`	✅ Succeeded	15s	View ↗
`nx test type-utils --coverage=false`	✅ Succeeded	<1s	View ↗
`Additional runs (21)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-02-24 14:55:40 UTC

OlivierZal changed the title~~add first tests (TDD)~~fix(eslint-plugin): [prefer-nullish-coalescing] doesn't report on chain expressions in a ternary

Jan 24, 2025

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch from5c47f39 to2a49959Compare

January 24, 2025 10:33

OlivierZal marked this pull request as draft

January 24, 2025 22:22

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch from2a49959 to629f39eCompare

January 24, 2025 22:34

OlivierZal mentioned this pull request

Jan 24, 2025

Bug: [prefer-nullish-coalescing] doesn't report on chain expressions in a ternary#10531

Closed

4 tasks

OlivierZal marked this pull request as ready for review

January 24, 2025 23:13

Copy link

codecovbot commentedJan 24, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.30%. Comparing base(fa77b41) to head(e800c2a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10708   +/-   ##=======================================  Coverage   87.30%   87.30%           =======================================  Files         450      451    +1       Lines       15768    15768             Branches     4617     4616    -1     =======================================  Hits        13767    13767             Misses       1645     1645             Partials      356      356

Flag	Coverage Δ
unittest	`87.30% <100.00%> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	`98.58% <100.00%> (-0.02%)`	⬇️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts	`98.27% <100.00%> (-0.03%)`	⬇️
packages/eslint-plugin/src/rules/prefer-find.ts	`100.00% <100.00%> (ø)`
...lint-plugin/src/rules/prefer-nullish-coalescing.ts	`95.58% <100.00%> (+0.15%)`	⬆️
...t-plugin/src/rules/prefer-promise-reject-errors.ts	`100.00% <ø> (ø)`
...plugin/src/rules/prefer-string-starts-ends-with.ts	`97.42% <100.00%> (-0.04%)`	⬇️
...ages/eslint-plugin/src/util/skipChainExpression.ts	`100.00% <100.00%> (ø)`

OlivierZal marked this pull request as draft

January 24, 2025 23:27

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch 3 times, most recently from03d4f65 toaa33e20Compare

January 26, 2025 00:40

OlivierZal marked this pull request as ready for review

January 26, 2025 00:43

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch from0f54d68 tob2ce5f3Compare

January 27, 2025 08:43

This was referencedJan 28, 2025

Docs: [prefer-nullish-coalescing] streamline code examples#10566

Closed

Bug: [prefer-nullish-coalescing] Should not report error#10724

Closed

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch from3c1a848 to4fba4b3Compare

January 28, 2025 20:06

OlivierZal mentioned this pull request

Jan 28, 2025

fix(eslint-plugin): [prefer-nullish-coalescing] fix missing return#10732

Merged

3 tasks

OlivierZal marked this pull request as draft

February 3, 2025 08:34

OlivierZal added4 commits

February 4, 2025 15:23

handle ChainExpression in preferNullishOverTernary

200e6e2

simplify

d0a06a7

naming

58eabb3

Move block which comes too early

5af7ed9

OlivierZal force-pushed theprefer-nullish-coalescing-10531 branch from4fba4b3 to5af7ed9Compare

February 4, 2025 14:27

add tests

dd90ef8

OlivierZal marked this pull request as ready for review

February 4, 2025 20:26

OlivierZal marked this pull request as draft

February 4, 2025 20:27

handle use case where 2 conditions

bc3ff36

OlivierZal added5 commits

February 18, 2025 01:35

simplify

53dd427

Simplify

7114958

Merge branch 'main' into prefer-nullish-coalescing-10531

b5e3fcd

Typo

8eed250

Simplify

a1674cf

Copy link

ContributorAuthor

OlivierZal commentedFeb 18, 2025

@JoshuaKGoldberg,@kirkwaiblinger, I think I've fixed the missing use cases:

https://deploy-preview-10708--typescript-eslint.netlify.app/play/#ts=5.7.2&fileType=.tsx&code=CYUwxgNghgTiAEEQBd4E8Bc8oDs0G4BYAKFElgSVQA8sBvbAfnvgCMWwsBWeAXz75FiJABTUAdFEbjWASmlh4jeBKkzxirAGYhYydLkKl8MdKiz1m%2BDqA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0WlqYSNkAC1pkA9gEMkyMswDm6KL2jjokcGAC%2BILUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

kirkwaiblinger requested changes

Feb 20, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One pedantic complaint about naming but otherwise thumbs up 👍

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts OutdatedShow resolvedHide resolved

renaming and adding JS doc

b31b29e

OlivierZal requested a review fromkirkwaiblinger

February 20, 2025 14:10

simplify js doc

c131cad

Copy link

ContributorAuthor

OlivierZal commentedFeb 20, 2025

Fixed!

kirkwaiblinger approved these changes

Feb 20, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Delightful. Thanks again!

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Feb 20, 2025

OlivierZal mentioned this pull request

Feb 21, 2025

Enhancement: [prefer-nullish-coalescing] should supportif statement assignment (??=)#10829

Closed

4 tasks

Copy link

ContributorAuthor

OlivierZal commentedFeb 22, 2025•
edited
Loading

I’m pretty sure the PR was green before Kirk’s approval, maybe I messed up when I created a new branch from this one… (although I didn’t add new code to this one).

Copy link

Member

kirkwaiblinger commentedFeb 22, 2025

maybe try merging main and we'll see? There were some changes to CI recently

Merge branch 'main' into prefer-nullish-coalescing-10531

7970bfa

OlivierZal mentioned this pull request

Feb 22, 2025

feat(eslint-plugin): [prefer-nullish-coalescing] supportif statement assignment (??=) and fix several minor bugs#10861

Merged

3 tasks

Copy link

ContributorAuthor

OlivierZal commentedFeb 22, 2025•
edited
Loading

CI issue will be fixed by#10870

JoshuaKGoldbergand others added2 commits

February 24, 2025 09:37

Merge branch 'main' into prefer-nullish-coalescing-10531

2c2f3ec

Merge branch 'main' into prefer-nullish-coalescing-10531

e800c2a

Copy link

ContributorAuthor

OlivierZal commentedFeb 24, 2025•
edited
Loading

Seems there’s a failing snapshot onmain.

Copy link

Member

JoshuaKGoldberg commentedFeb 24, 2025

Hoping to fix it with#10880. In the meantime, we're good to go here. ✅

JoshuaKGoldberg changed the title~~fix(eslint-plugin): [prefer-nullish-coalescing] doesn't report on chain expressions in a ternary~~fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary

Feb 24, 2025

JoshuaKGoldberg merged commitf22de04 intotypescript-eslint:main

Feb 24, 2025

59 of 61 checks passed

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 26, 2025

Update typescript-eslint monorepo to v8.25.0

b713880

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.24.0 | 8.25.0 || npm        | @typescript-eslint/parser        | 8.24.0 | 8.25.0 |## [v8.25.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8250-2025-02-24)##### 🚀 Features-   **eslint-plugin:** \[no-misused-spread] add suggestions ([#10719](typescript-eslint/typescript-eslint#10719))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] report on chain expressions in a ternary ([#10708](typescript-eslint/typescript-eslint#10708))-   **eslint-plugin:** \[no-deprecated] report usage of deprecated private identifiers ([#10844](typescript-eslint/typescript-eslint#10844))-   **eslint-plugin:** \[unified-signatures] handle getter-setter ([#10818](typescript-eslint/typescript-eslint#10818))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.24.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8241-2025-02-17)##### 🩹 Fixes-   **eslint-plugin:** \[class-methods-use-this] check `accessor` methods with a function initializer ([#10796](typescript-eslint/typescript-eslint#10796))-   **eslint-plugin:** \[no-misused-promises] don't report on `static` `accessor` properties ([#10814](typescript-eslint/typescript-eslint#10814))-   **eslint-plugin:** \[no-deprecated] don't report on deprecated `accessor` property declaration ([#10813](typescript-eslint/typescript-eslint#10813))-   **eslint-plugin:** \[explicit-member-accessibility] check `accessor` class properties for missing accessibility modifier ([#10805](typescript-eslint/typescript-eslint#10805))-   **eslint-plugin:** \[explicit-module-boundary-types] check `accessor` class properties with a function initializer ([#10804](typescript-eslint/typescript-eslint#10804))-   **eslint-plugin:** \[prefer-return-this-type] check `accessor` properties with a function initializer ([#10794](typescript-eslint/typescript-eslint#10794))-   **eslint-plugin:** \[consistent-generic-constructors] check `accessor` class properties ([#10789](typescript-eslint/typescript-eslint#10789))-   **eslint-plugin:** \[no-unsafe-assignment] report on an `any` value assigned as an initializer of an `accessor` property ([#10785](typescript-eslint/typescript-eslint#10785))-   **eslint-plugin:** \[no-unnecessary-template-expression] ignore enum and enum members ([#10782](typescript-eslint/typescript-eslint#10782))-   **eslint-plugin:** \[no-inferrable-types] handle accessor ([#10780](typescript-eslint/typescript-eslint#10780))##### ❤️ Thank You-   Ronen Amiel-   YeonJuanYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Feb 26, 2025

Update typescript-eslint monorepo to v8.25.0

3df9a42

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.24.0 | 8.25.0 || npm        | @typescript-eslint/parser        | 8.24.0 | 8.25.0 |## [v8.25.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8250-2025-02-24)##### 🚀 Features-   **eslint-plugin:** \[no-misused-spread] add suggestions ([#10719](typescript-eslint/typescript-eslint#10719))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] report on chain expressions in a ternary ([#10708](typescript-eslint/typescript-eslint#10708))-   **eslint-plugin:** \[no-deprecated] report usage of deprecated private identifiers ([#10844](typescript-eslint/typescript-eslint#10844))-   **eslint-plugin:** \[unified-signatures] handle getter-setter ([#10818](typescript-eslint/typescript-eslint#10818))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.24.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8241-2025-02-17)##### 🩹 Fixes-   **eslint-plugin:** \[class-methods-use-this] check `accessor` methods with a function initializer ([#10796](typescript-eslint/typescript-eslint#10796))-   **eslint-plugin:** \[no-misused-promises] don't report on `static` `accessor` properties ([#10814](typescript-eslint/typescript-eslint#10814))-   **eslint-plugin:** \[no-deprecated] don't report on deprecated `accessor` property declaration ([#10813](typescript-eslint/typescript-eslint#10813))-   **eslint-plugin:** \[explicit-member-accessibility] check `accessor` class properties for missing accessibility modifier ([#10805](typescript-eslint/typescript-eslint#10805))-   **eslint-plugin:** \[explicit-module-boundary-types] check `accessor` class properties with a function initializer ([#10804](typescript-eslint/typescript-eslint#10804))-   **eslint-plugin:** \[prefer-return-this-type] check `accessor` properties with a function initializer ([#10794](typescript-eslint/typescript-eslint#10794))-   **eslint-plugin:** \[consistent-generic-constructors] check `accessor` class properties ([#10789](typescript-eslint/typescript-eslint#10789))-   **eslint-plugin:** \[no-unsafe-assignment] report on an `any` value assigned as an initializer of an `accessor` property ([#10785](typescript-eslint/typescript-eslint#10785))-   **eslint-plugin:** \[no-unnecessary-template-expression] ignore enum and enum members ([#10782](typescript-eslint/typescript-eslint#10782))-   **eslint-plugin:** \[no-inferrable-types] handle accessor ([#10780](typescript-eslint/typescript-eslint#10780))##### ❤️ Thank You-   Ronen Amiel-   YeonJuanYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Mar 1, 2025

Update typescript-eslint monorepo to v8.25.0

9920966

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.24.0 | 8.25.0 || npm        | @typescript-eslint/parser        | 8.24.0 | 8.25.0 |## [v8.25.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8250-2025-02-24)##### 🚀 Features-   **eslint-plugin:** \[no-misused-spread] add suggestions ([#10719](typescript-eslint/typescript-eslint#10719))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] report on chain expressions in a ternary ([#10708](typescript-eslint/typescript-eslint#10708))-   **eslint-plugin:** \[no-deprecated] report usage of deprecated private identifiers ([#10844](typescript-eslint/typescript-eslint#10844))-   **eslint-plugin:** \[unified-signatures] handle getter-setter ([#10818](typescript-eslint/typescript-eslint#10818))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.24.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8241-2025-02-17)##### 🩹 Fixes-   **eslint-plugin:** \[class-methods-use-this] check `accessor` methods with a function initializer ([#10796](typescript-eslint/typescript-eslint#10796))-   **eslint-plugin:** \[no-misused-promises] don't report on `static` `accessor` properties ([#10814](typescript-eslint/typescript-eslint#10814))-   **eslint-plugin:** \[no-deprecated] don't report on deprecated `accessor` property declaration ([#10813](typescript-eslint/typescript-eslint#10813))-   **eslint-plugin:** \[explicit-member-accessibility] check `accessor` class properties for missing accessibility modifier ([#10805](typescript-eslint/typescript-eslint#10805))-   **eslint-plugin:** \[explicit-module-boundary-types] check `accessor` class properties with a function initializer ([#10804](typescript-eslint/typescript-eslint#10804))-   **eslint-plugin:** \[prefer-return-this-type] check `accessor` properties with a function initializer ([#10794](typescript-eslint/typescript-eslint#10794))-   **eslint-plugin:** \[consistent-generic-constructors] check `accessor` class properties ([#10789](typescript-eslint/typescript-eslint#10789))-   **eslint-plugin:** \[no-unsafe-assignment] report on an `any` value assigned as an initializer of an `accessor` property ([#10785](typescript-eslint/typescript-eslint#10785))-   **eslint-plugin:** \[no-unnecessary-template-expression] ignore enum and enum members ([#10782](typescript-eslint/typescript-eslint#10782))-   **eslint-plugin:** \[no-inferrable-types] handle accessor ([#10780](typescript-eslint/typescript-eslint#10780))##### ❤️ Thank You-   Ronen Amiel-   YeonJuanYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Mar 2, 2025

Update typescript-eslint monorepo to v8.25.0

2e77da9

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.24.0 | 8.25.0 || npm        | @typescript-eslint/parser        | 8.24.0 | 8.25.0 |## [v8.25.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8250-2025-02-24)##### 🚀 Features-   **eslint-plugin:** \[no-misused-spread] add suggestions ([#10719](typescript-eslint/typescript-eslint#10719))##### 🩹 Fixes-   **eslint-plugin:** \[prefer-nullish-coalescing] report on chain expressions in a ternary ([#10708](typescript-eslint/typescript-eslint#10708))-   **eslint-plugin:** \[no-deprecated] report usage of deprecated private identifiers ([#10844](typescript-eslint/typescript-eslint#10844))-   **eslint-plugin:** \[unified-signatures] handle getter-setter ([#10818](typescript-eslint/typescript-eslint#10818))##### ❤️ Thank You-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.## [v8.24.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8241-2025-02-17)##### 🩹 Fixes-   **eslint-plugin:** \[class-methods-use-this] check `accessor` methods with a function initializer ([#10796](typescript-eslint/typescript-eslint#10796))-   **eslint-plugin:** \[no-misused-promises] don't report on `static` `accessor` properties ([#10814](typescript-eslint/typescript-eslint#10814))-   **eslint-plugin:** \[no-deprecated] don't report on deprecated `accessor` property declaration ([#10813](typescript-eslint/typescript-eslint#10813))-   **eslint-plugin:** \[explicit-member-accessibility] check `accessor` class properties for missing accessibility modifier ([#10805](typescript-eslint/typescript-eslint#10805))-   **eslint-plugin:** \[explicit-module-boundary-types] check `accessor` class properties with a function initializer ([#10804](typescript-eslint/typescript-eslint#10804))-   **eslint-plugin:** \[prefer-return-this-type] check `accessor` properties with a function initializer ([#10794](typescript-eslint/typescript-eslint#10794))-   **eslint-plugin:** \[consistent-generic-constructors] check `accessor` class properties ([#10789](typescript-eslint/typescript-eslint#10789))-   **eslint-plugin:** \[no-unsafe-assignment] report on an `any` value assigned as an initializer of an `accessor` property ([#10785](typescript-eslint/typescript-eslint#10785))-   **eslint-plugin:** \[no-unnecessary-template-expression] ignore enum and enum members ([#10782](typescript-eslint/typescript-eslint#10782))-   **eslint-plugin:** \[no-inferrable-types] handle accessor ([#10780](typescript-eslint/typescript-eslint#10780))##### ❤️ Thank You-   Ronen Amiel-   YeonJuanYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Mar 4, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary#10708

fix(eslint-plugin): [prefer-nullish-coalescing] report on chain expressions in a ternary#10708

Uh oh!

Conversation

OlivierZal commentedJan 24, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 24, 2025

Uh oh!

netlifybot commentedJan 24, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 24, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedJan 24, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OlivierZal commentedFeb 18, 2025

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OlivierZal commentedFeb 20, 2025

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

OlivierZal commentedFeb 22, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

kirkwaiblinger commentedFeb 22, 2025

Uh oh!

OlivierZal commentedFeb 22, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

OlivierZal commentedFeb 24, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commentedFeb 24, 2025

Uh oh!

Uh oh!

Uh oh!

OlivierZal commentedJan 24, 2025•
edited
Loading

netlifybot commentedJan 24, 2025•
edited
Loading

nx-cloudbot commentedJan 24, 2025•
edited
Loading

codecovbot commentedJan 24, 2025•
edited
Loading

OlivierZal commentedFeb 22, 2025•
edited
Loading

OlivierZal commentedFeb 22, 2025•
edited
Loading

OlivierZal commentedFeb 24, 2025•
edited
Loading