Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [switch-exhaustiveness-check] suggest with qualified name#10697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromyeonjuan:fix#7747
Feb 1, 2025

Conversation

yeonjuan
Copy link
Contributor

@yeonjuanyeonjuan commentedJan 22, 2025•
edited
Loading

PR Checklist

Overview

This pr addresses#7747.
The defaultTypeFormatFlags for thetypeToString method isAllowUniqueESSymbolType | UseAliasDefinedOutsideCurrentScope.
This pr addsUseFullyQualifiedType to change the type to a qualified name.

functiontypeToString(type:Type,enclosingDeclaration?:Node,flags:TypeFormatFlags=TypeFormatFlags.AllowUniqueESSymbolType|TypeFormatFlags.UseAliasDefinedOutsideCurrentScope,// ...):string{constnoTruncation=

https://github.com/microsoft/TypeScript/blob/1c4083f4edc71cb1744a62013732e3c95d05a035/src/compiler/types.ts#L5538-L5540

UseFullyQualifiedType=1<<6,// Write out the fully qualified type name (eg. Module.Type, instead of Type)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 22, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita5414c3
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6790ea871a787e0008d99ea9
😎 Deploy Previewhttps://deploy-preview-10697--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 85 (🔴 down 13 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJan 22, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commita5414c3.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded24sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-01-28 20:01:38 UTC

@codecovCodecov
Copy link

codecovbot commentedJan 22, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base(79af426) to head(a5414c3).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10697   +/-   ##=======================================  Coverage   87.17%   87.17%           =======================================  Files         448      448             Lines       15598    15599    +1       Branches     4555     4555           =======================================+ Hits        13597    13598    +1  Misses       1645     1645             Partials      356      356
FlagCoverage Δ
unittest87.17% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...nt-plugin/src/rules/switch-exhaustiveness-check.ts98.93% <100.00%> (+0.01%)⬆️

@yeonjuanyeonjuan marked this pull request as ready for reviewJanuary 22, 2025 15:23
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJan 28, 2025
@JoshuaKGoldbergJoshuaKGoldberg merged commitac79d01 intotypescript-eslint:mainFeb 1, 2025
71 of 73 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestFeb 5, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 || npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))##### 🩹 Fixes-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))##### ❤️ Thank You-   Josh Goldberg ✨-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ryan Poon [@sopa301](https://github.com/sopa301)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestFeb 5, 2025
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.22.0 | 8.23.0 || npm        | @typescript-eslint/parser        | 8.22.0 | 8.23.0 |## [v8.23.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8230-2025-02-03)##### 🚀 Features-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] enforce strictNullChecks ([#10712](typescript-eslint/typescript-eslint#10712))##### 🩹 Fixes-   **eslint-plugin:** \[no-shadow] ignore declare variables in definition files shadowing global variables ([#10710](typescript-eslint/typescript-eslint#10710))-   **eslint-plugin:** \[no-restricted-imports] support regex option ([#10699](typescript-eslint/typescript-eslint#10699))-   **eslint-plugin:** \[dot-notation] handle noPropertyAccessFromIndexSignature true ([#10644](typescript-eslint/typescript-eslint#10644))-   **eslint-plugin:** \[prefer-nullish-coalescing] fix missing return ([#10732](typescript-eslint/typescript-eslint#10732))-   bump ts-api-utils to ^2.0.1 ([#10761](typescript-eslint/typescript-eslint#10761))-   **eslint-plugin:** \[no-unnecessary-template-expression] allow interpolating type parameter in type context ([#10739](typescript-eslint/typescript-eslint#10739))-   **eslint-plugin:** \[switch-exhaustiveness-check] suggest with qualified name ([#10697](typescript-eslint/typescript-eslint#10697))-   **eslint-plugin:** \[no-unnecessary-type-assertion] should report readonly class properties with a literal initializer ([#10618](typescript-eslint/typescript-eslint#10618))##### ❤️ Thank You-   Josh Goldberg ✨-   Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal)-   Ryan Poon [@sopa301](https://github.com/sopa301)-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [switch-exhaustiveness-check] Enum cases are not properly qualified in fixer
3 participants
@yeonjuan@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp