typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

feat(types): add strict`parent` types for function-declaration, default-export and named-export nodes#10685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromronami:add-strict-parent-types

Jan 28, 2025

Merged

feat(types): add strict`parent` types for function-declaration, default-export and named-export nodes#10685

JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromronami:add-strict-parent-types

Jan 28, 2025

Conversation

Copy link

Member

ronami commentedJan 19, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: add strictparent types for nodes that have well-defined parents #10682
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#10682, follows#9560 up, and adds strictparent types for the proposed changes.

add strict parent types for function declaration and export named/def…

b8f3b9e

…ault nodes

Copy link

Contributor

typescript-eslintbot commentedJan 19, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 19, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`b8f3b9e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/678d6f5cfd2d4300084f4590
😎 Deploy Preview	https://deploy-preview-10685--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 19, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitb8f3b9e.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	1s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️Nx Cloud last updated this comment at2025-01-23 14:21:55 UTC

Copy link

nx-cloudbot commentedJan 19, 2025

View yourCI Pipeline Execution ↗ for commitb8f3b9e.

Command	Status	Duration	Result
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️Nx Cloud last updated this comment at2025-01-19 21:33:09 UTC

ronami marked this pull request as ready for review

January 19, 2025 21:50

JoshuaKGoldberg approved these changes

Jan 23, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🆒

packages/types/src/ts-estree.ts

		@@ -72,6 +72,34 @@ declare module './generated/ast-spec' {
		\| TSESTree.ImportDeclaration;
		}

		interface ExportDefaultDeclaration {
		parent: TSESTree.BlockStatement \| TSESTree.Program \| TSESTree.TSModuleBlock;

Copy link

Member

JoshuaKGoldbergJan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TSESTree.BlockStatement

TIL this does parse correctly despite the compiler complaint. Nifty.

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jan 23, 2025

JoshuaKGoldberg merged commita0c30f2 intotypescript-eslint:main

Jan 28, 2025

68 checks passed

ronami deleted the add-strict-parent-types branch

January 28, 2025 19:53

github-actionsbot locked asresolvedand limited conversation to collaborators

Feb 5, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(types): add strict`parent` types for function-declaration, default-export and named-export nodes#10685

feat(types): add strict`parent` types for function-declaration, default-export and named-export nodes#10685

Uh oh!

Conversation

ronami commentedJan 19, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 19, 2025

Uh oh!

netlifybot commentedJan 19, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 19, 2025•
edited
Loading

Uh oh!