Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(typescript-estree): migrate fromjest tovitest#10679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

kirkwaiblinger reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 18, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitd043fbe
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67fd10a9ce9ca20008c365ad
😎 Deploy Previewhttps://deploy-preview-10679--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 97 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJan 18, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commitd043fbe.

CommandStatusDurationResult
nx test parser✅ Succeeded9sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx typecheck ast-spec✅ Succeeded5sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded1m 9sView ↗
nx run scope-manager:test -- --coverage✅ Succeeded12sView ↗
nx run-many --target=clean✅ Succeeded19sView ↗
nx test utils✅ Succeeded13sView ↗
nx run typescript-eslint:test -- --coverage✅ Succeeded3sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-04-14 14:21:22 UTC

@nx-cloudNx Cloud
Copy link

View yourCI Pipeline Execution ↗ for commitc401e63.

CommandStatusDurationResult
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-01-18 14:24:50 UTC

@codecovCodecov
Copy link

codecovbot commentedJan 18, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.20%. Comparing base(deacba9) to head(d043fbe).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10679      +/-   ##==========================================- Coverage   86.44%   81.20%   -5.24%==========================================  Files         497      498       +1       Lines       19056    22927    +3871       Branches     4806     4985     +179     ==========================================+ Hits        16473    18618    +2145- Misses       2285     4113    +1828+ Partials      298      196     -102
FlagCoverage Δ
unittest81.20% <ø> (-5.24%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aryaemami59aryaemami59force-pushed thechore/typescript-estree-vitest-migration branch 3 times, most recently from3da52df toaeae2f8CompareJanuary 21, 2025 17:21
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome progress! Really exciting to see a Vitest success report runningyarn test locally. 🔥

Left some questions - I think most of the blockers are around _"why?"_s.

@aryaemami59aryaemami59force-pushed thechore/typescript-estree-vitest-migration branch 2 times, most recently from8b6d927 to4a4d5e7CompareJanuary 29, 2025 11:31
@aryaemami59aryaemami59force-pushed thechore/typescript-estree-vitest-migration branch 17 times, most recently from0fca021 tof66900dCompareFebruary 3, 2025 15:51
@JoshuaKGoldbergJoshuaKGoldberg mentioned this pull requestJan 28, 2025
14 tasks
@JoshuaKGoldbergJoshuaKGoldberg merged commitdfe51af intotypescript-eslint:mainApr 14, 2025
58 of 59 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsApr 22, 2025
@aryaemami59aryaemami59 deleted the chore/typescript-estree-vitest-migration branchApril 23, 2025 00:18
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@aryaemami59@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp