Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-deprecated] should allow ignoring of deprecated value#10670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

y-hsgw
Copy link
Contributor

@y-hsgwy-hsgw commentedJan 17, 2025•
edited
Loading

PR Checklist

Overview

I have created avalueMatchesSomeSpecifier function to check if a value matches the specified specifiers. However, this implementation might only cover the specific case related to the bug in this issue.
If you have any advice or suggestions, please feel free to share.

💪

lishaduck reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 17, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3b3b72a
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/686bc373a1876600085d8da2
😎 Deploy Previewhttps://deploy-preview-10670--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (no change from production)
Accessibility: 97 (🔴 down 3 from production)
Best Practices: 100 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJan 17, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3b3b72a

CommandStatusDurationResult
nx test eslint-plugin-internal --coverage=false❌ Failed11sView ↗
nx run-many -t lint✅ Succeeded3m 16sView ↗
nx run-many -t typecheck✅ Succeeded2m 14sView ↗
nx run integration-tests:test✅ Succeeded5sView ↗
nx run types:build✅ Succeeded5sView ↗
nx test typescript-estree --coverage=false✅ Succeeded1sView ↗
nx run generate-configs✅ Succeeded6sView ↗
nx run-many --target=build --parallel --exclude...✅ Succeeded22sView ↗
Additional runs (26)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-07-07 13:05:11 UTC

@codecovCodecov
Copy link

codecovbot commentedJan 17, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(5e3288a) to head(3b3b72a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main   #10670      +/-   ##==========================================+ Coverage   90.84%   90.85%   +0.01%==========================================  Files         501      501                Lines       50919    50978      +59       Branches     8387     8407      +20     ==========================================+ Hits        46256    46315      +59  Misses       4648     4648                Partials       15       15
FlagCoverage Δ
unittest90.85% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts96.98% <100.00%> (+0.02%)⬆️
packages/type-utils/src/TypeOrValueSpecifier.ts100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJan 17, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✨

y-hsgw reacted with laugh emoji
@JoshuaKGoldbergJoshuaKGoldberg dismissed theirstale reviewJanuary 17, 2025 13:06

Whoops, wrong button, sorry for the noise :)

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for sending this in! 💪

Codecov is right to report, we have tests set up inpackages/type-utils to make sure these utils are fully unit tested. Could you please add tests toTypeOrValueSpecifier.test.ts?

All three of the specifier sources formats should be tested: file, lib, and package.

y-hsgw reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 23, 2025
@y-hsgw
Copy link
ContributorAuthor

y-hsgw commentedJan 25, 2025•
edited
Loading

I've added the tests!
Is the behavior ofvalueMatchesSpecifier as expected whenspecifier.from is set topackage?
I would appreciate it if you could verify whether the logic ofvalueMatchesSpecifier itself is correct. 🙇‍♂️
Do you think it might be necessary to verify whether it is imported from a package?

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelJan 25, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you think it might be necessary to verify whether it is imported from a package?

Indeed I do - the goal of the shared format is to match on both the nameand where a type/value is declared.

Thanks!

y-hsgw reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 24, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 27, 2025
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A bit more complication! 🚀

I'm also starting to wonder - maybe it makes sense to unify thetypeMatchesSpecifier andvalueMatchesSpecifier logic? If the value checking needs type information anyway...

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelMar 17, 2025
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelApr 11, 2025
Copy link
Member

@kirkwaiblingerkirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is in good shape!

@JoshuaKGoldberg

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great, thank you! 🙌 I'm very excited to see this land.

y-hsgw reacted with rocket emoji
returntypeofspecifierName==='string' ?[specifierName] :specifierName;
};

constgetStaticName=(node:TSESTree.Node):string|undefined=>{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Non-Actionable] I'm surprised we don't already have a function like this somewhere 😄. I spent a bit searching and couldn't find one. The closest wasgetNameFromMember over ineslint-plugin but it's not quite the same. Ah well.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJul 7, 2025
@JoshuaKGoldberg
Copy link
Member

The CI unit testing failure is unrelated flake.

@JoshuaKGoldbergJoshuaKGoldberg merged commitd1388fc intotypescript-eslint:mainJul 7, 2025
62 of 64 checks passed
@y-hsgwy-hsgw deleted the fix/no-deprecated branchJuly 7, 2025 13:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-deprecated] should allow ignoring of deprecated value
3 participants
@y-hsgw@JoshuaKGoldberg@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp