I have created avalueMatchesSomeSpecifier function to check if a value matches the specified specifiers. However, this implementation might only cover the specific case related to the bug in this issue.
If you have any advice or suggestions, please feel free to share.

💪

y-hsgw added3 commits

January 17, 2025 21:20

feat: create valueMatchesSomeSpecifier function

38e69ff

fix: ignore deprecated value

ae6e55a

test: add test

36d8055

Copy link

Contributor

typescript-eslintbot commentedJan 17, 2025

Thanks for the PR,@y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 17, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3b3b72a`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/686bc373a1876600085d8da2
😎 Deploy Preview	https://deploy-preview-10670--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 97 (🔴 down 3 from production) Best Practices: 100 (no change from production) SEO: 92 (🔴 down 8 from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link

nx-cloudbot commentedJan 17, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit3b3b72a

Command	Status	Duration	Result
`nx test eslint-plugin-internal --coverage=false`	❌ Failed	11s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 16s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	2m 14s	View ↗
`nx run integration-tests:test`	✅ Succeeded	5s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	1s	View ↗
`nx run generate-configs`	✅ Succeeded	6s	View ↗
`nx run-many --target=build --parallel --exclude...`	✅ Succeeded	22s	View ↗
`Additional runs (26)`	✅ Succeeded	...	View ↗

☁️Nx Cloud last updated this comment at2025-07-07 13:05:11 UTC

Copy link

codecovbot commentedJan 17, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.85%. Comparing base(5e3288a) to head(3b3b72a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10670      +/-   ##==========================================+ Coverage   90.84%   90.85%   +0.01%==========================================  Files         501      501                Lines       50919    50978      +59       Branches     8387     8407      +20     ==========================================+ Hits        46256    46315      +59  Misses       4648     4648                Partials       15       15

Flag	Coverage Δ
unittest	`90.85% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`96.98% <100.00%> (+0.02%)`	⬆️
packages/type-utils/src/TypeOrValueSpecifier.ts	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg previously approved these changes

Jan 17, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✨

JoshuaKGoldberg dismissed theirstale review

January 17, 2025 13:06

Whoops, wrong button, sorry for the noise :)

JoshuaKGoldberg requested changes

Jan 23, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for sending this in! 💪

Codecov is right to report, we have tests set up inpackages/type-utils to make sure these utils are fully unit tested. Could you please add tests toTypeOrValueSpecifier.test.ts?

All three of the specifier sources formats should be tested: file, lib, and package.

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 23, 2025

test: add test

d545ea1

Copy link

ContributorAuthor

y-hsgw commentedJan 25, 2025•
edited
Loading

I've added the tests!
Is the behavior ofvalueMatchesSpecifier as expected whenspecifier.from is set topackage?
I would appreciate it if you could verify whether the logic ofvalueMatchesSpecifier itself is correct. 🙇‍♂️
Do you think it might be necessary to verify whether it is imported from a package?

y-hsgw requested a review fromJoshuaKGoldberg

January 25, 2025 08:00

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 25, 2025

JoshuaKGoldberg requested changes

Feb 24, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you think it might be necessary to verify whether it is imported from a package?

Indeed I do - the goal of the shared format is to match on both the nameand where a type/value is declared.

Thanks!

packages/type-utils/src/TypeOrValueSpecifier.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Feb 24, 2025

y-hsgw added3 commits

February 27, 2025 23:18

refactor: use AST node narrowing

a4463a4

feat: support package

95839f6

test: add test

b80196b

y-hsgw requested a review fromJoshuaKGoldberg

February 27, 2025 14:39

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Feb 27, 2025

y-hsgwand others added8 commits

February 27, 2025 23:51

Merge branch 'main' ofhttps://github.com/y-hsgw/typescript-eslintin…

4f7a71e

…to fix/no-deprecated

Merge branch 'main' ofhttps://github.com/y-hsgw/typescript-eslintin…

5b7b20d

…to fix/no-deprecated

test: add test

af4be16

Merge branch 'main' into fix/no-deprecated

064f92d

test: add test for typeMatchesSomeSpecifier function

3567212

test: add test for valueMatchesSomeSpecifier function

1cd8ea6

refactor: remove default empty array from specifiers

3673d21

Revert "refactor: remove default empty array from specifiers"

325e132

This reverts commit3673d21.

y-hsgwand others added3 commits

March 13, 2025 20:34

test: add test case with undefined argument

767fc7a

Merge branch 'main' into fix/no-deprecated

e1c4670

fix: sync workspace

54f820b

JoshuaKGoldberg requested changes

Mar 17, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A bit more complication! 🚀

I'm also starting to wonder - maybe it makes sense to unify thetypeMatchesSpecifier andvalueMatchesSpecifier logic? If the value checking needs type information anyway...

packages/type-utils/src/TypeOrValueSpecifier.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Mar 17, 2025

y-hsgw added4 commits

March 21, 2025 18:30

feat: support PrivateIdentifier

3b3520b

feat: support literal case

0e61bcf

feat: support dynamic import

1578137

test: add no-deprecated test

d65268c

y-hsgw requested a review fromJoshuaKGoldberg

April 11, 2025 12:38

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Apr 11, 2025

y-hsgw added4 commits

April 11, 2025 21:41

fix: sync workspace

72641c0

Merge branch 'main' ofhttps://github.com/y-hsgw/typescript-eslintin…

8fca2c2

…to fix/no-deprecated

refactor: use named functions instead of string descriptions in descr…

7e6b840

…ibe blocks

fix: lint fix

8ef57d2

kirkwaiblinger approved these changes

Jul 6, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this is in good shape!

@JoshuaKGoldberg

Merge branch 'main' into fix/no-deprecated

3b3b72a

JoshuaKGoldberg approved these changes

Jul 7, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great, thank you! 🙌 I'm very excited to see this land.

packages/type-utils/src/TypeOrValueSpecifier.ts

		return typeof specifierName === 'string' ? [specifierName] : specifierName;
		};

		const getStaticName = (node: TSESTree.Node): string \| undefined => {

Copy link

Member

JoshuaKGoldbergJul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Non-Actionable] I'm surprised we don't already have a function like this somewhere 😄. I spent a bit searching and couldn't find one. The closest wasgetNameFromMember over ineslint-plugin but it's not quite the same. Ah well.