Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [no-deprecated] should allow ignoring of deprecated value#10670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Thanks for the PR,@y-hsgw! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJan 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify project configuration. |
nx-cloudbot commentedJan 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
View yourCI Pipeline Execution ↗ for commit3b3b72a
☁️Nx Cloud last updated this comment at |
codecovbot commentedJan 17, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #10670 +/- ##==========================================+ Coverage 90.84% 90.85% +0.01%========================================== Files 501 501 Lines 50919 50978 +59 Branches 8387 8407 +20 ==========================================+ Hits 46256 46315 +59 Misses 4648 4648 Partials 15 15
Flags with carried forward coverage won't be shown.Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
✨
Whoops, wrong button, sorry for the noise :)
JoshuaKGoldberg left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for sending this in! 💪
Codecov is right to report, we have tests set up inpackages/type-utils
to make sure these utils are fully unit tested. Could you please add tests toTypeOrValueSpecifier.test.ts
?
All three of the specifier sources formats should be tested: file, lib, and package.
y-hsgw commentedJan 25, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've added the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you think it might be necessary to verify whether it is imported from a package?
Indeed I do - the goal of the shared format is to match on both the nameand where a type/value is declared.
Thanks!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A bit more complication! 🚀
I'm also starting to wonder - maybe it makes sense to unify thetypeMatchesSpecifier
andvalueMatchesSpecifier
logic? If the value checking needs type information anyway...
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is in good shape!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is great, thank you! 🙌 I'm very excited to see this land.
returntypeofspecifierName==='string' ?[specifierName] :specifierName; | ||
}; | ||
constgetStaticName=(node:TSESTree.Node):string|undefined=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[Non-Actionable] I'm surprised we don't already have a function like this somewhere 😄. I spent a bit searching and couldn't find one. The closest wasgetNameFromMember
over ineslint-plugin
but it's not quite the same. Ah well.
The CI unit testing failure is unrelated flake. |
d1388fc
intotypescript-eslint:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
I have created a
valueMatchesSomeSpecifier
function to check if a value matches the specified specifiers. However, this implementation might only cover the specific case related to the bug in this issue.If you have any advice or suggestions, please feel free to share.
💪