This PR addresses#10632 and fixes the rule so it does not fail on recursive array or tuple types. It looks like this regression has been introduced in#10437.

Not directly related: It seems not intentional, but since#10437, the rule reports invalid nested array types (which it didn't previously):

declareconsts:{foo:'bar'}[][];// [object Object]s.join();

Previously, the array check (which used to run only onarray.join()) never checked for nested array types. This changed on#10437, and the recursive check also runs as part ofarray.join() (which means the crash reproduces on recursivearray.join() too,playground link).

There's no test that checks this behavior (which I think is intended), so I've added a couple of tests for this. Please let me know if this isn't intended behavior or if this should be done on a separate PR.

don't crash for recursive array or tuple types

fbeb999

Copy link

Contributor

typescript-eslintbot commentedJan 7, 2025

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 7, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`75d2265`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/678d3a98bd72c4000823d20e
😎 Deploy Preview	https://deploy-preview-10633--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedJan 7, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit75d2265.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	5s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-01-20 09:10:41 UTC

Copy link

codecovbot commentedJan 7, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base(b17c7f2) to head(75d2265).
Report is 31 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10633      +/-   ##==========================================+ Coverage   86.94%   87.16%   +0.21%==========================================  Files         446      448       +2       Lines       15508    15585      +77       Branches     4518     4552      +34     ==========================================+ Hits        13484    13584     +100+ Misses       1669     1645      -24- Partials      355      356       +1

Flag	Coverage Δ
unittest	`87.16% <100.00%> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`97.24% <100.00%> (+0.18%)`	⬆️

... and96 files with indirect coverage changes

ronami marked this pull request as ready for review

January 7, 2025 23:13

ronami marked this pull request as draft

January 7, 2025 23:41

ronami added2 commits

January 8, 2025 18:54

testing adjustments

5b74c62

change test

ea7e77c

ronami commented

Jan 8, 2025

View reviewed changes

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

Comment on lines +499 to +502

		type Value = Value[];
		declare const v: Value;

		String(v);

Copy link

MemberAuthor

ronamiJan 8, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To my understanding, types like this are valid to stringify.

change test

24da033

ronami marked this pull request as ready for review

January 8, 2025 17:08

kirkwaiblinger reviewed

Jan 19, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-base-to-string.tsShow resolvedHide resolved

simplify passing of 'visited' for array-join

75d2265

kirkwaiblinger approved these changes

Jan 20, 2025

View reviewed changes

Copy link

Member

kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

kirkwaiblinger added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jan 20, 2025

JoshuaKGoldberg approved these changes

Jan 20, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg merged commit1895948 intotypescript-eslint:main

Jan 20, 2025

63 of 64 checks passed

ronami deleted the no-base-to-string-call-stack branch

January 20, 2025 15:15

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 21, 2025

fix(deps): update typescript-eslint monorepo to v8.21.0

d1802c3

##### [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 21, 2025

fix(deps): update typescript-eslint monorepo to v8.21.0

98ad0dd

##### [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Jan 24, 2025

Update typescript-eslint monorepo to v8.21.0

8ce0dbb

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.20.0 | 8.21.0 || npm        | @typescript-eslint/parser        | 8.20.0 | 8.21.0 |## [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Jan 24, 2025

Update typescript-eslint monorepo to v8.21.0

c29f123

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.20.0 | 8.21.0 || npm        | @typescript-eslint/parser        | 8.20.0 | 8.21.0 |## [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Jan 28, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-base-to-string] don't crash for recursive array or tuple types#10633

fix(eslint-plugin): [no-base-to-string] don't crash for recursive array or tuple types#10633

Conversation

ronami commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 7, 2025

Uh oh!

netlifybot commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ronamiJan 8, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ronami commentedJan 7, 2025•
edited
Loading

netlifybot commentedJan 7, 2025•
edited
Loading

nx-cloudbot commentedJan 7, 2025•
edited
Loading

codecovbot commentedJan 7, 2025•
edited
Loading

ronamiJan 8, 2025•
edited
Loading