typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromyeonjuan:fixes/10629

Jan 15, 2025

Merged

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromyeonjuan:fixes/10629

Jan 15, 2025

Conversation

Copy link

Contributor

yeonjuan commentedJan 7, 2025•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [no-unnecessary-type-arguments] False negative on JSX #10629
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args …

6bb20ed

…on jsx

Copy link

Contributor

typescript-eslintbot commentedJan 7, 2025

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

yeonjuan changed the title~~fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args …~~fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx

Jan 7, 2025

Copy link

nx-cloudbot commentedJan 7, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit672f533.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	5s	View ↗
`nx run-many --target=clean`	✅ Succeeded	10s	View ↗

☁️Nx Cloud last updated this comment at2025-01-13 17:35:56 UTC

Copy link

netlifybot commentedJan 7, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`672f533`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6781045d11e5c6000875e86f
😎 Deploy Preview	https://deploy-preview-10630--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 83 (🔴 down 10 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

yeonjuan mentioned this pull request

Jan 7, 2025

Bug: [no-unnecessary-type-arguments] False negative on JSX#10629

Closed

4 tasks

yeonjuan marked this pull request as ready for review

January 7, 2025 18:46

ronami requested changes

Jan 10, 2025

View reviewed changes

Copy link

Member

ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great to me! Requesting minor changes around self-closing JSX elements! 👍

packages/eslint-plugin/tests/rules/no-unnecessary-type-arguments.test.tsShow resolvedHide resolved

ronami added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 10, 2025

apply review

672f533

Copy link

codecovbot commentedJan 10, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.94%. Comparing base(c7154bf) to head(672f533).
Report is 25 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10630      +/-   ##==========================================+ Coverage   86.90%   86.94%   +0.03%==========================================  Files         446      446                Lines       15508    15508                Branches     4518     4518              ==========================================+ Hits        13478    13484       +6+ Misses       1675     1669       -6  Partials      355      355

Flag	Coverage Δ
unittest	`86.94% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...-plugin/src/rules/no-unnecessary-type-arguments.ts	`97.29% <ø> (ø)`

... and6 files with indirect coverage changes

ronami approved these changes

Jan 13, 2025

View reviewed changes

Copy link

Member

ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you 🚀

ronami added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labels

Jan 13, 2025

JoshuaKGoldberg merged commit3dbcc19 intotypescript-eslint:main

Jan 15, 2025

65 of 66 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 21, 2025

fix(deps): update typescript-eslint monorepo to v8.21.0

d1802c3

##### [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 21, 2025

fix(deps): update typescript-eslint monorepo to v8.21.0

98ad0dd

##### [v8.21.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8210-2025-01-20)##### 🩹 Fixes-   **eslint-plugin:** \[no-duplicate-enum-values] handle template literal ([#10675](typescript-eslint/typescript-eslint#10675))-   **eslint-plugin:** \[no-base-to-string] don't crash for recursive array or tuple types ([#10633](typescript-eslint/typescript-eslint#10633))-   **eslint-plugin:** \[no-for-in-array] report on any type which may be an array or array-like ([#10535](typescript-eslint/typescript-eslint#10535))-   **eslint-plugin:** check JSX spread elements for misused spread usage ([#10653](typescript-eslint/typescript-eslint#10653))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type args on jsx ([#10630](typescript-eslint/typescript-eslint#10630))##### ❤️ Thank You-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Jan 23, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

Uh oh!

Conversation

yeonjuan commentedJan 7, 2025•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 7, 2025

Uh oh!

nx-cloudbot commentedJan 7, 2025•
edited
Loading

Uh oh!

Uh oh!

netlifybot commentedJan 7, 2025•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecovbot commentedJan 10, 2025•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx#10630

Uh oh!

Conversation

yeonjuan commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedJan 7, 2025

Uh oh!

nx-cloudbot commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

netlifybot commentedJan 7, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecovbot commentedJan 10, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedJan 7, 2025•
edited
Loading

nx-cloudbot commentedJan 7, 2025•
edited
Loading

netlifybot commentedJan 7, 2025•
edited
Loading

codecovbot commentedJan 10, 2025•
edited
Loading