Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(eslint-plugin): no-confusing-void-expressiongetConstraintInfo#10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
43081j wants to merge1 commit intotypescript-eslint:main
base:main
Choose a base branch
Loading
from43081j:gci-fun-1

Conversation

43081j
Copy link
Contributor

Moves to usinggetConstraintInfo internally in theno-confusing-void-expression rule.

Also fixes a bug this uncovered, whereAwaitExpression nodes were actually untested and not supported in the type constraint checks.

This is because we passednode (theAwaitExpression itself), rather than the thing being awaited (node.argument). By passing theargument, we check its type instead.

PR Checklist

Moves to using `getConstraintInfo` internally in the`no-confusing-void-expression` rule.Also fixes a bug this uncovered, where `AwaitExpression` nodes wereactually untested and not supported in the type constraint checks.This is because we passed `node` (the `AwaitExpression` itself), ratherthan the thing being awaited (`node.argument`). By passing the`argument`, we check its type instead.
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 1, 2025•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit59a8b4a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/67753ddc10a8ea0008baf09e
😎 Deploy Previewhttps://deploy-preview-10586--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedJan 1, 2025•
edited
Loading

View yourCI Pipeline Execution ↗ for commit59a8b4a.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded4sView ↗
nx run-many --target=clean✅ Succeeded10sView ↗

☁️Nx Cloud last updated this comment at2025-01-04 17:23:21 UTC

@codecovCodecov
Copy link

codecovbot commentedJan 1, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base(4dbf48b) to head(59a8b4a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10586   +/-   ##=======================================  Coverage   86.90%   86.90%           =======================================  Files         446      446             Lines       15502    15508    +6       Branches     4516     4519    +3     =======================================+ Hits        13472    13478    +6  Misses       1675     1675             Partials      355      355
FlagCoverage Δ
unittest86.90% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts100.00% <100.00%> (ø)

@kirkwaiblinger
Copy link
Member

#10603 (comment)

@kirkwaiblingerkirkwaiblinger added the blocked by another issueIssues which are not ready because another issue needs to be resolved first labelJan 4, 2025
@kirkwaiblingerkirkwaiblinger marked this pull request as draftJanuary 4, 2025 17:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked by another issueIssues which are not ready because another issue needs to be resolved first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@43081j@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp