This pr addresses#6374 and addsarrayLiteralTypeAssertions option to theconsistent-type-assertions rule.
It starts from#6749, which was previously closed, and addsallow-as-parameter to thearrayLiteralTypeAssertions option. (#6749 (comment))

Co-authored-by:@danvk

yeonjuan added2 commits

December 29, 2024 15:41

feat(eslint-plugin): [consistent-type-assertions] add arrayLiteralTyp…

e4b6227

…eAssertions options

add docs

9dfe2e8

Copy link

Contributor

typescript-eslintbot commentedDec 29, 2024

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 29, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`f78ba99`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6780fb12864eef00086dded0
😎 Deploy Preview	https://deploy-preview-10565--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedDec 29, 2024•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf78ba99.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	3s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️Nx Cloud last updated this comment at2025-01-13 16:29:59 UTC

yeonjuan added2 commits

December 29, 2024 16:17

Update consistent-type-assertions.mdx

880789a

update snapshot

8fcf981

Copy link

codecovbot commentedDec 29, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base(3ae4148) to head(f78ba99).
Report is 38 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@##             main   #10565      +/-   ##==========================================+ Coverage   86.86%   86.96%   +0.09%==========================================  Files         445      446       +1       Lines       15455    15523      +68       Branches     4507     4524      +17     ==========================================+ Hits        13425    13499      +74+ Misses       1675     1669       -6  Partials      355      355

Flag	Coverage Δ
unittest	`86.96% <100.00%> (+0.09%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...int-plugin/src/rules/consistent-type-assertions.ts	`95.89% <100.00%> (+1.06%)`	⬆️

... and23 files with indirect coverage changes

yeonjuan marked this pull request as ready for review

December 29, 2024 10:00

yeonjuan added2 commits

December 30, 2024 19:34

fix wrong data format

7d377d1

fix

ee8a2ef

JoshuaKGoldberg requested changes

Dec 30, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lovely! The logic all makes sense and I like how the array and object checks are now mirrored. Great.

Requesting changes on some docs and testing please. 🚀

packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/docs/rules/consistent-type-assertions.mdx OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/consistent-type-assertions.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 30, 2024

yeonjuan added4 commits

December 31, 2024 14:17

review - rename getSuggests -> getSuggestions

0af07a9

review - docs

b64df60

fix tests

c3f66e5

Update consistent-type-assertions.test.ts

fdcd4ce

yeonjuan requested a review fromJoshuaKGoldberg

January 3, 2025 01:23

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 3, 2025

Copy link

ContributorAuthor

yeonjuan commentedJan 6, 2025

@JoshuaKGoldberg Thanks for the review. I fixed

JoshuaKGoldberg previously approved these changes

Jan 7, 2025

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 thanks!

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Jan 7, 2025

ronami requested changes

Jan 9, 2025

View reviewed changes

Copy link

Member

ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! Thanks for sending this in! Just requesting minor changes, mostly around testing! 🏆

packages/eslint-plugin/src/rules/consistent-type-assertions.ts Outdated

Comment on lines 254 to 256

		function isAsParameter(
		node: TSESTree.TSAsExpression \| TSESTree.TSTypeAssertion,
		): boolean {

Copy link

Member

ronamiJan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Style]: I think this can be re-used for checking theobject type'sallow-as-parameter.

packages/eslint-plugin/src/rules/consistent-type-assertions.ts


		if (
		options.arrayLiteralTypeAssertions === 'allow-as-parameter' &&
		isAsParameter(node)

Copy link

Member

ronamiJan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Testing]: This can be removed and no tests fail (&& isAsParameter(node)), I think it's important this would have a test that covers it.

packages/eslint-plugin/src/rules/consistent-type-assertions.ts

Comment on lines +258 to +264

		node.parent.type === AST_NODE_TYPES.NewExpression \|\|
		node.parent.type === AST_NODE_TYPES.CallExpression \|\|
		node.parent.type === AST_NODE_TYPES.ThrowStatement \|\|
		node.parent.type === AST_NODE_TYPES.AssignmentPattern \|\|
		node.parent.type === AST_NODE_TYPES.JSXExpressionContainer \|\|
		(node.parent.type === AST_NODE_TYPES.TemplateLiteral &&
		node.parent.parent.type === AST_NODE_TYPES.TaggedTemplateExpression)

Copy link

Member

ronamiJan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Testing]: Some of these can be removed with no tests failing, I think it would be helpful to have these covered by tests.

ronami added awaiting responseIssues waiting for a reply from the OP or another party and removed 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels

Jan 9, 2025

yeonjuan dismissedJoshuaKGoldberg’sstale review via4e9c4e2

January 10, 2025 10:39

apply review

f78ba99

yeonjuan force-pushed thefix/6374 branch from4e9c4e2 tof78ba99Compare

January 10, 2025 10:48

Copy link

ContributorAuthor

yeonjuan commentedJan 10, 2025•
edited
Loading

Thanks@ronami. I fixed it.f78ba99

ronami approved these changes

Jan 13, 2025

View reviewed changes

Copy link

Member

ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! 👍

ronami added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labels

Jan 13, 2025

JoshuaKGoldberg merged commita7fc28c intotypescript-eslint:main

Jan 13, 2025

65 of 66 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 13, 2025

fix(deps): update typescript-eslint monorepo to v8.20.0

d2732f7

##### [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 13, 2025

fix(deps): update typescript-eslint monorepo to v8.20.0

3ecaaf0

##### [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 14, 2025

fix(deps): update typescript-eslint monorepo to v8.20.0

c3ade31

##### [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Jan 15, 2025

fix(deps): update typescript-eslint monorepo to v8.20.0

60d67f1

##### [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Jan 15, 2025

Update typescript-eslint monorepo to v8.20.0

4f95ad9

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.19.1 | 8.20.0 || npm        | @typescript-eslint/parser        | 8.19.1 | 8.20.0 |## [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Jan 15, 2025

Update typescript-eslint monorepo to v8.20.0

15fda57

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.19.1 | 8.20.0 || npm        | @typescript-eslint/parser        | 8.19.1 | 8.20.0 |## [v8.20.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8200-2025-01-13)##### 🚀 Features-   **eslint-plugin:** \[consistent-type-assertions] add arrayLiteralTypeAssertions options ([#10565](typescript-eslint/typescript-eslint#10565))-   **eslint-plugin:** \[no-deprecated] add allow options ([#10585](typescript-eslint/typescript-eslint#10585))-   **eslint-plugin:** \[no-misused-spread] add new rule ([#10551](typescript-eslint/typescript-eslint#10551))##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] don't flag optional chaining for union types with an unconstrained type parameters ([#10602](typescript-eslint/typescript-eslint#10602))-   **eslint-plugin:** \[no-shadow] ignore ordering of type declarations ([#10593](typescript-eslint/typescript-eslint#10593))##### ❤️ Thank You-   Josh Goldberg ✨-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

huuyafwww mentioned this pull request

Jan 20, 2025

Update packageshuuyafwww/eslint-config#29

Merged

github-actionsbot locked asresolvedand limited conversation to collaborators

Jan 21, 2025

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

3 participants

		node.parent.type === AST_NODE_TYPES.NewExpression \|\|
		node.parent.type === AST_NODE_TYPES.CallExpression \|\|
		node.parent.type === AST_NODE_TYPES.ThrowStatement \|\|
		node.parent.type === AST_NODE_TYPES.AssignmentPattern \|\|
		node.parent.type === AST_NODE_TYPES.JSXExpressionContainer \|\|
		(node.parent.type === AST_NODE_TYPES.TemplateLiteral &&
		node.parent.parent.type === AST_NODE_TYPES.TaggedTemplateExpression)

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [consistent-type-assertions] add arrayLiteralTypeAssertions options#10565

feat(eslint-plugin): [consistent-type-assertions] add arrayLiteralTypeAssertions options#10565

Uh oh!

Conversation

yeonjuan commentedDec 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedDec 29, 2024

Uh oh!

netlifybot commentedDec 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedDec 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

codecovbot commentedDec 29, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedJan 6, 2025

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

ronamiJan 9, 2025

Choose a reason for hiding this comment

Uh oh!

ronamiJan 9, 2025

Choose a reason for hiding this comment

Uh oh!

ronamiJan 9, 2025

Choose a reason for hiding this comment

Uh oh!

yeonjuan commentedJan 10, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yeonjuan commentedDec 29, 2024•
edited
Loading

netlifybot commentedDec 29, 2024•
edited
Loading

nx-cloudbot commentedDec 29, 2024•
edited
Loading

codecovbot commentedDec 29, 2024•
edited
Loading

yeonjuan commentedJan 10, 2025•
edited
Loading