Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: export all Options and MessageIds types from rule files#10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 26, 2024•
edited
Loading

PR Checklist

Overview

Doesn't exportall types that will be flagged by#10554. I think it'll still be useful to make sure the PR's added rule correctly flags internal violations.

💖

ronami reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 26, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitc5f6e40
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/677d48b211bbf20008f7e3a4
😎 Deploy Previewhttps://deploy-preview-10556--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedDec 26, 2024•
edited
Loading

View yourCI Pipeline Execution ↗ for commitc5f6e40.

CommandStatusDurationResult
nx test eslint-plugin --coverage=false✅ Succeeded7m 13sView ↗
nx test eslint-plugin✅ Succeeded5m 59sView ↗
nx test type-utils --coverage=false✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test typescript-eslint --coverage=false✅ Succeeded9sView ↗
nx test visitor-keys --coverage=false✅ Succeeded<1sView ↗
nx test utils --coverage=false✅ Succeeded<1sView ↗
nx run-many --target=build --exclude website --...✅ Succeeded29sView ↗
Additional runs (24)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-01-07 15:46:09 UTC

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewJanuary 3, 2025 04:55
Copy link
Member

@ronamironami left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think these rules have been missed:

Also, these two rules, which don't export theirOptions, or export a slightly differentOptions type than the one they use:

JoshuaKGoldberg reacted with thumbs up emoji
Copy link
Member

@ronamironami left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🏆

@JoshuaKGoldbergJoshuaKGoldberg merged commitb17c7f2 intotypescript-eslint:mainJan 7, 2025
61 checks passed
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ronamironamironami approved these changes

@kirkwaiblingerkirkwaiblingerkirkwaiblinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Export all rule Options and MessageId types
3 participants
@JoshuaKGoldberg@ronami@kirkwaiblinger
[8]ページ先頭
©2009-2025 Movatter.jp