Jan 13, 2025 · Feb 19, 2024 · Feb 19, 2024 · Feb 19, 2024 · Feb 19, 2024 · Feb 20, 2024
diff --git a/packages/eslint-plugin/docs/rules/no-misused-spread.mdx b/packages/eslint-plugin/docs/rules/no-misused-spread.mdx
 ---
 description: 'Disallow using the spread operator when it might cause unexpected behavior.'
 ---

 import Tabs from '@theme/Tabs';
 import TabItem from '@theme/TabItem';

 > 🛑 This file is source code, not the primary documentation location! 🛑
 >
 > See **https://typescript-eslint.io/rules/no-misused-spread** for documentation.

 [Spread syntax](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax) (`...`) is a JavaScript feature for creating an object with the joined properties of one or more other objects.
 TypeScript allows spreading objects whose properties are not typically meant to be enumerated, such as arrays and class instances.

 This rule disallows using the spread syntax on values whose types indicate doing so may cause unexpected behavior.
 That includes the following cases:

 - Spreading a `Promise` into an object.
  You probably meant to `await` it.
 - Spreading a function without properties into an object.
  You probably meant to call it.
 - Spreading an iterable (`Array`, `Map`, etc.) into an object.
  Iterable objects usually do not have meaningful enumerable properties and you probably meant to spread it into an array instead.
 - Spreading a string into an array.
  String enumeration behaviors in JavaScript around encoded characters are often surprising.
 - Spreading a `class` into an object.
  This copies all static own properties of the class, but none of the inheritance chain.
 - Spreading a class instance into an object.
  This does not faithfully copy the instance because only its own properties are copied, but the inheritance chain is lost, including all its methods.

 ## Examples

 <Tabs>
 <TabItem value="❌ Incorrect">

 ```ts
 declare const promise: Promise<number>;
 const spreadPromise = { ...promise };

 declare function getObject(): Record<string, strings>;
 const getObjectSpread = { ...getObject };

 declare const map: Map<string, number>;
 const mapSpread = { ...map };

 declare const userName: string;
 const characters = [...userName];
 ```

 ```ts
 declare class Box {
  value: number;
 }
 const boxSpread = { ...Box };

 declare const instance: Box;
 const instanceSpread = { ...box };
 ```

 </TabItem>
 <TabItem value="✅ Correct">

 ```ts
 declare const promise: Promise<number>;
 const spreadPromise = { ...(await promise) };

 declare function getObject(): Record<string, strings>;
 const getObjectSpread = { ...getObject() };

 declare const map: Map<string, number>;
 const mapObject = Object.fromEntries(map);

 declare const userName: string;
 const characters = userName.split('');
 ```

 </TabItem>
 </Tabs>

 ## Options

 ### `allow`

 {/* insert option description */}

 This option takes the shared [`TypeOrValueSpecifier` format](/packages/type-utils/type-or-value-specifier).

 Examples of a configuration for this option in a `file.ts` file:

 ```json
 "@typescript-eslint/no-misused-spread": [
  "error",
  {
    "allow": [
      { "from": "file", "name": "BrandedString", "path": "file.ts" },
    ]
  }
 ]
 ```

 <Tabs>
 <TabItem value="❌ Incorrect">

 ```ts option='{"allow":[{ "from": "file", "name": "BrandedString" }]}'
 declare const unbrandedString: string;

 const spreadUnbrandedString = [...unbrandedString];
 ```

 </TabItem>
 <TabItem value="✅ Correct">

 ```ts option='{"allow":[{ "from": "file", "name": "BrandedString" }]}'
 type BrandedString = string & { __brand: 'safe' };

 declare const brandedString: BrandedString;

 const spreadBrandedString = [...brandedString];
 ```

 </TabItem>
 </Tabs>

 ## When Not To Use It

 If your application intentionally works with raw data in unusual ways, such as directly manipulating class prototype chains, you might not want this rule.

 If your use cases for unusual spreads only involve a few types, you might consider using [ESLint disable comments](https://eslint.org/docs/latest/use/configure/rules#using-configuration-comments-1) and/or the [`allow` option](#allow) instead of completely disabling this rule.

 ## Further Reading

 - [Strings Shouldn't Be Iterable By Default](https://www.xanthir.com/b4wJ1)
diff --git a/packages/eslint-plugin/src/configs/all.ts b/packages/eslint-plugin/src/configs/all.ts
    '@typescript-eslint/no-meaningless-void-operator': 'error',
    '@typescript-eslint/no-misused-new': 'error',
    '@typescript-eslint/no-misused-promises': 'error',
    '@typescript-eslint/no-misused-spread': 'error',
    '@typescript-eslint/no-mixed-enums': 'error',
    '@typescript-eslint/no-namespace': 'error',
    '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
diff --git a/packages/eslint-plugin/src/configs/disable-type-checked.ts b/packages/eslint-plugin/src/configs/disable-type-checked.ts
    '@typescript-eslint/no-implied-eval': 'off',
    '@typescript-eslint/no-meaningless-void-operator': 'off',
    '@typescript-eslint/no-misused-promises': 'off',
    '@typescript-eslint/no-misused-spread': 'off',
    '@typescript-eslint/no-mixed-enums': 'off',
    '@typescript-eslint/no-redundant-type-constituents': 'off',
    '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off',
diff --git a/packages/eslint-plugin/src/configs/strict-type-checked-only.ts b/packages/eslint-plugin/src/configs/strict-type-checked-only.ts
    '@typescript-eslint/no-implied-eval': 'error',
    '@typescript-eslint/no-meaningless-void-operator': 'error',
    '@typescript-eslint/no-misused-promises': 'error',
    '@typescript-eslint/no-misused-spread': 'error',
    '@typescript-eslint/no-mixed-enums': 'error',
    '@typescript-eslint/no-redundant-type-constituents': 'error',
    '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
diff --git a/packages/eslint-plugin/src/configs/strict-type-checked.ts b/packages/eslint-plugin/src/configs/strict-type-checked.ts
    '@typescript-eslint/no-meaningless-void-operator': 'error',
    '@typescript-eslint/no-misused-new': 'error',
    '@typescript-eslint/no-misused-promises': 'error',
    '@typescript-eslint/no-misused-spread': 'error',
    '@typescript-eslint/no-mixed-enums': 'error',
    '@typescript-eslint/no-namespace': 'error',
    '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
diff --git a/packages/eslint-plugin/src/rules/index.ts b/packages/eslint-plugin/src/rules/index.ts
 import noMeaninglessVoidOperator from './no-meaningless-void-operator';
 import noMisusedNew from './no-misused-new';
 import noMisusedPromises from './no-misused-promises';
 import noMisusedSpread from './no-misused-spread';
 import noMixedEnums from './no-mixed-enums';
 import noNamespace from './no-namespace';
 import noNonNullAssertedNullishCoalescing from './no-non-null-asserted-nullish-coalescing';
  'no-meaningless-void-operator': noMeaninglessVoidOperator,
  'no-misused-new': noMisusedNew,
  'no-misused-promises': noMisusedPromises,
  'no-misused-spread': noMisusedSpread,
  'no-mixed-enums': noMixedEnums,
  'no-namespace': noNamespace,
  'no-non-null-asserted-nullish-coalescing': noNonNullAssertedNullishCoalescing,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,132 @@
		---
		description: 'Disallow using the spread operator when it might cause unexpected behavior.'
		---

		import Tabs from '@theme/Tabs';
		import TabItem from '@theme/TabItem';

		> 🛑 This file is source code, not the primary documentation location! 🛑
		>
		> See https://typescript-eslint.io/rules/no-misused-spread for documentation.

		[Spread syntax](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax) (`...`) is a JavaScript feature for creating an object with the joined properties of one or more other objects.
		TypeScript allows spreading objects whose properties are not typically meant to be enumerated, such as arrays and class instances.

		This rule disallows using the spread syntax on values whose types indicate doing so may cause unexpected behavior.
		That includes the following cases:

		- Spreading a `Promise` into an object.
		You probably meant to `await` it.
		- Spreading a function without properties into an object.
		You probably meant to call it.
		- Spreading an iterable (`Array`, `Map`, etc.) into an object.
		Iterable objects usually do not have meaningful enumerable properties and you probably meant to spread it into an array instead.
		- Spreading a string into an array.
		String enumeration behaviors in JavaScript around encoded characters are often surprising.
		- Spreading a `class` into an object.
		This copies all static own properties of the class, but none of the inheritance chain.
		- Spreading a class instance into an object.
		This does not faithfully copy the instance because only its own properties are copied, but the inheritance chain is lost, including all its methods.

		## Examples

		<Tabs>
		<TabItem value="❌ Incorrect">

		```ts
		declare const promise: Promise<number>;
		const spreadPromise = { ...promise };

		declare function getObject(): Record<string, strings>;
		const getObjectSpread = { ...getObject };

		declare const map: Map<string, number>;
		const mapSpread = { ...map };

		declare const userName: string;
		const characters = [...userName];
		```

		```ts
		declare class Box {
		value: number;
		}
		const boxSpread = { ...Box };

		declare const instance: Box;
		const instanceSpread = { ...box };
		```

		</TabItem>
		<TabItem value="✅ Correct">

		```ts
		declare const promise: Promise<number>;
		const spreadPromise = { ...(await promise) };

		declare function getObject(): Record<string, strings>;
		const getObjectSpread = { ...getObject() };

		declare const map: Map<string, number>;
		const mapObject = Object.fromEntries(map);

		declare const userName: string;
		const characters = userName.split('');
		```

		</TabItem>
		</Tabs>

		## Options

		### `allow`

		{/* insert option description */}

		This option takes the shared [`TypeOrValueSpecifier` format](/packages/type-utils/type-or-value-specifier).

		Examples of a configuration for this option in a `file.ts` file:

		```json
		"@typescript-eslint/no-misused-spread": [
		"error",
		{
		"allow": [
		{ "from": "file", "name": "BrandedString", "path": "file.ts" },
		]
		}
		]
		```

		<Tabs>
		<TabItem value="❌ Incorrect">

		```ts option='{"allow":[{ "from": "file", "name": "BrandedString" }]}'
		declare const unbrandedString: string;

		const spreadUnbrandedString = [...unbrandedString];
		```

		</TabItem>
		<TabItem value="✅ Correct">

		```ts option='{"allow":[{ "from": "file", "name": "BrandedString" }]}'
		type BrandedString = string & { __brand: 'safe' };

		declare const brandedString: BrandedString;

		const spreadBrandedString = [...brandedString];
		```

		</TabItem>
		</Tabs>

		## When Not To Use It

		If your application intentionally works with raw data in unusual ways, such as directly manipulating class prototype chains, you might not want this rule.

		If your use cases for unusual spreads only involve a few types, you might consider using [ESLint disable comments](https://eslint.org/docs/latest/use/configure/rules#using-configuration-comments-1) and/or the [`allow` option](#allow) instead of completely disabling this rule.

		## Further Reading

		- [Strings Shouldn't Be Iterable By Default](https://www.xanthir.com/b4wJ1)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -74,6 +74,7 @@ export = {
		'@typescript-eslint/no-meaningless-void-operator': 'error',
		'@typescript-eslint/no-misused-new': 'error',
		'@typescript-eslint/no-misused-promises': 'error',
		'@typescript-eslint/no-misused-spread': 'error',
		'@typescript-eslint/no-mixed-enums': 'error',
		'@typescript-eslint/no-namespace': 'error',
		'@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -25,6 +25,7 @@ export = {
		'@typescript-eslint/no-implied-eval': 'off',
		'@typescript-eslint/no-meaningless-void-operator': 'off',
		'@typescript-eslint/no-misused-promises': 'off',
		'@typescript-eslint/no-misused-spread': 'off',
		'@typescript-eslint/no-mixed-enums': 'off',
		'@typescript-eslint/no-redundant-type-constituents': 'off',
		'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -22,6 +22,7 @@ export = {
		'@typescript-eslint/no-implied-eval': 'error',
		'@typescript-eslint/no-meaningless-void-operator': 'error',
		'@typescript-eslint/no-misused-promises': 'error',
		'@typescript-eslint/no-misused-spread': 'error',
		'@typescript-eslint/no-mixed-enums': 'error',
		'@typescript-eslint/no-redundant-type-constituents': 'error',
		'@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -36,6 +36,7 @@ export = {
		'@typescript-eslint/no-meaningless-void-operator': 'error',
		'@typescript-eslint/no-misused-new': 'error',
		'@typescript-eslint/no-misused-promises': 'error',
		'@typescript-eslint/no-misused-spread': 'error',
		'@typescript-eslint/no-mixed-enums': 'error',
		'@typescript-eslint/no-namespace': 'error',
		'@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,6 +53,7 @@ import noMagicNumbers from './no-magic-numbers';
		import noMeaninglessVoidOperator from './no-meaningless-void-operator';
		import noMisusedNew from './no-misused-new';
		import noMisusedPromises from './no-misused-promises';
		import noMisusedSpread from './no-misused-spread';
		import noMixedEnums from './no-mixed-enums';
		import noNamespace from './no-namespace';
		import noNonNullAssertedNullishCoalescing from './no-non-null-asserted-nullish-coalescing';
Expand DownExpand Up		@@ -184,6 +185,7 @@ const rules = {
		'no-meaningless-void-operator': noMeaninglessVoidOperator,
		'no-misused-new': noMisusedNew,
		'no-misused-promises': noMisusedPromises,
		'no-misused-spread': noMisusedSpread,
		'no-mixed-enums': noMixedEnums,
		'no-namespace': noNamespace,
		'no-non-null-asserted-nullish-coalescing': noNonNullAssertedNullishCoalescing,
Expand Down