Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-shadow] report correctly on parameters of functions declared with thedeclare keyword#10543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletionspackages/eslint-plugin/src/rules/no-shadow.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,6 +22,10 @@ const allowedFunctionVariableDefTypes = new Set([
AST_NODE_TYPES.TSCallSignatureDeclaration,
AST_NODE_TYPES.TSFunctionType,
AST_NODE_TYPES.TSMethodSignature,
AST_NODE_TYPES.TSEmptyBodyFunctionExpression,
AST_NODE_TYPES.TSDeclareFunction,
Copy link
Contributor

@yeonjuanyeonjuanDec 30, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@ronami IMO,TSConstructSignatureDeclaration andTSConstructorType should also be added, what do you think?

// "ignoreFunctionTypeParameterNameValueShadow": trueconstarg=0;declareconstFoo:{foo:(arg:number)=>void;new(arg:number):void;// 'arg' is already declared in the upper scope on line 2 column 7.}typeBar=new(arg:number)=>void;// 'arg' is already declared in the upper scope on line 2 column 7.

ronami reacted with thumbs up emoji
Copy link
MemberAuthor

@ronamironamiDec 30, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, definitely. Thank you@yeonjuan for catching this 👍

Copy link
Contributor

@yeonjuanyeonjuanDec 30, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@ronami oops. I just edited the comment. I think we should addTSConstructorType also

ronami reacted with rocket emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, I just went over the list of nodes to make sure I didn't miss anything 🙈

Thanks!

yeonjuan reacted with thumbs up emoji
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks! 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@yeonjuan for the catch!

yeonjuan reacted with heart emoji
AST_NODE_TYPES.TSConstructSignatureDeclaration,
AST_NODE_TYPES.TSConstructorType,
]);

export default createRule<Options, MessageIds>({
Expand Down
168 changes: 168 additions & 0 deletionspackages/eslint-plugin/tests/rules/no-shadow/no-shadow.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -203,6 +203,120 @@ interface Test {
},
{
code: `
const arg = 0;

declare function test(arg: string): typeof arg;
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
const arg = 0;

declare const test: (arg: string) => typeof arg;
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
const arg = 0;

declare class Test {
p1(arg: string): typeof arg;
}
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
const arg = 0;

declare const Test: {
new (arg: string): typeof arg;
};
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
const arg = 0;

type Bar = new (arg: number) => typeof arg;
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
const arg = 0;

declare namespace Lib {
function test(arg: string): typeof arg;
}
`,
errors: [
{
data: {
name: 'arg',
shadowedColumn: 7,
shadowedLine: 2,
},
messageId: 'noShadow',
},
],
options: [{ ignoreFunctionTypeParameterNameValueShadow: false }],
},
{
code: `
import type { foo } from './foo';
function doThing(foo: number) {}
`,
Expand DownExpand Up@@ -617,6 +731,60 @@ const arg = 0;

interface Test {
p1(arg: string): typeof arg;
}
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

declare function test(arg: string): typeof arg;
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

declare const test: (arg: string) => typeof arg;
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

declare class Test {
p1(arg: string): typeof arg;
}
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

declare const Test: {
new (arg: string): typeof arg;
};
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

type Bar = new (arg: number) => typeof arg;
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
},
{
code: `
const arg = 0;

declare namespace Lib {
function test(arg: string): typeof arg;
}
`,
options: [{ ignoreFunctionTypeParameterNameValueShadow: true }],
Expand Down
Loading
[8]ページ先頭
©2009-2025 Movatter.jp