fix(eslint-plugin): [array-type] autofix`TsConditionalType` to be wrapped with parentheses#10521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ronami wants to merge1 commit intotypescript-eslint:mainfromronami:array-type-conditional-type-needs-parens

Closed

fix(eslint-plugin): [array-type] autofix`TsConditionalType` to be wrapped with parentheses#10521

ronami wants to merge1 commit intotypescript-eslint:mainfromronami:array-type-conditional-type-needs-parens

Conversation

Copy link

Member

ronami commentedDec 19, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: array-type automatic fix changes type logic when used with conditional types #10519
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR tackles#10519 and adds missing parentheses when auto-fixing aTsConditionalType.

autofix ts-conditional-type to be wrapped with parens

44d65cd

Copy link

Contributor

typescript-eslintbot commentedDec 19, 2024

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 19, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`44d65cd`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67643fd48df0d700081b4201
😎 Deploy Preview	https://deploy-preview-10521--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 21 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports