Thanks for the PR,@OlivierZal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	b771c7f
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6790394a28e6e700084afda9
😎 Deploy Preview	https://deploy-preview-10517--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 88 (🔴 down 10 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

View yourCI Pipeline Execution ↗ for commitb771c7f.

☁️Nx Cloud last updated this comment at2025-01-22 05:56:38 UTC

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.18%. Comparing base(a6e3fcd) to head(b771c7f).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@##             main   #10517      +/-   ##==========================================+ Coverage   87.17%   87.18%   +0.01%==========================================  Files         448      450       +2       Lines       15598    15617      +19       Branches     4555     4562       +7     ==========================================+ Hits        13597    13616      +19  Misses       1645     1645                Partials      356      356

@JoshuaKGoldberg,@kirkwaiblinger,this check seems to be stuck.

However, tests passed so I guess the PR is ready for a first review.

Hi@JoshuaKGoldberg, thanks for the review, I've made at least 2 of the requested changes:

• handlingnit;
• addingoriginal issue tests;
• adding more testshere andhere.

Regarding the fix/suggestion logic tests following theisFixable modification, the only change is the introduction of an "implicitEquality" case (I made it a constant in20db420 for more clarity):

• thefirst occurrence is actually the negation of this case in order to keep the pre-existing logic, so it is already covered by the existing tests;
• thenext condition (handling== /!= operators) excludes this "implicitEquality" case (so it is also covered by the existing tests);
• thenext one (handlingany /unknown types) leads to always valid expressions (no fix/suggestion), covered by the tests I've addedhere;
• thenthe "implicitEquality" case occurs: the fix/suggestion logic for invalid expressions is coveredhere (x ?? y), tests for valid expressions (no fix/suggestion) have been addedhere;
• the following excludes the "implicitEquality" case since areturn already happenedhere in such a case (so they are also covered by the existing tests);
• the fix/suggestion logic related tothis addition is tested by the "invalid" tests I've added –!x ? y : x for the "consequent" case andx ? x : y for the "alternate" case (handles the new!operator condition) –, which all fallhere (x ?? y).

Do you see any other cases I’ve missed that I could add? Or do you have something else in mind?

@JoshuaKGoldberg,@kirkwaiblinger, waiting for this PR having a second review, I keep updating the branch each time a new PR is merged. Is it the right thing to do, or can I leave it as is until the review?

Ready for review, but I remain open to feedback on#10517 (comment)

@kirkwaiblinger, I’m delighted I wasn’t too far off the mark 😅. Ultimately, I realized that the inconsistency mentioned in the corresponding issue went beyond the cited example, and since I’m still quite new to the project, I wasn’t entirely sure if taking a few liberties was appropriate.

Thank you so much for your time, help, and guidance.

Thelast commit only fixes a lint issue inthis commit; all the other checks passed successfully.

Fixed!