Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess true#10514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfromyeonjuan:fixes/10509
Dec 23, 2024

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

controversial reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 17, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit31f10b0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6761b7da07027900081c63fb
😎 Deploy Previewhttps://deploy-preview-10514--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedDec 17, 2024•
edited
Loading

View yourCI Pipeline Execution ↗ for commit31f10b0.

CommandStatusDurationResult
nx run-many --target=build --exclude website --...✅ Succeeded24sView ↗
nx run-many --target=clean✅ Succeeded12sView ↗

☁️Nx Cloud last updated this comment at2024-12-21 15:00:51 UTC

@codecovCodecov
Copy link

codecovbot commentedDec 17, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base(b2ce158) to head(31f10b0).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10514   +/-   ##=======================================  Coverage   86.78%   86.79%           =======================================  Files         445      445             Lines       15366    15369    +3       Branches     4475     4475           =======================================+ Hits        13336    13339    +3  Misses       1675     1675             Partials      355      355
FlagCoverage Δ
unittest86.79% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts99.21% <100.00%> (+<0.01%)⬆️

... and1 file with indirect coverage changes

@yeonjuanyeonjuan marked this pull request as ready for reviewDecember 17, 2024 17:19
@yeonjuanyeonjuan changed the titlefix(eslint-plugin): [no-unnecessary-condition] handle index signaturefix(eslint-plugin): [no-unnecessary-condition] handle when noUncheckedIndexedAccess trueDec 17, 2024
@yeonjuanyeonjuan changed the titlefix(eslint-plugin): [no-unnecessary-condition] handle when noUncheckedIndexedAccess truefix(eslint-plugin): [no-unnecessary-condition] handle noUncheckedIndexedAccess trueDec 17, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tricky! Thanks for the fix and good discussion behind it. I'm irked I didn't catch it in review originally. 😄

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelDec 21, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit83c3bbf intotypescript-eslint:mainDec 23, 2024
62 of 64 checks passed
renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull requestDec 23, 2024
| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.18.1 | 8.18.2 || npm        | @typescript-eslint/parser        | 8.18.1 | 8.18.2 |## [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23)##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514))-   **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503))-   **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461))-   **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490))-   **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473))-   **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494))-   **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498))##### ❤️ Thank You-   Luke Deen Taylor [@controversial](https://github.com/controversial)-   Ronen Amiel-   Scott O'Hara-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull requestDec 23, 2024
##### [v8.18.2](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8182-2024-12-23)##### 🩹 Fixes-   **eslint-plugin:** \[no-unnecessary-condition] handle noUncheckedIndexedAccess true ([#10514](typescript-eslint/typescript-eslint#10514))-   **eslint-plugin:** \[consistent-type-assertions] allow default assertionStyle option ([#10512](typescript-eslint/typescript-eslint#10512))-   **eslint-plugin:** \[no-unnecessary-type-arguments] handle type/value context ([#10503](typescript-eslint/typescript-eslint#10503))-   **eslint-plugin:** \[no-unsafe-type-assertion] fix for unsafe assertion to a constrained type parameter ([#10461](typescript-eslint/typescript-eslint#10461))-   **eslint-plugin:** \[consistent-indexed-object-style] use a suggestion over an auto-fix if can't reliably determine that produced index signature is valid ([#10490](typescript-eslint/typescript-eslint#10490))-   **eslint-plugin:** \[no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter ([#10473](typescript-eslint/typescript-eslint#10473))-   **eslint-plugin:** \[prefer-reduce-type-parameter] don't report cases in which the fix results in a type error ([#10494](typescript-eslint/typescript-eslint#10494))-   **eslint-plugin:** \[no-deprecated] not reporting usages of deprecated declared constants as object value ([#10498](typescript-eslint/typescript-eslint#10498))##### ❤️ Thank You-   Luke Deen Taylor [@controversial](https://github.com/controversial)-   Ronen Amiel-   Scott O'Hara-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)-   Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-condition] regression with types that includeundefined under noUncheckedIndexedAccess
2 participants
@yeonjuan@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp