Dec 15, 2024 · Dec 8, 2024
diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
        },
      ],
    },
    {
      code: `
 const command = (): ParameterDecorator => {
  return () => {};
 };

 export class Foo {
  bar(@command() command: string) {}
 }
      `,
      errors: [
        {
          data: {
            action: 'defined',
            additional: '',
            varName: 'command',
          },
          line: 7,
          messageId: 'unusedVar',
        },
      ],
    },
    {
      code: `
 declare const deco: () => ParameterDecorator;

 export class Foo {
  bar(@deco() deco, @deco() param) {}
 }
      `,
      errors: [
        {
          column: 15,
          data: {
            action: 'defined',
            additional: '',
            varName: 'deco',
          },
          line: 5,
          messageId: 'unusedVar',
        },
        {
          data: {
            action: 'defined',
            additional: '',
            varName: 'param',
          },
          line: 5,
          messageId: 'unusedVar',
        },
      ],
    },
  ],

  valid: [
      `,
      options: [{ reportUsedIgnorePattern: true, varsIgnorePattern: '_' }],
    },
    `
 const command = (): ParameterDecorator => {
  return () => {};
 };

 export class Foo {
  bar(@command() command: string) {
    console.log(command);
  }
 }
    `,
  ],
 });
diff --git a/packages/scope-manager/src/referencer/ClassVisitor.ts b/packages/scope-manager/src/referencer/ClassVisitor.ts
      this.#referencer.scopeManager.nestFunctionExpressionNameScope(node);
    }

    node.params.forEach(param => {
      param.decorators.forEach(d => this.visit(d));
    });

    // Consider this function is in the MethodDefinition.
    this.#referencer.scopeManager.nestFunctionScope(node, true);

        { processRightHandNodes: true },
      );
      this.visitFunctionParameterTypeAnnotation(param);
      param.decorators.forEach(d => this.visit(d));
    }

    this.visitType(node.returnType);
diff --git a/packages/scope-manager/tests/fixtures/decorators/parameter-property.ts.shot b/packages/scope-manager/tests/fixtures/decorators/parameter-property.ts.shot
diff --git a/packages/scope-manager/tests/fixtures/decorators/parameter.ts b/packages/scope-manager/tests/fixtures/decorators/parameter.ts
 function decorator() {}
 class A {
  foo(@decorator a, @decorator [b], @decorator { c }, @decorator d = 1) {}
  foo(
    @decorator a,
    @decorator [b],
    @decorator { c },
    @decorator d = 1,
    @decorator decorator,
    @d decorator,
  ) {}
 }
diff --git a/packages/scope-manager/tests/fixtures/decorators/parameter.ts.shot b/packages/scope-manager/tests/fixtures/decorators/parameter.ts.shot
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1116,6 +1116,58 @@ export const x = _Foo;
		},
		],
		},
		{
		code: `
		const command = (): ParameterDecorator => {
		return () => {};
		};

		export class Foo {
		bar(@command() command: string) {}
		}
		`,
		errors: [
		{
		data: {
		action: 'defined',
		additional: '',
		varName: 'command',
		},
		line: 7,
		messageId: 'unusedVar',
		},
		],
		},
		{
		code: `
		declare const deco: () => ParameterDecorator;

		export class Foo {
		bar(@deco() deco, @deco() param) {}
		}
		`,
		errors: [
		{
		column: 15,
		data: {
		action: 'defined',
		additional: '',
		varName: 'deco',
		},
		line: 5,
		messageId: 'unusedVar',
		},
		{
		data: {
		action: 'defined',
		additional: '',
		varName: 'param',
		},
		line: 5,
		messageId: 'unusedVar',
		},
		],
		},
		],

		valid: [
Expand DownExpand Up		@@ -2274,5 +2326,16 @@ export enum Foo {
		`,
		options: [{ reportUsedIgnorePattern: true, varsIgnorePattern: '_' }],
		},
		`
		const command = (): ParameterDecorator => {
		return () => {};
		};

		export class Foo {
		bar(@command() command: string) {
		console.log(command);
		}
		}
		`,
		],
		});
Original file line number	Diff line number	Diff line change
Expand Up		@@ -115,6 +115,10 @@ class ClassVisitor extends Visitor {
		this.#referencer.scopeManager.nestFunctionExpressionNameScope(node);
		}

		node.params.forEach(param => {
		param.decorators.forEach(d => this.visit(d));
		});

		// Consider this function is in the MethodDefinition.
		this.#referencer.scopeManager.nestFunctionScope(node, true);

Expand DownExpand Up		@@ -205,7 +209,6 @@ class ClassVisitor extends Visitor {
		{ processRightHandNodes: true },
		);
		this.visitFunctionParameterTypeAnnotation(param);
		param.decorators.forEach(d => this.visit(d));
		}

		this.visitType(node.returnType);
Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,4 +1,11 @@
		function decorator() {}
		class A {
		foo(@decorator a, @decorator [b], @decorator { c }, @decorator d = 1) {}
		foo(
		@decorator a,
		@decorator [b],
		@decorator { c },
		@decorator d = 1,
		@decorator decorator,
		@d decorator,
		) {}
		}