Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [no-unnecessary-condition] don't flag values of an unconstrained or valid type parameter#10473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromronami:no-unnecessary-condition-dont-flag-unconstrained-or-valid-constraintDec 21, 2024
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
4 commits Select commitHold shift + click to select a range
40a0961 [no-unnecessary-condition] don't flag values of an unconstrained or v…
ronami991ff23 use a much simpelr for loop instead of several confusing .some() checks
ronamid33a7d4 bail early if both a possibly-truthy and a possibly-falsy have been d…
ronamiff59a13 put back code that checks non-callables
ronamiFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
47 changes: 39 additions & 8 deletionspackages/eslint-plugin/src/rules/no-unnecessary-condition.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -646,22 +646,53 @@ export default createRule<Options, MessageId>({ | ||
| .getCallSignaturesOfType( | ||
| getConstrainedTypeAtLocation(services, callback), | ||
| ) | ||
| .map(sig => sig.getReturnType()) | ||
| .map(t => { | ||
| // TODO: use `getConstraintTypeInfoAtLocation` once it's merged | ||
| // https://github.com/typescript-eslint/typescript-eslint/pull/10496 | ||
| if (tsutils.isTypeParameter(t)) { | ||
| return checker.getBaseConstraintOfType(t); | ||
| } | ||
| return t; | ||
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }); | ||
| if (returnTypes.length === 0) { | ||
| // Not a callable function, e.g. `any` | ||
| return; | ||
kirkwaiblinger marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } | ||
| let hasFalsyReturnTypes = false; | ||
| let hasTruthyReturnTypes = false; | ||
JoshuaKGoldberg marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| for (const type of returnTypes) { | ||
| // Predicate is always necessary if it involves `any` or `unknown` | ||
| if (!type || isTypeAnyType(type) || isTypeUnknownType(type)) { | ||
| return; | ||
| } | ||
| if (isPossiblyFalsy(type)) { | ||
| hasFalsyReturnTypes = true; | ||
| } | ||
| if (isPossiblyTruthy(type)) { | ||
| hasTruthyReturnTypes = true; | ||
| } | ||
| // bail early if both a possibly-truthy and a possibly-falsy have been detected | ||
| if (hasFalsyReturnTypes && hasTruthyReturnTypes) { | ||
| return; | ||
| } | ||
| } | ||
| if (!hasFalsyReturnTypes) { | ||
| return context.report({ | ||
| node: callback, | ||
| messageId: 'alwaysTruthyFunc', | ||
| }); | ||
| } | ||
| if (!hasTruthyReturnTypes) { | ||
| return context.report({ | ||
| node: callback, | ||
| messageId: 'alwaysFalsyFunc', | ||
24 changes: 24 additions & 0 deletionspackages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.