typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types#10454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromkirkwaiblinger:nuc

Dec 14, 2024

Merged

fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types#10454

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfromkirkwaiblinger:nuc

Dec 14, 2024

Conversation

Copy link

Member

kirkwaiblinger commentedDec 5, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: [no-unnecessary-condition] improve error message for statically analyzable literal type comparisons again #10455
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

better boolean literal compare message

ad5760a

Copy link

Contributor

typescript-eslintbot commentedDec 5, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 5, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3d1186a`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/675dc61dd963020008b414f5
😎 Deploy Preview	https://deploy-preview-10454--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedDec 5, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3d1186a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

kirkwaiblinger mentioned this pull request

Dec 5, 2024

Enhancement: [no-unnecessary-condition] improve error message for statically analyzable literal type comparisons again#10455

Closed

4 tasks

Copy link

codecovbot commentedDec 5, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base(eaae68c) to head(3d1186a).

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10454   +/-   ##=======================================  Coverage   86.78%   86.78%           =======================================  Files         445      445             Lines       15365    15365             Branches     4475     4475           =======================================  Hits        13335    13335             Misses       1675     1675             Partials      355      355

Flag	Coverage Δ
unittest	`86.78% <ø> (ø)`

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	`99.20% <ø> (ø)`

kirkwaiblinger commented

Dec 6, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-unnecessary-condition.ts OutdatedShow resolvedHide resolved

rename

ef65a13

kirkwaiblinger marked this pull request as ready for review

December 6, 2024 17:45

kirkwaiblinger changed the title~~fix(eslint-plugin): [no-unnecessary-condition] better boolean literal compare message~~fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types

Dec 6, 2024

JoshuaKGoldberg previously approved these changes

Dec 14, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to merge this before our Monday release.@kirkwaiblinger if you want to switch it over before then, feel free to do it and merge yourself (or if you're in a rush, just ping me and I can).

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Dec 14, 2024

kirkwaiblinger added2 commits

December 14, 2024 10:50

Merge branch 'main' into nuc

160d49a

use typeToString

3d1186a

kirkwaiblinger dismissedJoshuaKGoldberg’sstale review via3d1186a

December 14, 2024 17:53

kirkwaiblinger requested a review fromJoshuaKGoldberg

December 14, 2024 17:57

Copy link

MemberAuthor

kirkwaiblinger commentedDec 14, 2024

should be good to merge now 👍

github-actionsbot removed the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Dec 14, 2024

JoshuaKGoldberg approved these changes

Dec 14, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yay!

JoshuaKGoldberg merged commit334d025 intotypescript-eslint:main

Dec 14, 2024

63 checks passed

kirkwaiblinger deleted the nuc branch

December 15, 2024 01:29

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 16, 2024

fix(deps): update typescript-eslint monorepo to v8.18.1

665559d

##### [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)##### 🩹 Fixes-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 16, 2024

Update typescript-eslint monorepo to v8.18.1

6d067c7

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.18.0 | 8.18.1 || npm        | @typescript-eslint/parser        | 8.18.0 | 8.18.1 |## [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)##### 🩹 Fixes-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 24, 2024

Labels

None yet

2 participants

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types#10454

fix(eslint-plugin): [no-unnecessary-condition] better message when comparing between literal types#10454

Uh oh!

Conversation

kirkwaiblinger commentedDec 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedDec 5, 2024

Uh oh!

netlifybot commentedDec 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedDec 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedDec 5, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

kirkwaiblinger commentedDec 14, 2024

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kirkwaiblinger commentedDec 5, 2024•
edited
Loading

netlifybot commentedDec 5, 2024•
edited
Loading

nx-cloudbot commentedDec 5, 2024•
edited
Loading

codecovbot commentedDec 5, 2024•
edited
Loading