typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.7k

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromronami:no-unnecessary-template-expression-include-comments

Dec 14, 2024

Merged

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromronami:no-unnecessary-template-expression-include-comments

Dec 14, 2024

Conversation

Copy link

Member

ronami commentedDec 2, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [no-unnecessary-template-expression] Should not report when expression includes comment #10434
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR addresses#10434 and stops the rule from reporting on expressions that include comments:

`${/* intentional comment */'foo'}...`;

ronami added4 commits

December 2, 2024 22:02

initial implementation

e0b6a37

refactor and handle the case of a single string variable

fe8c81f

refactor hasCommentsBetween => hasCommentsBetweenQuasi

eaa7eae

add an istanbul-ignore-next-comment to what seems like an unreachable…

5cc8485

… line

Copy link

Contributor

typescript-eslintbot commentedDec 2, 2024

Thanks for the PR,@ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 2, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`869b2ae`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/674f3963344b0e0008309812
😎 Deploy Preview	https://deploy-preview-10444--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedDec 2, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit869b2ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedDec 2, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base(2c8a75e) to head(869b2ae).
Report is 27 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10444   +/-   ##=======================================  Coverage   86.76%   86.77%           =======================================  Files         444      444             Lines       15311    15320    +9       Branches     4457     4461    +4     =======================================+ Hits        13285    13294    +9  Misses       1672     1672             Partials      354      354

Flag	Coverage Δ
unittest	`86.77% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...in/src/rules/no-unnecessary-template-expression.ts	`98.85% <100.00%> (+0.10%)`	⬆️

... and1 file with indirect coverage changes

ronami added2 commits

December 2, 2024 22:38

remove istanbul-ignore-next comment and use nullThrows instead

cfcb4a0

missing tests

fead0e0

ronami marked this pull request as ready for review

December 2, 2024 21:15

test line comments, not just block comments

869b2ae

JoshuaKGoldberg approved these changes

Dec 14, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg merged commitd5415e2 intotypescript-eslint:main

Dec 14, 2024

67 of 68 checks passed

ronami deleted the no-unnecessary-template-expression-include-comments branch

December 14, 2024 15:17

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 16, 2024

fix(deps): update typescript-eslint monorepo to v8.18.1

665559d

##### [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)##### 🩹 Fixes-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 16, 2024

Update typescript-eslint monorepo to v8.18.1

6d067c7

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.18.0 | 8.18.1 || npm        | @typescript-eslint/parser        | 8.18.0 | 8.18.1 |## [v8.18.1](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8181-2024-12-16)##### 🩹 Fixes-   **scope-manager:** visit params decorator before nest scope ([#10475](typescript-eslint/typescript-eslint#10475))-   **eslint-plugin:** \[no-unnecessary-condition] better message when comparing between literal types ([#10454](typescript-eslint/typescript-eslint#10454))-   **eslint-plugin:** use consistent naming for asserting types and casting values ([#10472](typescript-eslint/typescript-eslint#10472))-   **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] flag values of a type parameter with boolean type constraints ([#10474](typescript-eslint/typescript-eslint#10474))-   **eslint-plugin:** handle string like index type ([#10460](typescript-eslint/typescript-eslint#10460))-   **eslint-plugin:** \[no-unnecessary-template-expression] don't report when an expression includes comment ([#10444](typescript-eslint/typescript-eslint#10444))##### ❤️ Thank You-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Ronen Amiel-   YeonJuan [@yeonjuan](https://github.com/yeonjuan)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 22, 2024

Labels

None yet

2 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

Uh oh!

Conversation

ronami commentedDec 2, 2024•
edited
Loading

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedDec 2, 2024

Uh oh!

netlifybot commentedDec 2, 2024•
edited
Loading

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedDec 2, 2024•
edited
Loading

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedDec 2, 2024•
edited
Loading

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

fix(eslint-plugin): [no-unnecessary-template-expression] don't report when an expression includes comment#10444

Uh oh!

Conversation

ronami commentedDec 2, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedDec 2, 2024

Uh oh!

netlifybot commentedDec 2, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedDec 2, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedDec 2, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronami commentedDec 2, 2024•
edited
Loading

netlifybot commentedDec 2, 2024•
edited
Loading

nx-cloudbot commentedDec 2, 2024•
edited
Loading

codecovbot commentedDec 2, 2024•
edited
Loading