typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown#10392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfrombkks1004:main

Dec 2, 2024

Merged

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown#10392

JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfrombkks1004:main

Dec 2, 2024

Conversation

Copy link

Contributor

bkks1004 commentedNov 25, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesEnhancement: [prefer-promise-reject-errors] Options to allowany andunknown #10375
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

feat: [prefer-promise-reject-errors] Options to allow any and unknown

4f2f7de

Copy link

Contributor

typescript-eslintbot commentedNov 25, 2024

Thanks for the PR,@bkks1004!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 25, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`6e98571`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/674dd250626b3e000873d893
😎 Deploy Preview	https://deploy-preview-10392--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedNov 25, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit6e98571. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 fromNxCloud.

bkks1004 changed the title~~feat: [prefer-promise-reject-errors] Options to allow any and unknown~~feat(eslint-plugin): [prefer-promise-reject-errors] Options to allow any and unknown

Nov 25, 2024

Copy link

codecovbot commentedNov 25, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base(c1b1106) to head(d600328).
Report is 8 commits behind head on main.

❗Current headd600328 differs from pull request most recent head6e98571
Pleaseupload reports for the commit6e98571 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10392   +/-   ##=======================================  Coverage   86.75%   86.75%           =======================================  Files         443      443             Lines       15289    15293    +4       Branches     4446     4448    +2     =======================================+ Hits        13264    13268    +4  Misses       1672     1672             Partials      353      353

Flag	Coverage Δ
unittest	`86.75% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
...t-plugin/src/rules/prefer-promise-reject-errors.ts	`100.00% <100.00%> (ø)`

injae-kim mentioned this pull request

Nov 25, 2024

Enhancement: [prefer-promise-reject-errors] Options to allowany andunknown#10375

Closed

4 tasks

bkks1004 changed the title~~feat(eslint-plugin): [prefer-promise-reject-errors] Options to allow any and unknown~~feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown

Nov 25, 2024

Merge branch 'main' into main

d600328

JoshuaKGoldberg previously approved these changes

Dec 2, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great to me, thanks! 🚀

packages/eslint-plugin/docs/rules/prefer-promise-reject-errors.mdx OutdatedShow resolvedHide resolved

JoshuaKGoldberg reviewed

Dec 2, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/prefer-promise-reject-errors.test.ts

Copy link

Member

JoshuaKGoldbergDec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] These test cases are super clean, nice. 🔥

JoshuaKGoldberg dismissed theirstale review via6e98571

December 2, 2024 15:29

Apply suggestions from code review

6e98571

JoshuaKGoldberg merged commit670df27 intotypescript-eslint:main

Dec 2, 2024

7 of 8 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 2, 2024

fix(deps): update typescript-eslint monorepo to v8.17.0

cfe1395

##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)##### 🚀 Features-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))##### 🩹 Fixes-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))##### ❤️  Thank You-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 2, 2024

fix(deps): update typescript-eslint monorepo to v8.17.0

c381fc1

##### [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)##### 🚀 Features-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))##### 🩹 Fixes-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))##### ❤️  Thank You-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 3, 2024

Update typescript-eslint monorepo to v8.17.0

d41dde8

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 || npm        | @typescript-eslint/parser        | 8.16.0 | 8.17.0 |## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)##### 🚀 Features-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))##### 🩹 Fixes-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))##### ❤️  Thank You-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 3, 2024

Update typescript-eslint monorepo to v8.17.0

5ed9332

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.16.0 | 8.17.0 || npm        | @typescript-eslint/parser        | 8.16.0 | 8.17.0 |## [v8.17.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8170-2024-12-02)##### 🚀 Features-   **eslint-plugin:** \[prefer-promise-reject-errors] options to allow any and unknown ([#10392](typescript-eslint/typescript-eslint#10392))##### 🩹 Fixes-   **eslint-plugin:** \[promise-function-async] handle function overloading ([#10304](typescript-eslint/typescript-eslint#10304))-   **eslint-plugin:** remove references to "extendDefaults" in no-restricted-types ([#10401](typescript-eslint/typescript-eslint#10401))-   **eslint-plugin:** \[no-unnecessary-template-expressions] allow template expressions used to make trailing whitespace visible ([#10363](typescript-eslint/typescript-eslint#10363))##### ❤️  Thank You-   Kim OhSeong [@bkks1004](https://github.com/bkks1004)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   Maria José Solano [@MariaSolOs](https://github.com/MariaSolOs)-   Ronen AmielYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 13, 2024

Labels

None yet

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown#10392

feat(eslint-plugin): [prefer-promise-reject-errors] options to allow any and unknown#10392

Uh oh!

Conversation

bkks1004 commentedNov 25, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedNov 25, 2024

Uh oh!

netlifybot commentedNov 25, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedNov 25, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedNov 25, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldbergDec 2, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bkks1004 commentedNov 25, 2024•
edited
Loading

netlifybot commentedNov 25, 2024•
edited
Loading

nx-cloudbot commentedNov 25, 2024•
edited
Loading

codecovbot commentedNov 25, 2024•
edited
Loading