typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star16k

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated#10374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 12 commits intotypescript-eslint:mainfrommdm317:fix/issue-10275-no-deprecated

Dec 7, 2024

Merged

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated#10374

JoshuaKGoldberg merged 12 commits intotypescript-eslint:mainfrommdm317:fix/issue-10275-no-deprecated

Dec 7, 2024

+163 −15

Conversation

Copy link

Contributor

mdm317 commentedNov 23, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesBug: [no-deprecated] No warnings about usage of deprecated props in JSX components #10275
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Added a logic to check deprecated attributes from JSDoc when used in JSX.

mdm317 added2 commits

November 23, 2024 16:12

test : add testcase

ea6c5ec

fix : check if a JSX attribute is deprecated

a06f122

Copy link

Contributor

typescript-eslintbot commentedNov 23, 2024

Thanks for the PR,@mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 23, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`ae9717e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6753f93941e10500089d8278
😎 Deploy Preview	https://deploy-preview-10374--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedNov 23, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitae9717e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 fromNxCloud.

test : fix text result

ba379b4

Copy link

codecovbot commentedNov 23, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base(0d0722c) to head(ae9717e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@##             main   #10374   +/-   ##=======================================  Coverage   86.76%   86.77%           =======================================  Files         444      444             Lines       15313    15320    +7       Branches     4459     4461    +2     =======================================+ Hits        13287    13294    +7  Misses       1672     1672             Partials      354      354

Flag	Coverage Δ
unittest	`86.77% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`93.61% <100.00%> (+0.51%)`	⬆️

JoshuaKGoldberg requested changes

Nov 24, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Codecov is letting us know that a couple areas of code aren't covered by unit tests. For each, one of the following is true:

The code is reachable, so a unit test should exercise it
The code can be refactored to not include that case (e.g. passing a narrowed value around instead of re-checking something)
This is some edge case in TypeScript-land and a type assertion should be used (instead of a runtime check)

I can re-review once the test coverage gaps are gone. Cheers!

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 24, 2024

Josh-Cena reviewed

Nov 25, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts OutdatedShow resolvedHide resolved

mdm317 added6 commits

November 26, 2024 19:03

fix : check all jsx names

8b90666

test : add test case for all jsx name

63afd1d

Merge branch 'main' into fix/issue-10275-no-deprecated

f1c5b10

test : increase coverage

e25b6a2

fix : type assertion for test coverage

96f3b76

refactor : change variable name

3309db8

mdm317 requested a review fromJoshuaKGoldberg

November 29, 2024 13:56

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 29, 2024

JoshuaKGoldberg requested changes

Dec 2, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Implementation looks great to me, very nicely done! 👏

Just requesting changes on a bit more tests, since there's the trickynullThrows. Thanks!

packages/eslint-plugin/src/rules/no-deprecated.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-deprecated.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 2, 2024

mdm317and others added3 commits

December 7, 2024 16:09

Update packages/eslint-plugin/src/rules/no-deprecated.ts

63b00e1

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

Merge branch 'main' into fix/issue-10275-no-deprecated

b808836

Add a test case namespace and attribute are of type "any" "unknown" "…

ae9717e

…error"

mdm317 requested a review fromJoshuaKGoldberg

December 7, 2024 08:28

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 7, 2024

JoshuaKGoldberg approved these changes

Dec 7, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Glorious! Thank you! 🙌

JoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Dec 7, 2024

JoshuaKGoldberg merged commit772bd43 intotypescript-eslint:main

Dec 7, 2024

65 checks passed

renovatebot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request

Dec 9, 2024

fix(deps): update typescript-eslint monorepo to v8.18.0

46e638c

##### [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 10, 2024

Update typescript-eslint monorepo to v8.18.0

51f306c

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 || npm        | @typescript-eslint/parser        | 8.17.0 | 8.18.0 |## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

renovatebot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request

Dec 10, 2024

Update typescript-eslint monorepo to v8.18.0

0ec3b28

| datasource | package                          | from   | to     || ---------- | -------------------------------- | ------ | ------ || npm        | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 || npm        | @typescript-eslint/parser        | 8.17.0 | 8.18.0 |## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09)##### 🚀 Features-   **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218))-   **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397))##### 🩹 Fixes-   **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436))-   **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432))-   **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374))-   typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373))##### ❤️  Thank You-   Kim Sang Du [@developer-bandi](https://github.com/developer-bandi)-   Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger)-   mdm317-   rtrittoYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

This was referencedDec 11, 2024

Issue: '@typescript-eslint/no-deprecated' seems brokentools-aoeur/eslint-config#13

Closed

fix: Package update including typescript deprecation checker fixtools-aoeur/eslint-config#17

Merged

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 20, 2024

Labels

1 approval

>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Movatterモバイル変換

Uh oh!

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated#10374

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated#10374

Conversation

mdm317 commentedNov 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

typescript-eslintbot commentedNov 23, 2024

Uh oh!

netlifybot commentedNov 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

nx-cloudbot commentedNov 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

codecovbot commentedNov 23, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mdm317 commentedNov 23, 2024•
edited
Loading

netlifybot commentedNov 23, 2024•
edited
Loading

nx-cloudbot commentedNov 23, 2024•
edited
Loading

codecovbot commentedNov 23, 2024•
edited
Loading