Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(typescript-eslint): allow infinitely deep array nesting in config function and extends#10333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomainfrombjz/infinite-array-nesting
Nov 16, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

This has been a pet peeve of mine for a long while now and I've been meaning to action it as a big DevX improvement.

This PR simply allows users to infinitely nest arrays in thetseslint.config utility input AND in theextends key.

The docs updates are proof enough of how much this simplifies things.

Note thatESLint upstream is planning on allowing nested arrays which is what spurred me to build it right now.

kirkwaiblinger and JoshuaKGoldberg reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@bradzacherbradzacher added the enhancementNew feature or request labelNov 15, 2024
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedNov 15, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit17eb11a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx run integration-tests:test
✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

@netlifyNetlify
Copy link

netlifybot commentedNov 15, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit17eb11a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6738101e6f59ef00086f3bfc
😎 Deploy Previewhttps://deploy-preview-10333--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@kirkwaiblinger
Copy link
Member

Oh,hell yes ❤️

@Josh-Cena
Copy link
Member

You would need to add this to the config reference docs otherwise LGTM 👍

@codecovCodecov
Copy link

codecovbot commentedNov 15, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base(00a3a84) to head(17eb11a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@##             main   #10333   +/-   ##=======================================  Coverage   86.63%   86.63%           =======================================  Files         433      433             Lines       15202    15204    +2       Branches     4439     4439           =======================================+ Hits        13170    13172    +2  Misses       1675     1675             Partials      357      357
FlagCoverage Δ
unittest86.63% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files with missing linesCoverage Δ
packages/typescript-eslint/src/config-helper.ts100.00% <100.00%> (ø)

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesNov 15, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hell yeah!!

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelNov 15, 2024
@bradzacher
Copy link
MemberAuthor

You would need to add this to the config reference docs otherwise LGTM

@Josh-Cena what docs are you referring to, sorry?
I searched for all spreads and cleaned them up.

I didn't explicitly mention this behaviour in the docs - but we could do if we wanted.

@bradzacher
Copy link
MemberAuthor

I'm going to merge this as is -- we can always follow-up to add more docs later.

@bradzacherbradzacher merged commitb351703 intomainNov 16, 2024
6 checks passed
@bradzacherbradzacher deleted the bjz/infinite-array-nesting branchNovember 16, 2024 03:23
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 26, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergeenhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@bradzacher@kirkwaiblinger@Josh-Cena@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp